Skip to contentSkip to conversation

nvme: fix warn output about shared namespaces without CONFIG_NVME_MULTIPATH

PATCH Superseded Yi Zhang 3 participants 5 messages Apr 8, 2024 – Apr 10, 2024 NVMe

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Yi Zhang

author
#0 lore raw

PATCH 1/1 nvme: fix warn output about shared namespaces without CONFIG_NVME_MULTIPATH

Only print oneline log about shared namespaces without CONFIG_NVME_MULTIPATH

Fixes ce8d78616a6b ("nvme: warn about shared namespaces without CONFIG_NVME_MULTIPATH")
---
 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/core.c +1 -1
index 27281a9a8951..e4bec200ebeb 100644
@@ -3681,7 +3681,7 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info)
 				"Found shared namespace %d, but multipathing not supported.\n",
 				info->nsid);
 			dev_warn_once(ctrl->device,
-				"Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0\n.");
+				"Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0.\n");
 		}
 	}
 
Signature · 1 line
2.34.3
#1 lore raw

The commit log is a bit weird. What this does is to remove the stray dot after the newline, right? Maybe state that, and whie you're at it cut the commit log line to 73 characters and make sure it ends with a dot.

The change itself looks good to me, thanks!

author
#2 lore raw
Quoted 5 lines · Christoph Hellwig

The commit log is a bit weird. What this does is to remove the stray dot after the newline, right? Maybe state that, and whie you're at it cut the commit log line to 73 characters and make sure it ends with a dot.

Thanks, will update it at v2.

Quoted 3 lines

The change itself looks good to me, thanks!

Signature · 2 lines
Best Regards,
  Yi Zhang
#3 lore raw
In reply to Yi Zhang
Quoted 2 lines · Yi Zhang

Only print oneline log about shared namespaces without CONFIG_NVME_MULTIPATH

Consider following commit log :-

Move the period '.'that is currently at the end of the line after
newline '\n' to
before newline character which is the right position.

Quoted 18 lines
Fixes ce8d78616a6b ("nvme: warn about shared namespaces without CONFIG_NVME_MULTIPATH") > Signed-off-by: Yi Zhang <[email protected]>
---
  drivers/nvme/host/core.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/core.c +1 -1
index 27281a9a8951..e4bec200ebeb 100644
@@ -3681,7 +3681,7 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info)
  				"Found shared namespace %d, but multipathing not supported.\n",
  				info->nsid);
  			dev_warn_once(ctrl->device,
-				"Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0\n.");
+				"Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0.\n");
  		}
  	}
 
author
#4 lore raw
Quoted 10 lines · Chaitanya Kulkarni
Quoted 2 lines · Yi Zhang

Only print oneline log about shared namespaces without CONFIG_NVME_MULTIPATH

Consider following commit log :-

Move the period '.'that is currently at the end of the line after
newline '\n' to
before newline character which is the right position.

Thanks, just send v2 as suggested.

Quoted 19 lines
Quoted 19 lines
Fixes ce8d78616a6b ("nvme: warn about shared namespaces without CONFIG_NVME_MULTIPATH") > Signed-off-by: Yi Zhang <[email protected]>
---
  drivers/nvme/host/core.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/core.c +1 -1
index 27281a9a8951..e4bec200ebeb 100644
@@ -3681,7 +3681,7 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info)
                              "Found shared namespace %d, but multipathing not supported.\n",
                              info->nsid);
                      dev_warn_once(ctrl->device,
-                             "Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0\n.");
+                             "Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0.\n");
              }
      }
 
Signature · 2 lines
Best Regards,
  Yi Zhang