Skip to contentSkip to conversation

ls-ecaps: Correct IDE link state reporting

PATCH Superseded Alexey Kardashevskiy 1 participant 2 messages Apr 11, 2024 – Apr 15, 2024 PCI

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ls-ecaps: Correct IDE link state reporting

PCIe r6.0, sec 7.9.26.4.2 "Link IDE Stream Status Register defines" the link state as:

0000b Insecure
0010b Secure

The same definition applies to selective streams as well. The existing code wrongly assumes "secure" is 0001b, fix that for both link and selective streams.

Fixes 42fc4263ec0e ("ls-ecaps: Add decode support for IDE Extended Capability")
---
 ls-ecaps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
ls-ecaps.c +1 -1
index b40ba72..5c2724e 100644
@@ -1512,7 +1512,7 @@ static void
 cap_ide(struct device *d, int where)
 {
     const char *hdr_enc_mode[] = { "no", "17:2", "25:2", "33:2", "41:2" };
-    const char *stream_state[] = { "insecure", "secure" };
+    const char *stream_state[] = { "insecure", "reserved", "secure" };
     const char *aggr[] = { "-", "=2", "=4", "=8" };
     u32 l, l2, linknum = 0, selnum = 0, addrnum, off, i, j;
     char buf1[16], buf2[16], offs[16];
Signature · 1 line
2.41.0
#1 lore raw

I found more inconsistencies so v2 will come soon. Sorry for the noise. Thanks,

Quoted 29 lines · Alexey Kardashevskiy

PCIe r6.0, sec 7.9.26.4.2 "Link IDE Stream Status Register defines" the link state as:

0000b Insecure
0010b Secure

The same definition applies to selective streams as well. The existing code wrongly assumes "secure" is 0001b, fix that for both link and selective streams.

Fixes 42fc4263ec0e ("ls-ecaps: Add decode support for IDE Extended Capability")
---
  ls-ecaps.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
ls-ecaps.c +1 -1
index b40ba72..5c2724e 100644
@@ -1512,7 +1512,7 @@ static void
  cap_ide(struct device *d, int where)
  {
      const char *hdr_enc_mode[] = { "no", "17:2", "25:2", "33:2", "41:2" };
-    const char *stream_state[] = { "insecure", "secure" };
+    const char *stream_state[] = { "insecure", "reserved", "secure" };
      const char *aggr[] = { "-", "=2", "=4", "=8" };
      u32 l, l2, linknum = 0, selnum = 0, addrnum, off, i, j;
      char buf1[16], buf2[16], offs[16];
Signature · 1 line
Alexey