perf record: Fix debug message placement for test consumption
Adrian Hunter
reviewerPATCH 1/1 perf record: Fix debug message placement for test consumption
evlist__config() might mess up the debug output consumed by test "Test per-thread recording" in "Miscellaneous Intel PT testing". Move it out from between the debug prints:
"perf record opening and mmapping events" and
"perf record done opening and mmapping events"
Fixes da4062021e0e ("perf tools: Add debug messages and comments for testing")
Reported-by Arnaldo Carvalho de Melo <[email protected]>
Signed-off-by Adrian Hunter <[email protected]>
--- tools/perf/builtin-record.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/builtin-record.c +2 -2
@@ -1355,8 +1355,6 @@ static int record__open(struct record *rec)struct record_opts *opts = &rec->opts;int rc =0 ; -evlist__config (evlist, opts, &callchain_param); -evlist__for_each_entry (evlist, pos) { try_again:if (evsel__open (pos, pos->core.cpus, pos->core.threads) <0 ) {
@@ -2483,6 +2481,8 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)evlist__uniquify_name (rec->evlist); +evlist__config (rec->evlist, opts, &callchain_param); +/* Debug message used by test scripts */ pr_debug3 ("perf record opening and mmapping events\n" );if (record__open (rec) !=0 ) {
Signature · 1 line
2.34.1