Skip to contentSkip to conversation

oeqa/postactions: Do not use -l option with df

PATCH New Khem Raj 1 participant 1 message Apr 12, 2024

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 oeqa/postactions: Do not use -l option with df

-l option is specific to df provided by coreutils, if df applet from busybox is used then it does not work and fails like below

Fixes
df: invalid option -- 'l'
BusyBox v1.36.1 () multi-call binary.

Usage: df [-PkmhT] [-t TYPE] [FILESYSTEM]...
DEBUG: [Command returned '1' after 0.71 seconds]
DEBUG: Command: df -hl
Status: 1 Output: df: invalid option -- 'l'

it seems worth a compromise to show remote mounted filesystems if any during ptests and it works with both df implementations

---
 meta/lib/oeqa/utils/postactions.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oeqa/utils/postactions.py +1 -1
index 8104400ac25..ecdddd2d40e 100644
@@ -25,7 +25,7 @@ def create_artifacts_directory(d, tc):
 def get_target_disk_usage(d, tc):
     output_file = os.path.join(get_json_result_dir(d), "artifacts", "target_disk_usage.txt")
     try:
-        (status, output) = tc.target.run('df -hl')
+        (status, output) = tc.target.run('df -h')
         with open(output_file, 'w') as f:
             f.write(output)
             f.write("\n")
Signature · 1 line
2.44.0