Skip to contentSkip to conversation

staging: vc04_services: Code optimized to use linux BIT macro.

PATCH In review sumadhura kalyan 2 participants 2 messages Apr 14, 2024

Subsystems (2)
Staging Broadcom BCM2711/BCM2835 Arm architecture
lore
Share & tools
lore

sumadhura kalyan

author
#0 lore raw

PATCH 1/1 staging: vc04_services: Code optimized to use linux BIT macro.

Issue found by checkpatch

Signed-off-by sumadhura kalyan <[email protected]>
---
 drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h +1 -1
index a0cdd28101f2..d811bfd3bb84 100644
@@ -27,7 +27,7 @@
 /** Common parameter ID group, used with many types of component. */
 #define MMAL_PARAMETER_GROUP_COMMON		(0 << 16)
 /** Camera-specific parameter ID group. */
-#define MMAL_PARAMETER_GROUP_CAMERA		(1 << 16)
+#define MMAL_PARAMETER_GROUP_CAMERA		BIT(16)
 /** Video-specific parameter ID group. */
 #define MMAL_PARAMETER_GROUP_VIDEO		(2 << 16)
 /** Audio-specific parameter ID group. */
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 12 lines · sumadhura kalyan

Issue found by checkpatch

Signed-off-by sumadhura kalyan <[email protected]>
---
 drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h +0 -0
index a0cdd28101f2..d811bfd3bb84 100644

drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h line 33

Quoted 8 lines
drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h +1 -1
@@ -27,7 +27,7 @@
 /** Common parameter ID group, used with many types of component. */
 #define MMAL_PARAMETER_GROUP_COMMON		(0 << 16)
 /** Camera-specific parameter ID group. */
-#define MMAL_PARAMETER_GROUP_CAMERA		(1 << 16)
+#define MMAL_PARAMETER_GROUP_CAMERA		BIT(16)
 /** Video-specific parameter ID group. */
 #define MMAL_PARAMETER_GROUP_VIDEO		(2 << 16)
 /** Audio-specific parameter ID group. */

When looking at the code now, does this change make sense? Remember, checkpatch is a guide, not a hard rule.

greg k-h