Skip to contentSkip to conversation

staging: vc04_services: Re-align function parameters

PATCH Superseded Sumadhura Kalyan 2 participants 2 messages Apr 14, 2024 – Apr 15, 2024

Subsystems (2)
Staging Broadcom BCM2711/BCM2835 Arm architecture

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Sumadhura Kalyan

author
#0 lore raw

PATCH v3 1/1 staging: vc04_services: Re-align function parameters

From: sumadhura kalyan <[email protected]>

Checkpatch complains that:

CHECK: Lines should not end with a '('
+typedef void (*vchiq_mmal_buffer_cb)(

Re-align the function parameters to make checkpatch happy.

Signed-off-by Sumadhura Kalyan <[email protected]>

---

v1 -> v2: Repharse the subject line.

 .../vc04_services/vchiq-mmal/mmal-vchiq.h     | 29 +++++++------------
 1 file changed, 11 insertions(+), 18 deletions(-)
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h +11 -18
index 09f030919d4e..98909fde978e 100644
@@ -42,8 +42,7 @@ struct vchiq_mmal_port_buffer {
 
 struct vchiq_mmal_port;
 
-typedef void (*vchiq_mmal_buffer_cb)(
-		struct vchiq_mmal_instance  *instance,
+typedef void (*vchiq_mmal_buffer_cb)(struct vchiq_mmal_instance  *instance,
 		struct vchiq_mmal_port *port,
 		int status, struct mmal_buffer *buffer);
 

@@ -101,31 +100,25 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance);
 /* Initialise a mmal component and its ports
  *
  */
-int vchiq_mmal_component_init(
-		struct vchiq_mmal_instance *instance,
-		const char *name,
-		struct vchiq_mmal_component **component_out);
+int vchiq_mmal_component_init(struct vchiq_mmal_instance *instance,
+			      const char *name, struct vchiq_mmal_component **component_out);
 
-int vchiq_mmal_component_finalise(
-		struct vchiq_mmal_instance *instance,
-		struct vchiq_mmal_component *component);
+int vchiq_mmal_component_finalise(struct vchiq_mmal_instance *instance,
+				  struct vchiq_mmal_component *component);
 
-int vchiq_mmal_component_enable(
-		struct vchiq_mmal_instance *instance,
-		struct vchiq_mmal_component *component);
+int vchiq_mmal_component_enable(struct vchiq_mmal_instance *instance,
+				struct vchiq_mmal_component *component);
 
-int vchiq_mmal_component_disable(
-		struct vchiq_mmal_instance *instance,
-		struct vchiq_mmal_component *component);
+int vchiq_mmal_component_disable(struct vchiq_mmal_instance *instance,
+				 struct vchiq_mmal_component *component);
 
 /* enable a mmal port
  *
  * enables a port and if a buffer callback provided enque buffer
  * headers as appropriate for the port.
  */
-int vchiq_mmal_port_enable(
-		struct vchiq_mmal_instance *instance,
-		struct vchiq_mmal_port *port,
+int vchiq_mmal_port_enable(struct vchiq_mmal_instance *instance,
+			   struct vchiq_mmal_port *port,
 		vchiq_mmal_buffer_cb buffer_cb);
 
 /* disable a port
Signature · 1 line
2.25.1
#1 lore raw
Quoted 1 line · Sumadhura Kalyan

From: sumadhura kalyan <[email protected]>

        ^^^^^^^^^^^^^^^^

This will mess things up.

Quoted 6 lines

Checkpatch complains that:

CHECK: Lines should not end with a '('
+typedef void (*vchiq_mmal_buffer_cb)(

Quoted 6 lines

Re-align the function parameters to make checkpatch happy.

Signed-off-by Sumadhura Kalyan <[email protected]>

---

v1 -> v2: Repharse the subject line.

Need more changelog here.

regards,
dan carpenter