mfd: timberdale: remove redundant assignment to variable err
Subsystems (2)
PATCH 1/1 mfd: timberdale: remove redundant assignment to variable err
The variable err is being assigned -ENODEV and then err is being re-assigned the same error value via the error exit label err_mfd. The assignment is redundant and can be removed.
Cleans up clang scan build warning:drivers/mfd/timberdale.c:768:3: warning: Value stored to 'err' is never read [deadcode.DeadStores]
--- drivers/mfd/timberdale.c | 1 - 1 file changed, 1 deletion(-)
drivers/mfd/timberdale.c +0 -1
@@ -765,7 +765,6 @@ static int timb_probe(struct pci_dev *dev,default :dev_err (&dev->dev,"Unknown IP setup: %d.%d.%d\n" , priv->fw.major, priv->fw.minor, ip_setup); - err = -ENODEV ; goto err_mfd; }
Signature · 1 line
2.39.2
Re: (subset) [PATCH][next] mfd: timberdale: remove redundant assignment to variable err
Quoted 9 lines · Colin Ian King
The variable err is being assigned
-ENODEVand then err is being re-assigned the same error value via the error exit labelerr_mfd. The assignment is redundant and can be removed.Cleans up clang scan build warning:
drivers/mfd/timberdale.c:768:3: warning: Value stored to 'err' is never read [deadcode.DeadStores][...]
Applied, thanks!
[1/1] mfd: timberdale: remove redundant assignment to variable err
commit: 3f2706adbc2b8b6aaf313cc66271642d901d90e0
--
Lee Jones [李琼斯]