Skip to contentSkip to conversation

dt-bindings: phy: qcom,usb-hs-phy: Add compatible

PATCH Superseded Herman van Hazendonk 5 participants 10 messages Apr 15, 2024 – Jun 15, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: phy: qcom,usb-hs-phy: Add compatible

From: Herman van Hazendonk <[email protected]>

Adds qcom,usb-hs-phy-msm8660 compatible

Used by HP Touchpad (tenderloin) for example.

---
 Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +2 -0
index f042d6af1594..1faf1da9f583 100644
@@ -15,6 +15,7 @@ if:
       contains:
         enum:
           - qcom,usb-hs-phy-apq8064
+          - qcom,usb-hs-phy-msm8660
           - qcom,usb-hs-phy-msm8960
 then:
   properties:
@@ -42,6 +43,7 @@ properties:
           - qcom,usb-hs-phy-apq8064
           - qcom,usb-hs-phy-msm8226
           - qcom,usb-hs-phy-msm8916
+          - qcom,usb-hs-phy-msm8660
           - qcom,usb-hs-phy-msm8960
           - qcom,usb-hs-phy-msm8974
       - const: qcom,usb-hs-phy
Signature · 7 lines
2.40.1


-- 
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy
#1 lore raw

PATCH v2 1/1 dt-bindings: phy: qcom,usb-hs-phy: Add compatible

Adds qcom,usb-hs-phy-msm8660 compatible

Used by HP Touchpad (tenderloin) for example.

---
 Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +2 -0
index f042d6af1594..ccf23170cd17 100644
@@ -15,6 +15,7 @@ if:
       contains:
         enum:
           - qcom,usb-hs-phy-apq8064
+          - qcom,usb-hs-phy-msm8660
           - qcom,usb-hs-phy-msm8960
 then:
   properties:
@@ -41,6 +42,7 @@ properties:
       - enum:
           - qcom,usb-hs-phy-apq8064
           - qcom,usb-hs-phy-msm8226
+          - qcom,usb-hs-phy-msm8960
           - qcom,usb-hs-phy-msm8916
           - qcom,usb-hs-phy-msm8960
           - qcom,usb-hs-phy-msm8974
#2 lore raw
Quoted 23 lines · Herman van Hazendonk

Adds qcom,usb-hs-phy-msm8660 compatible

Used by HP Touchpad (tenderloin) for example.

---
 Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +1 -0
index f042d6af1594..ccf23170cd17 100644
@@ -15,6 +15,7 @@ if:
       contains:
         enum:
           - qcom,usb-hs-phy-apq8064
+          - qcom,usb-hs-phy-msm8660
           - qcom,usb-hs-phy-msm8960
 then:
   properties:

Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml properties: · line 45

Quoted 4 lines
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +1 -0
@@ -41,6 +42,7 @@ properties:
       - enum:
           - qcom,usb-hs-phy-apq8064
           - qcom,usb-hs-phy-msm8226
+          - qcom,usb-hs-phy-msm8960

This should probably be msm8660 rather than 8960

Note, nowadays the rule would be to use qcom,msm8660-usb-hs-phy compatible, but I wonder if we should enforce this for such an old platform or whether similarity wins.

Quoted 4 lines
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +0 -0
           - qcom,usb-hs-phy-msm8916
           - qcom,usb-hs-phy-msm8960
           - qcom,usb-hs-phy-msm8974
Signature · 2 lines
With best wishes
Dmitry
#3 lore raw
Quoted 21 lines · Herman van Hazendonk
Quoted 21 lines

Adds qcom,usb-hs-phy-msm8660 compatible

Used by HP Touchpad (tenderloin) for example.

---
 Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +1 -0
index f042d6af1594..ccf23170cd17 100644
@@ -15,6 +15,7 @@ if:
       contains:
         enum:
           - qcom,usb-hs-phy-apq8064
+          - qcom,usb-hs-phy-msm8660
           - qcom,usb-hs-phy-msm8960
 then:
Quoted 8 lines

Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml properties: · line 45

Quoted 6 lines
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +1 -0
   properties:
@@ -41,6 +42,7 @@ properties:
       - enum:
           - qcom,usb-hs-phy-apq8064
           - qcom,usb-hs-phy-msm8226
+          - qcom,usb-hs-phy-msm8960

This should probably be msm8660 rather than 8960

Hi Dmitry,

Thanks for the swift feedback. I'll send a v3. I need more coffee before doing this in the morning

Quoted 8 lines

Note, nowadays the rule would be to use qcom,msm8660-usb-hs-phy compatible, but I wonder if we should enforce this for such an old platform or whether similarity wins.

Quoted 4 lines
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +0 -0
           - qcom,usb-hs-phy-msm8916
           - qcom,usb-hs-phy-msm8960
           - qcom,usb-hs-phy-msm8974

I plan to send more patches for the msm8660, so happy to understand what is the preferred approach, because it doesn't seem consistent.

These are my first patches, so learning mainly from what I see in commit history (which might be outdated)
It's indeed ancient platform, we just would like to get HP TouchPad (tenderloin) running with a mainline kernel, hence these patches.

Best regards,
Herman

Quoted 3 lines

--
With best wishes
Dmitry

#4 lore raw

PATCH v3 1/1 dt-bindings: phy: qcom,usb-hs-phy: Add compatible

Adds qcom,usb-hs-phy-msm8660 compatible

Used by HP Touchpad (tenderloin) for example.

---
 Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +2 -0
index f042d6af1594..e03b516c698c 100644
@@ -15,6 +15,7 @@ if:
       contains:
         enum:
           - qcom,usb-hs-phy-apq8064
+          - qcom,usb-hs-phy-msm8660
           - qcom,usb-hs-phy-msm8960
 then:
   properties:
@@ -41,6 +42,7 @@ properties:
       - enum:
           - qcom,usb-hs-phy-apq8064
           - qcom,usb-hs-phy-msm8226
+          - qcom,usb-hs-phy-msm8660
           - qcom,usb-hs-phy-msm8916
           - qcom,usb-hs-phy-msm8960
           - qcom,usb-hs-phy-msm8974
Signature · 3 lines
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy
#8 lore raw
In reply to Herman van Hazendonk
Quoted 32 lines · Herman van Hazendonk
Quoted 21 lines · Herman van Hazendonk
Quoted 21 lines

Adds qcom,usb-hs-phy-msm8660 compatible

Used by HP Touchpad (tenderloin) for example.

---
 Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +1 -0
index f042d6af1594..ccf23170cd17 100644
@@ -15,6 +15,7 @@ if:
       contains:
         enum:
           - qcom,usb-hs-phy-apq8064
+          - qcom,usb-hs-phy-msm8660
           - qcom,usb-hs-phy-msm8960
 then:
Quoted 8 lines

Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml properties: · line 45

Quoted 6 lines
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +1 -0
   properties:
@@ -41,6 +42,7 @@ properties:
       - enum:
           - qcom,usb-hs-phy-apq8064
           - qcom,usb-hs-phy-msm8226
+          - qcom,usb-hs-phy-msm8960

This should probably be msm8660 rather than 8960

Quoted 4 lines

Hi Dmitry,

Thanks for the swift feedback. I'll send a v3. I need more coffee before doing this in the morning

Please wait for the feedback from bindings maintainers (this might take a couple of days).

Quoted 9 lines
Quoted 8 lines

Note, nowadays the rule would be to use qcom,msm8660-usb-hs-phy compatible, but I wonder if we should enforce this for such an old platform or whether similarity wins.

Quoted 4 lines
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +0 -0
           - qcom,usb-hs-phy-msm8916
           - qcom,usb-hs-phy-msm8960
           - qcom,usb-hs-phy-msm8974
Quoted 7 lines

I plan to send more patches for the msm8660, so happy to understand what is the preferred approach, because it doesn't seem consistent.

These are my first patches, so learning mainly from what I see in commit history (which might be outdated)
It's indeed ancient platform, we just would like to get HP TouchPad (tenderloin) running with a mainline kernel, hence these patches.

This sounds really interesting. I recently got apq8060 so I should be able to test your patches if the time permits.

Signature · 2 lines
With best wishes
Dmitry
maintainer
#5 lore raw
In reply to Herman van Hazendonk
Quoted 3 lines · Herman van Hazendonk

Adds qcom,usb-hs-phy-msm8660 compatible

Used by HP Touchpad (tenderloin) for example.

This lgtm, where is the dts for this, would like to check that before I pick this

Quoted 31 lines
---
 Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +2 -0
index f042d6af1594..e03b516c698c 100644
@@ -15,6 +15,7 @@ if:
       contains:
         enum:
           - qcom,usb-hs-phy-apq8064
+          - qcom,usb-hs-phy-msm8660
           - qcom,usb-hs-phy-msm8960
 then:
   properties:
@@ -41,6 +42,7 @@ properties:
       - enum:
           - qcom,usb-hs-phy-apq8064
           - qcom,usb-hs-phy-msm8226
+          - qcom,usb-hs-phy-msm8660
           - qcom,usb-hs-phy-msm8916
           - qcom,usb-hs-phy-msm8960
           - qcom,usb-hs-phy-msm8974
Signature · 4 lines
-- 
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy
Signature · 1 line
~Vinod
maintainer Applied
#7 lore raw
In reply to Herman van Hazendonk
Quoted 5 lines · Herman van Hazendonk

Adds qcom,usb-hs-phy-msm8660 compatible

Used by HP Touchpad (tenderloin) for example.

Applied, thanks!

[1/1] dt-bindings: phy: qcom,usb-hs-phy: Add compatible

      commit: cd13368db059de22d27e86665a378aa2a388db85

Best regards,

Signature · 1 line
Vinod Koul <[email protected]>