phy: rockchip: fix CONFIG_TYPEC dependency
Subsystems (2)
PATCH 1/1 phy: rockchip: fix CONFIG_TYPEC dependency
From: Arnd Bergmann <[email protected]>
The newly added driver causes a warning about missing dependencies by selecting CONFIG_TYPEC unconditionally:
WARNING: unmet direct dependencies detected for TYPEC
Depends on [n]: USB_SUPPORT [=n]
Selected by [y]:
- PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y]
WARNING: unmet direct dependencies detected for USB_COMMON
Depends on [n]: USB_SUPPORT [=n]
Selected by [y]:
- EXTCON_RTK_TYPE_C [=y] && EXTCON [=y] && (ARCH_REALTEK [=y] || COMPILE_TEST [=y]) && TYPEC [=y]
Since that is a user-visible option, it should not really be selected in the first place. Replace the 'select' with a 'depends on' as we have for similar drivers.
--- drivers/phy/rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/rockchip/Kconfig +1 -1
@@ -120,8 +120,8 @@ config PHY_ROCKCHIP_USB config PHY_ROCKCHIP_USBDP tristate "Rockchip USBDP COMBO PHY Driver" depends on ARCH_ROCKCHIP && OF + depends on TYPEC select GENERIC_PHY - select TYPEC help Enable this to support the Rockchip USB3.0/DP combo PHY with Samsung IP block. This is required for USB3 support on RK3588.
Signature · 1 line
2.39.2
Am Montag, 15. April 2024, 19:42:25 CEST schrieb Arnd Bergmann:
Quoted 15 lines
From: Arnd Bergmann <[email protected]>
The newly added driver causes a warning about missing dependencies by selecting
CONFIG_TYPECunconditionally:WARNING: unmet direct dependencies detected for TYPEC
Depends on [n]:USB_SUPPORT[=n]
Selected by [y]:
-PHY_ROCKCHIP_USBDP[=y] &&ARCH_ROCKCHIP[=y] && OF [=y]WARNING: unmet direct dependencies detected for
USB_COMMON
Depends on [n]:USB_SUPPORT[=n]
Selected by [y]:
-EXTCON_RTK_TYPE_C[=y] && EXTCON [=y] && (ARCH_REALTEK[=y] ||COMPILE_TEST[=y]) && TYPEC [=y]
Quoted 6 lines
Since that is a user-visible option, it should not really be selected in the first place. Replace the 'select' with a 'depends on' as we have for similar drivers.
Fixes 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver")Signed-off-by Arnd Bergmann <[email protected]>
Quoted 19 lines
--- drivers/phy/rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/phy/rockchip/Kconfig +1
-1@@ -120,8 +120,8 @@ config PHY_ROCKCHIP_USB config PHY_ROCKCHIP_USBDP tristate "Rockchip USBDP COMBO PHY Driver" depends on ARCH_ROCKCHIP && OF + depends on TYPEC select GENERIC_PHY - select TYPEC help Enable this to support the Rockchip USB3.0/DP combo PHY with Samsung IP block. This is required for USB3 support on RK3588.
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Quoted 9 lines · Arnd Bergmann
The newly added driver causes a warning about missing dependencies by selecting
CONFIG_TYPECunconditionally:WARNING: unmet direct dependencies detected for TYPEC
Depends on [n]:USB_SUPPORT[=n]
Selected by [y]:
-PHY_ROCKCHIP_USBDP[=y] &&ARCH_ROCKCHIP[=y] && OF [=y][...]
Applied, thanks!
[1/1] phy: rockchip: fix CONFIG_TYPEC dependency
commit: 9c79b779643e56d4253bd3ba6998c58c819943af
Best regards,
Signature · 1 line
~Vinod