fpga: dfl: remove unused member pdata from struct dfl_{afu,fme}
Subsystems (2)
PATCH v3 1/1 fpga: dfl: remove unused member pdata from struct dfl_{afu,fme}
The member pdata in struct dfl_{afu,fme} is set in function {afu,fme}_dev_init(), respectively, but never used.
Fixes 857a26222ff7 ("fpga: dfl: afu: add afu sub feature support")
Fixes 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support")
Signed-off-by Peter Colberg <[email protected]>
Reviewed-by Matthew Gerlach <[email protected]>
---
v3:
- Do not wrap commit references and move to Fixes: tags. v2:
- Remove unused member pdata from struct dfl_fme, too.
--- drivers/fpga/dfl-afu-main.c | 2 -- drivers/fpga/dfl-afu.h | 3 --- drivers/fpga/dfl-fme-main.c | 2 -- drivers/fpga/dfl-fme.h | 2 -- 4 files changed, 9 deletions(-)
drivers/fpga/dfl-afu-main.c +0 -2
@@ -858,8 +858,6 @@ static int afu_dev_init(struct platform_device *pdev)if (!afu)return -ENOMEM ; - afu->pdata = pdata; -mutex_lock (&pdata->lock);dfl_fpga_pdata_set_private (pdata, afu);afu_mmio_region_init (pdata);
drivers/fpga/dfl-afu.h +0 -3
@@ -67,7 +67,6 @@ struct dfl_afu_dma_region {* @regions: the mmio region linked list of this afu feature device. * @dma_regions: root of dma regions rb tree. * @num_umsgs: num of umsgs. -* @pdata: afu platform device's pdata. */ struct dfl_afu {u64 region_cur_offset;
@@ -75,8 +74,6 @@ struct dfl_afu {u8 num_umsgs;struct list_head regions;struct rb_root dma_regions; - -struct dfl_feature_platform_data *pdata; };/* hold pdata->lock when call __afu_port_enable/disable */
drivers/fpga/dfl-fme-main.c +0 -2
@@ -679,8 +679,6 @@ static int fme_dev_init(struct platform_device *pdev)if (!fme)return -ENOMEM ; - fme->pdata = pdata; -mutex_lock (&pdata->lock);dfl_fpga_pdata_set_private (pdata, fme);mutex_unlock (&pdata->lock);
drivers/fpga/dfl-fme.h +0 -2
@@ -24,13 +24,11 @@* @mgr: FME's FPGA manager platform device. * @region_list: linked list of FME's FPGA regions. * @bridge_list: linked list of FME's FPGA bridges. -* @pdata: fme platform device's pdata. */ struct dfl_fme {struct platform_device *mgr;struct list_head region_list;struct list_head bridge_list; -struct dfl_feature_platform_data *pdata; };extern const struct dfl_feature_ops fme_pr_mgmt_ops;
Signature · 1 line
2.44.0
Quoted 7 lines · Peter Colberg
The member pdata in struct dfl_{afu,fme} is set in function {afu,fme}_dev_init(), respectively, but never used.
Fixes 857a26222ff7 ("fpga: dfl: afu: add afu sub feature support")Fixes 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support")Signed-off-by Peter Colberg <[email protected]>Reviewed-by Matthew Gerlach <[email protected]>
Acked-by Xu Yilun <[email protected]>
Applied to for-next.