Skip to contentSkip to conversation

generic/645: Add hint for expected failure with old kernel

PATCH In review Taylor Jackson 3 participants 3 messages Apr 17, 2024 – Apr 18, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/645: Add hint for expected failure with old kernel

The following hint is added to reflect that any old kernel without kernel commit dacfd001eaf2 (“fs/mnt_idmapping.c: Return -EINVAL when no map is written”) is expected to fail this generic 645 test since without that commit, mount_setattr won’t return EINVAL when attempting to create an idmapped mount using a user namespace with no mappings.

---
 tests/generic/645 | 2 ++
 1 file changed, 2 insertions(+)
tests/generic/645 +2 -0
index 556d2450..bcc3e3b5 100755
@@ -17,6 +17,8 @@ _begin_fstest auto quick idmapped mount
 _supported_fs generic
 _require_idmapped_mounts
 _require_test
+_fixed_by_kernel_commit dacfd001eaf2 \
+	"fs/mnt_idmapping.c: Return -EINVAL when no map is written"
 
 echo "Silence is golden"
 

---
base-commit: e72e052d56c3f05e533f4b67056f86931f688368
change-id: 20240417-generic-test-645-18750d02523e

Best regards,

Signature · 1 line
Taylor Jackson <[email protected]>
Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · On Wed, Apr 17, 2024 at 07:34:24PM +0000, Taylor Jackson via B4 Relay wrote:

From: Taylor Jackson <[email protected]>

The following hint is added to reflect that any old kernel without kernel commit dacfd001eaf2 (“fs/mnt_idmapping.c: Return -EINVAL when no map is written”) is expected to fail this generic 645 test since without that commit, mount_setattr won’t return EINVAL when attempting to create an idmapped mount using a user namespace with no mappings.

---
 tests/generic/645 | 2 ++
 1 file changed, 2 insertions(+)
tests/generic/645 +0 -0
index 556d2450..bcc3e3b5 100755

tests/generic/645 _begin_fstest auto quick idmapped mount · line 21

Quoted 5 lines
tests/generic/645 +2 -0
@@ -17,6 +17,8 @@ _begin_fstest auto quick idmapped mount
 _supported_fs generic
 _require_idmapped_mounts
 _require_test
+_fixed_by_kernel_commit dacfd001eaf2 \
+	"fs/mnt_idmapping.c: Return -EINVAL when no map is written"

Thanks for helping to confirm that. Just, if it's not a regression bug fix, maybe better to replace the "_fixed_by_kernel_commit" with the "_wants_kernel_commit". If no objection, I can change that when I merge this patch :)

Thanks,
Zorro

Quoted 14 lines
tests/generic/645 +0 -1
 echo "Silence is golden"
 
 
---

base-commit: e72e052d56c3f05e533f4b67056f86931f688368
change-id: 20240417-generic-test-645-18750d02523e

Best regards,

Signature · 1 line
Taylor Jackson <[email protected]>
Reviewed-by on v1 1/1
#2 lore raw
In reply to Taylor Jackson
Quoted 9 lines · On Wed, Apr 17, 2024 at 07:34:24PM +0000, Taylor Jackson via B4 Relay wrote:

From: Taylor Jackson <[email protected]>

The following hint is added to reflect that any old kernel without kernel commit dacfd001eaf2 (“fs/mnt_idmapping.c: Return -EINVAL when no map is written”) is expected to fail this generic 645 test since without that commit, mount_setattr won’t return EINVAL when attempting to create an idmapped mount using a user namespace with no mappings.

Quoted 3 lines

---

Thank you!