Add case about arch_prctl syscall.
PATCH v2 1/1 Add case about arch_prctl syscall.
Add testcase about arch_prctl syscall.
--- configure.ac | 1 + .../kernel/syscalls/arch_prctl/.gitignore | 1 + testcases/kernel/syscalls/arch_prctl/Makefile | 8 +++ .../kernel/syscalls/arch_prctl/arch_prctl01.c | 56 +++++++++++++++++++ 4 files changed, 66 insertions(+) create mode 100644 testcases/kernel/syscalls/arch_prctl/.gitignore create mode 100644 testcases/kernel/syscalls/arch_prctl/Makefile create mode 100644 testcases/kernel/syscalls/arch_prctl/arch_prctl01.c
configure.ac +1 -0
@@ -41,6 +41,7 @@ AC_CHECK_DECLS([SEM_STAT_ANY],,,[#include <sys/sem.h>]) AC_CHECK_HEADERS_ONCE([ \ asm/ldt.h \ + asm/prctl.h \ cpuid.h \ emmintrin.h \ ifaddrs.h \
testcases/kernel/syscalls/arch_prctl/.gitignore new file +1 -0
@@ -0,0 +1 @@ +/arch_prctl01
testcases/kernel/syscalls/arch_prctl/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) UnionTech Software Technology Co.,Ltd. 2024 + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +56 -0
56 lines not on this page · raw message
Signature · 5 lines
2.39.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
First of all do 'make check' in the directory with the test source and fix all errors and warnings.
Quoted 6 lines
Signed-off-by Lu Fei <[email protected]>--- configure.ac | 1 + .../kernel/syscalls/arch_prctl/.gitignore | 1 + testcases/kernel/syscalls/arch_prctl/Makefile | 8 +++ .../kernel/syscalls/arch_prctl/arch_prctl01.c | 56 +++++++++++++++++++
This is missing a runtest entry, i.e. line in the runtest/syscalls file that tells the test execution framework to run the test.
Quoted 44 lines
4 files changed, 66 insertions(+) create mode 100644 testcases/kernel/syscalls/arch_prctl/.gitignore create mode 100644 testcases/kernel/syscalls/arch_prctl/Makefile create mode 100644 testcases/kernel/syscalls/arch_prctl/arch_prctl01.cconfigure.ac +1
-0@@ -41,6 +41,7 @@ AC_CHECK_DECLS([SEM_STAT_ANY],,,[#include <sys/sem.h>]) AC_CHECK_HEADERS_ONCE([ \ asm/ldt.h \ + asm/prctl.h \ cpuid.h \ emmintrin.h \ ifaddrs.h \testcases/kernel/syscalls/arch_prctl/.gitignore new file +1
-0@@ -0,0 +1 @@ +/arch_prctl01testcases/kernel/syscalls/arch_prctl/Makefile new file +8
-0@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) UnionTech Software Technology Co.,Ltd. 2024 + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mktestcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +0
-0
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 7
Quoted 7 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +7
-0@@ -0,0 +1,56 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Copyright (c) UnionTech Software Technology Co.,Ltd., 2024 +* Author: Lu Fei <[email protected]> +*/ + +/*
This has to be /*\ so that the docparse comment gets picked up by the documentation parser and shows up in docparse/metadata.html
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 17
Quoted 10 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +10
-0+* [Description] +* +* Simple test on arch_prctl to set and get cpuid instruction of test thread. +*/ + +# include "tst_test.h" +# include "lapi/syscalls.h" +# include <stdlib.h> +# ifdef HAVE_ASM_PRCTL_H +# include <asm/prctl.h>
No spaces after # here please.
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 31
Quoted 13 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +13
-0+static int arch_prctl_get (int code,unsigned long *addr) { +return tst_syscall (__NR_arch_prctl, code, *addr); +} + +static int arch_prctl_set (int code,unsigned long addr) { +return tst_syscall (__NR_arch_prctl, code, addr); +} + +static int tc[] = {0 ,1 }; + +static void run (unsigned int index){ + +unsigned long *addr =malloc (sizeof (long ));
This does not need to be allocated, we can just do unsigned long addr and pass &addr to the calls.
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 38
Quoted 6 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +6
-0+TEST (arch_prctl_set (ARCH_SET_CPUID , tc[index])); + +if (TST_RET ==0 ) +tst_res (TPASS ,"set %s cpuid" ,tc[index] ?"enable" :"disable" ); +else +tst_res (TFAIL ,"failed to set cpuid" );
This should use TST_EXP_PASS(arch_prctl_set(...))
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 40
Quoted 1 line
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +1
-0+TEST (arch_prctl_get (ARCH_GET_CPUID , addr));
This as well.
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 42
Quoted 1 line
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +1
-0+if (TST_RET == tc[index])
This is wrong, the value should be stored the addr parameter, TST_RET should be 0 on success.
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 51
Quoted 9 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +9
-0+tst_res (TPASS ,"get cpuid succeed." ); + else + tst_res(TFAIL, "get cpuid failed."); +} + +static struct tst_test test = { + .test = run, + .tcnt =2 , + .min_kver ="4.11" ,
This should have .supported_archs = {"x86", "x86-64", NULL},
Quoted 11 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +5
-0+}; + +#else /* HAVE_ASM_PRCTL_H */ +TST_TEST_TCONF ("missing <asm/prctl.h>" ); +#endif Signature · 5 lines
2.39.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v2 1/1 Add case about arch_prctl syscall.
In reply to lufeiAdd testcase about arch_prctl syscall.
--- configure.ac | 1 + runtest/syscalls | 2 + .../kernel/syscalls/arch_prctl/.gitignore | 1 + testcases/kernel/syscalls/arch_prctl/Makefile | 8 +++ .../kernel/syscalls/arch_prctl/arch_prctl01.c | 52 +++++++++++++++++++ 5 files changed, 64 insertions(+) create mode 100644 testcases/kernel/syscalls/arch_prctl/.gitignore create mode 100644 testcases/kernel/syscalls/arch_prctl/Makefile create mode 100644 testcases/kernel/syscalls/arch_prctl/arch_prctl01.c
configure.ac +1 -0
@@ -41,6 +41,7 @@ AC_CHECK_DECLS([SEM_STAT_ANY],,,[#include <sys/sem.h>]) AC_CHECK_HEADERS_ONCE([ \ asm/ldt.h \ + asm/prctl.h \ cpuid.h \ emmintrin.h \ ifaddrs.h \
runtest/syscalls +2 -0
@@ -31,6 +31,8 @@ alarm05 alarm05 alarm06 alarm06 alarm07 alarm07 +arch_prctl01 arch_prctl01 + bind01 bind01 bind02 bind02 bind03 bind03
testcases/kernel/syscalls/arch_prctl/.gitignore new file +1 -0
@@ -0,0 +1 @@ +/arch_prctl01
testcases/kernel/syscalls/arch_prctl/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) UnionTech Software Technology Co.,Ltd. 2024 + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +52 -0
52 lines not on this page · raw message
Signature · 5 lines
2.39.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
[LTP] (no subject)
In reply to lufeiHi Cyril.
Thanks for you quickly response.
Some of your point has been fixed. Some are not:
1. I'm using gcc (GCC) 11.4.1 20230605, addr without initialization would output some warnings.
2. I read the manpage of arch_prctl, the ARCH_GET_CPUID seems return the flag, instead of storing addr:
```
ARCH_GET_CPUID (since Linux 4.12)
Return the setting of the flag manipulated by ARCH_SET_CPUID as the result of the system call (1 for enabled, 0 for
disabled). addr is ignored.
```I'm not sure if this is a problem of my environment.
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v2 1/1 Add case about arch_prctl syscall.
Add testcase about arch_prctl syscall.
--- configure.ac | 1 + runtest/syscalls | 2 + .../kernel/syscalls/arch_prctl/.gitignore | 1 + testcases/kernel/syscalls/arch_prctl/Makefile | 8 +++ .../kernel/syscalls/arch_prctl/arch_prctl01.c | 52 +++++++++++++++++++ 5 files changed, 64 insertions(+) create mode 100644 testcases/kernel/syscalls/arch_prctl/.gitignore create mode 100644 testcases/kernel/syscalls/arch_prctl/Makefile create mode 100644 testcases/kernel/syscalls/arch_prctl/arch_prctl01.c
configure.ac +1 -0
@@ -41,6 +41,7 @@ AC_CHECK_DECLS([SEM_STAT_ANY],,,[#include <sys/sem.h>]) AC_CHECK_HEADERS_ONCE([ \ asm/ldt.h \ + asm/prctl.h \ cpuid.h \ emmintrin.h \ ifaddrs.h \
runtest/syscalls +2 -0
@@ -31,6 +31,8 @@ alarm05 alarm05 alarm06 alarm06 alarm07 alarm07 +arch_prctl01 arch_prctl01 + bind01 bind01 bind02 bind02 bind03 bind03
testcases/kernel/syscalls/arch_prctl/.gitignore new file +1 -0
@@ -0,0 +1 @@ +/arch_prctl01
testcases/kernel/syscalls/arch_prctl/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) UnionTech Software Technology Co.,Ltd. 2024 + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +52 -0
52 lines not on this page · raw message
Signature · 5 lines
2.39.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] (no subject)
In reply to lufeiHi!
Quoted 8 lines
Some of your point has been fixed. Some are not:
1. I'm using gcc (GCC) 11.4.1 20230605,addrwithout initialization would output some warnings.
2. I read the manpage ofarch_prctl, theARCH_GET_CPUIDseems return the flag, instead of storingaddr:``` ARCH_GET_CPUID (since Linux 4.12) Return the setting of the flag manipulated by ARCH_SET_CPUID as the result of the system call (1 for enabled, 0 for disabled). addr is ignored. ```
Ah right, if addr is ignored just pass NULL there instead.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] (no subject)
I tried using NULL, but met TBROK: Test killed by SIGSEGV!.
And the last time you mentioned in response to using supported_archs, this seems not work properly by now, the ltp document(section of writing_tests) says "not applicable".
路斐 Fei.Lu
平台测试部 高级测试开发工程师
统信软件
企业官网:www.uniontech.com
联系方式:18501012352
办公地址:西安市雁塔区云水一路与天谷八路口软件新城二期C2-20层
------------------ Original ------------------
From: "Cyril Hrubis";
Date: 2024年4月26日(星期五) 上午8:37
To: "lufei";
Cc: "ltp";
Subject: Re:
Hi!
> Some of your point has been fixed. Some are not:
> 1. I'm using gcc (GCC) 11.4.1 20230605, addr without initialization would output some warnings.
> 2. I read the manpage of arch_prctl, the ARCH_GET_CPUID seems return the flag, instead of storing addr:
> ```
> ARCH_GET_CPUID (since Linux 4.12)
> Return the setting of the flag manipulated by ARCH_SET_CPUID as the result of the system call (1 for enabled, 0 for > disabled). addr is ignored.
> ```
Ah right, if addr is ignored just pass NULL there instead.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] (no subject)
Hi!
Quoted 1 line
I tried using NULL, but met
TBROK: Test killed by SIGSEGV!.
That means that the manual page is wrong and the address is not ignored.
Quoted 3 lines
And the last time you mentioned in response to using
supported_archs, this seems not work properly by now, the ltpdocument(section of writing_tests)says "not applicable".
The supported_archs is supposed to work. How did you set it (the value) and what happened?
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] (no subject)
Hi, Cyril.
Here is my case:
``` [root@rocky arch_prctl]# gcc --version gcc (GCC) 11.4.1 20230605 (Red Hat 11.4.1-2) Copyright (C) 2021 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. [root@rocky arch_prctl]# uname -a Linux rocky 5.14.0-362.18.1.el9_3.0.1.x86_64 #1 SMP PREEMPT_DYNAMIC Sun Feb 11 13:49:23 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux [root@rocky arch_prctl]# cat arch_prctl01.c // SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright (c) UnionTech Software Technology Co.,Ltd., 2024 * Author: Lu Fei <[email protected]> */ /*\ * [Description] * * Simple test on arch_prctl to set and get cpuid instruction of test thread. */ #include "tst_test.h" #include "lapi/syscalls.h" #include <stdlib.h> #ifdef HAVE_ASM_PRCTL_H #include <asm/prctl.h> static int arch_prctl_get(int code, unsigned long *addr) { return tst_syscall(__NR_arch_prctl, code, *addr); } static int arch_prctl_set(int code, unsigned long addr) { return tst_syscall(__NR_arch_prctl, code, addr); } static void run(unsigned int index) { unsigned long *addr = malloc(sizeof(long)); // index == 0 for disable cpuid, 1 for enable cpuid. TST_EXP_PASS(arch_prctl_set(ARCH_SET_CPUID, index)); TEST(arch_prctl_get(ARCH_GET_CPUID, addr)); if (TST_RET == index) tst_res(TPASS, "get cpuid succeed."); else tst_res(TFAIL, "get cpuid failed."); } static struct tst_test test = { .test = run, .tcnt = 2, .min_kver = "4.12", .supported_archs = {"x86_64", "x86", NULL}, }; #else /* HAVE_ASM_PRCTL_H */ TST_TEST_TCONF("missing <asm/prctl.h>"); #endif [root@rocky arch_prctl]# make clean rm -f -f -r arch_prctl01 *.o *.pyc .cache.mk *.dwo .*.dwo [root@rocky arch_prctl]# make check CHECK testcases/kernel/syscalls/arch_prctl/arch_prctl01.c arch_prctl01.c:48:10: warning: bogus scalar initializer [root@rocky arch_prctl]# make make -C "/root/Develop/ltp/lib" -f "/root/Develop/ltp/lib/Makefile" all make[1]: Entering directory '/root/Develop/ltp/lib' GEN ltp-version.h make[2]: Nothing to be done for 'all'. make[2]: Nothing to be done for 'all'. make[1]: Leaving directory '/root/Develop/ltp/lib' arch_prctl01.c:48:9: warning: braces around scalar initializer 48 | .supported_archs = {"x86_64", "x86", NULL}, | ^ arch_prctl01.c:48:9: note: (near initialization for ‘test.supported_archs’) arch_prctl01.c:48:29: warning: initialization of ‘const char * const*’ from incompatible pointer type ‘char *’ [-Wincompatible-pointer-types] 48 | .supported_archs = {"x86_64", "x86", NULL}, | ^~~~~~~~ arch_prctl01.c:48:29: note: (near initialization for ‘test.supported_archs’) arch_prctl01.c:48:39: warning: excess elements in scalar initializer 48 | .supported_archs = {"x86_64", "x86", NULL}, | ^~~~~ arch_prctl01.c:48:39: note: (near initialization for ‘test.supported_archs’) arch_prctl01.c:48:46: warning: excess elements in scalar initializer 48 | .supported_archs = {"x86_64", "x86", NULL}, | ^~~~ arch_prctl01.c:48:46: note: (near initialization for ‘test.supported_archs’) CC testcases/kernel/syscalls/arch_prctl/arch_prctl01 ```
路斐 Fei.Lu
Uniontech Technology
site: www.uniontech.com
tel: 18501012352
addr: Xi'an China
------------------ Original ------------------
From: "Cyril Hrubis"<[email protected]>;
Date: Fri, Apr 26, 2024 06:30 PM
To: "路斐"<[email protected]>;
Cc: "ltp"<[email protected]>;
Subject: Re: Re:
Hi!
> I tried using NULL, but met TBROK: Test killed by SIGSEGV!.&nbsp;
That means that the manual page is wrong and the address is not ignored.
> And the last time you mentioned in response to using > supported_archs, this seems not work properly by now, the ltp > document(section of writing_tests) says "not applicable".
The supported_archs is supposed to work. How did you set it (the value) and what happened?
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] (no subject)
Quoted 37 lines · 路斐
Hi, Cyril.
Here is my case:```
[root@rocky arch_prctl]# gcc --version
gcc (GCC) 11.4.1 20230605 (Red Hat 11.4.1-2)
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.[root@rocky arch_prctl]# uname -a
Linux rocky 5.14.0-362.18.1.el9_3.0.1.x86_64 #1 SMPPREEMPT_DYNAMICSun Feb 11 13:49:23 UTC 2024x86_64x86_64x86_64GNU/Linux[root@rocky arch_prctl]# cat arch_prctl01.c
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (c) UnionTech Software Technology Co.,Ltd., 2024 * Author: Lu Fei <[email protected]> *//*\
* [Description]
*
* Simple test onarch_prctlto set and get cpuid instruction of test thread. */#include "
tst_test.h"
#include "lapi/syscalls.h"
#include <stdlib.h>
#ifdefHAVE_ASM_PRCTL_H
#include <asm/prctl.h>
Quoted 3 lines
static int
arch_prctl_get(int code, unsigned long *addr){ return tst_syscall(__NR_arch_prctl, code, *addr);
^^
you are de-refencing here, while kernel expects a pointer
Quoted 116 lines
}
static int
arch_prctl_set(int code, unsigned long addr){ return tst_syscall(__NR_arch_prctl, code, addr); }static void run(unsigned int index)
{ unsigned long *addr = malloc(sizeof(long)); // index == 0 for disable cpuid, 1 for enable cpuid. TST_EXP_PASS(arch_prctl_set(ARCH_SET_CPUID, index)); TEST(arch_prctl_get(ARCH_GET_CPUID, addr)); if (TST_RET == index) tst_res(TPASS, "get cpuid succeed."); else tst_res(TFAIL, "get cpuid failed."); }static struct tst_test test = { .test = run, .tcnt = 2, .min_kver = "4.12", .supported_archs = {"x86_64", "x86", NULL}, };#else /*
HAVE_ASM_PRCTL_H*/TST_TEST_TCONF("missing <asm/prctl.h>");
#endif
[root@rocky arch_prctl]# make clean
rm -f -f -r arch_prctl01 *.o *.pyc .cache.mk *.dwo .*.dwo
[root@rocky arch_prctl]# make check
CHECKtestcases/kernel/syscalls/arch_prctl/arch_prctl01.c
arch_prctl01.c:48:10: warning: bogus scalar initializer
[root@rocky arch_prctl]# make
make -C "/root/Develop/ltp/lib" -f "/root/Develop/ltp/lib/Makefile" all
make[1]: Entering directory '/root/Develop/ltp/lib'
GENltp-version.h
make[2]: Nothing to be done for 'all'.
make[2]: Nothing to be done for 'all'.
make[1]: Leaving directory '/root/Develop/ltp/lib'
arch_prctl01.c:48:9: warning: braces around scalar initializer
48 | .supported_archs = {"x86_64", "x86", NULL},
| ^
arch_prctl01.c:48:9: note: (near initialization for ‘test.supported_archs’)
arch_prctl01.c:48:29: warning: initialization of ‘const char * const*’ from incompatible pointer type ‘char *’ [-Wincompatible-pointer-types]
48 | .supported_archs = {"x86_64", "x86", NULL},
| ^~~~~~~~
arch_prctl01.c:48:29: note: (near initialization for ‘test.supported_archs’)
arch_prctl01.c:48:39: warning: excess elements in scalar initializer
48 | .supported_archs = {"x86_64", "x86", NULL},
| ^~~~~ arch_prctl01.c:48:39: note: (near initialization for ‘test.supported_archs’)
arch_prctl01.c:48:46: warning: excess elements in scalar initializer
48 | .supported_archs = {"x86_64", "x86", NULL},
| ^~~~ arch_prctl01.c:48:46: note: (near initialization for ‘test.supported_archs’)
CC testcases/kernel/syscalls/arch_prctl/arch_prctl01
```路斐 Fei.Lu
Uniontech Technology
site: www.uniontech.com
tel: 18501012352
addr: Xi'an China
------------------ Original ------------------
From: "Cyril Hrubis"<[email protected]>;
Date: Fri, Apr 26, 2024 06:30 PM
To: "路斐"<[email protected]>;
Cc: "ltp"<[email protected]>;
Subject: Re: Re:
Hi!
> I tried using NULL, but metTBROK: Test killed by SIGSEGV!.&nbsp;That means that the manual page is wrong and the address is not ignored.
> And the last time you mentioned in response to using >
supported_archs, this seems not work properly by now, the ltp >document(section of writing_tests)says "not applicable".The
supported_archsis supposed to work. How did you set it (the value) and what happened?--
Cyril Hrubis
[email protected]--
Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v2 1/1 Add case about arch_prctl syscall.
In reply to lufeiAdd testcase about arch_prctl syscall.
--- configure.ac | 1 + runtest/syscalls | 2 + .../kernel/syscalls/arch_prctl/.gitignore | 1 + testcases/kernel/syscalls/arch_prctl/Makefile | 8 +++ .../kernel/syscalls/arch_prctl/arch_prctl01.c | 52 +++++++++++++++++++ 5 files changed, 64 insertions(+) create mode 100644 testcases/kernel/syscalls/arch_prctl/.gitignore create mode 100644 testcases/kernel/syscalls/arch_prctl/Makefile create mode 100644 testcases/kernel/syscalls/arch_prctl/arch_prctl01.c
configure.ac +1 -0
@@ -41,6 +41,7 @@ AC_CHECK_DECLS([SEM_STAT_ANY],,,[#include <sys/sem.h>]) AC_CHECK_HEADERS_ONCE([ \ asm/ldt.h \ + asm/prctl.h \ cpuid.h \ emmintrin.h \ ifaddrs.h \
runtest/syscalls +2 -0
@@ -31,6 +31,8 @@ alarm05 alarm05 alarm06 alarm06 alarm07 alarm07 +arch_prctl01 arch_prctl01 + bind01 bind01 bind02 bind02 bind03 bind03
testcases/kernel/syscalls/arch_prctl/.gitignore new file +1 -0
@@ -0,0 +1 @@ +/arch_prctl01
testcases/kernel/syscalls/arch_prctl/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) UnionTech Software Technology Co.,Ltd. 2024 + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +52 -0
52 lines not on this page · raw message
Signature · 5 lines
2.39.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
[LTP] (no subject)
In reply to lufeiThanks a lot.
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH 1/1 Add case about arch_prctl syscall.
Add testcase about arch_prctl syscall.
--- configure.ac | 1 + runtest/syscalls | 2 + .../kernel/syscalls/arch_prctl/.gitignore | 1 + testcases/kernel/syscalls/arch_prctl/Makefile | 8 +++ .../kernel/syscalls/arch_prctl/arch_prctl01.c | 51 +++++++++++++++++++ 5 files changed, 63 insertions(+) create mode 100644 testcases/kernel/syscalls/arch_prctl/.gitignore create mode 100644 testcases/kernel/syscalls/arch_prctl/Makefile create mode 100644 testcases/kernel/syscalls/arch_prctl/arch_prctl01.c
configure.ac +1 -0
@@ -41,6 +41,7 @@ AC_CHECK_DECLS([SEM_STAT_ANY],,,[#include <sys/sem.h>]) AC_CHECK_HEADERS_ONCE([ \ asm/ldt.h \ + asm/prctl.h \ cpuid.h \ emmintrin.h \ ifaddrs.h \
runtest/syscalls +2 -0
@@ -31,6 +31,8 @@ alarm05 alarm05 alarm06 alarm06 alarm07 alarm07 +arch_prctl01 arch_prctl01 + bind01 bind01 bind02 bind02 bind03 bind03
testcases/kernel/syscalls/arch_prctl/.gitignore new file +1 -0
@@ -0,0 +1 @@ +/arch_prctl01
testcases/kernel/syscalls/arch_prctl/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) UnionTech Software Technology Co.,Ltd. 2024 + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +51 -0
51 lines not on this page · raw message
Signature · 5 lines
2.39.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
And it looks that limiting the test to x86 or x86_64 CPUs is not enough for it to run, we will have to check that the CPU has X86_FEATURE_CPUID_FAULT flag set. Looks like we can actually get that from the flags field from /proc/cpuinfo, if cpuid_fault is there the prctl is supposed to work, if not these calls should return ENODEV.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 Add case about arch_prctl syscall.
Add testcase about arch_prctl syscall.
--- configure.ac | 1 + runtest/syscalls | 2 + .../kernel/syscalls/arch_prctl/.gitignore | 1 + testcases/kernel/syscalls/arch_prctl/Makefile | 8 +++ .../kernel/syscalls/arch_prctl/arch_prctl01.c | 71 +++++++++++++++++++ 5 files changed, 83 insertions(+) create mode 100644 testcases/kernel/syscalls/arch_prctl/.gitignore create mode 100644 testcases/kernel/syscalls/arch_prctl/Makefile create mode 100644 testcases/kernel/syscalls/arch_prctl/arch_prctl01.c
configure.ac +1 -0
@@ -41,6 +41,7 @@ AC_CHECK_DECLS([SEM_STAT_ANY],,,[#include <sys/sem.h>]) AC_CHECK_HEADERS_ONCE([ \ asm/ldt.h \ + asm/prctl.h \ cpuid.h \ emmintrin.h \ ifaddrs.h \
runtest/syscalls +2 -0
@@ -31,6 +31,8 @@ alarm05 alarm05 alarm06 alarm06 alarm07 alarm07 +arch_prctl01 arch_prctl01 + bind01 bind01 bind02 bind02 bind03 bind03
testcases/kernel/syscalls/arch_prctl/.gitignore new file +1 -0
@@ -0,0 +1 @@ +/arch_prctl01
testcases/kernel/syscalls/arch_prctl/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) UnionTech Software Technology Co.,Ltd. 2024 + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +71 -0
71 lines not on this page · raw message
Signature · 5 lines
2.39.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 33
Quoted 3 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +3
-0+static void run (unsigned int index) +{ +FILE *fd;
Please do not call FILE * pointer fd, that is confusing since fd is usually a file descriptor. FILE * pointer is usually just call f.
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 34
Quoted 1 line
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +1
-0+char needed_flag[] ="cpuid_fault" ;
I would include the space before flag name just to be extra careful we do not match anything that has this as a substring. E.g. if in the future they add something that would be named "no_cpuid_fault" this would still match strstr(line, "cpuid_fault") but not strstr(line, " cpuid_fault"); Ideally we would check that there is a space after the string, but we can't just do that with strstr() since the flag may be actually last in the list. So the only posibility would be using the pointer from strstr() and checking that the character after the matched string is also a space.
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 42
Quoted 8 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +8
-0+char *line =NULL ; +size_t len =0 ; +bool tag =0 ; + + fd =SAFE_FOPEN ("/proc/cpuinfo" ,"r" ); + +while (getline (&line, &len, fd) !=-1 ) { + if (strncmp(line, "flag", strlen("flag")) == 0 &&
^
why not just whole "flags" ?
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 47
Quoted 5 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +5
-0+ strstr(line, needed_flag) != NULL) { + tag =1 ; +break ; + } + }
This whole check for flag should be done in the test setup so that we do not parse the /proc/cpuinfo on each test iteration (-i command line option).
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 49
Quoted 2 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +2
-0+if (!tag) +tst_brk (TCONF ,"CPU need %s flag." , needed_flag);
Why don't we check that the prctl() returns ENODEV when the flag is not present. That is a valid testcase as well.
Quoted 24 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +21
-0+// index == 0 for disable cpuid, 1 for enable cpuid. +TST_EXP_PASS (arch_prctl_set (ARCH_SET_CPUID , index)); + +TEST (arch_prctl_get (ARCH_GET_CPUID )); + +if (TST_RET == index) +tst_res (TPASS ,"get cpuid succeed." ); +else + tst_res(TFAIL, "get cpuid failed."); +} + +static struct tst_test test = { + .test = run, + .tcnt =2 , + .min_kver ="4.12" , + .supported_archs = (const char *const []){"x86_64" ,"x86" ,NULL } +}; + +#else /* HAVE_ASM_PRCTL_H */ +TST_TEST_TCONF ("missing <asm/prctl.h>" ); +#endif Signature · 1 line
2.39.3
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 Add case about arch_prctl syscall.
Add testcase about arch_prctl syscall.
--- configure.ac | 1 + runtest/syscalls | 2 + .../kernel/syscalls/arch_prctl/.gitignore | 1 + testcases/kernel/syscalls/arch_prctl/Makefile | 8 ++ .../kernel/syscalls/arch_prctl/arch_prctl01.c | 103 ++++++++++++++++++ 5 files changed, 115 insertions(+) create mode 100644 testcases/kernel/syscalls/arch_prctl/.gitignore create mode 100644 testcases/kernel/syscalls/arch_prctl/Makefile create mode 100644 testcases/kernel/syscalls/arch_prctl/arch_prctl01.c
configure.ac +1 -0
@@ -41,6 +41,7 @@ AC_CHECK_DECLS([SEM_STAT_ANY],,,[#include <sys/sem.h>]) AC_CHECK_HEADERS_ONCE([ \ asm/ldt.h \ + asm/prctl.h \ cpuid.h \ emmintrin.h \ ifaddrs.h \
runtest/syscalls +2 -0
@@ -31,6 +31,8 @@ alarm05 alarm05 alarm06 alarm06 alarm07 alarm07 +arch_prctl01 arch_prctl01 + bind01 bind01 bind02 bind02 bind03 bind03
testcases/kernel/syscalls/arch_prctl/.gitignore new file +1 -0
@@ -0,0 +1 @@ +/arch_prctl01
testcases/kernel/syscalls/arch_prctl/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) UnionTech Software Technology Co.,Ltd. 2024 + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +103 -0
103 lines not on this page · raw message
Signature · 5 lines
2.39.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 6 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +6
-0+static void run (unsigned int index) +{ +struct tcase tc = tcases[index]; + +TEST (arch_prctl_set (ARCH_SET_CPUID , tc.input)); +
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 83
Quoted 10 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +10
-0+if (TST_RET == tc.set_exp) +if (tc.set_exp ==-1 ) +tst_res ((TST_ERR == tc.tst_errno ?TPASS :TFAIL ), +"set cpuid, expect: %s, get: %s" , +tst_strerrno (tc.tst_errno), +tst_strerrno (TST_ERR )); +else +tst_res (TPASS ,"set cpuid succeed." ); +else +tst_res (TFAIL ,"set cpuid failed." );
This is kind of ugly, why can't we just do:
if (tag) TST_EXP_PASS(arch_prctl_set(ARCH_SET_CPUID, index)); else TST_EXP_FAIL(arch_prctl_set(ARCH_SET_CPUID, index), ENODEV);
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c line 90
Quoted 6 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +6
-0+TEST (arch_prctl_get (ARCH_GET_CPUID )); + +if (TST_RET == tc.get_exp) +tst_res (TPASS ,"get cpuid succeed." ); +else +tst_res (TFAIL ,"get cpuid failed." );
We have to check the errno here as well, just branch on the tag as well:
if (tag) {
TEST(arch_prctl_get(ARCH_GET_CPUID));
if (TST_RET == index)
tst_res(TPASS, "...");
else
tst_res(FAIL, "...");
} else {
TST_EXP_FAIL(arch_prctl_get(ARCH_GET_CPUID), ENODEV);
}Generally the use of TST_EXP_FAIL() is prefered whenever possible.
Quoted 16 lines
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +13
-0+} + +static struct tst_test test = { + .test = run, + .setup = setup, + .tcnt =ARRAY_SIZE (tcases), + .min_kver ="4.12" , + .supported_archs = (const char *const []){"x86_64" ,"x86" ,NULL } +}; + +#else /* HAVE_ASM_PRCTL_H */ +TST_TEST_TCONF ("missing <asm/prctl.h>" ); +#endif Signature · 1 line
2.39.3
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi, Cyril.
Thanks again very much.
As written in man page, ENODEV seems only for ARCH_SET_CPUID, so I didn't use TST_EXP_FAIL in ARCH_GET_CPUID check. ARCH_GET_CPUID always success with returning cpuid status, I've tested this on a Intel J1900 machine witch has no cpuid_fault flag. I've resent the patch.
Lu Fei
site:www.uniontech.com
tel:(+86)18501012352
addr: Xi'an, China
------------------ Original ------------------
From: "Cyril Hrubis"<[email protected]>;
Date: Tue, May 7, 2024 12:51 PM
To: "lufei"<[email protected]>;
Cc: "ltp"<[email protected]>; "jstancek"<[email protected]>;
Subject: Re: [PATCH] Add case about arch_prctl syscall.
Hi!
> +static void run(unsigned int index)
> +{
> + struct tcase tc = tcases[index];
> +
> + TEST(arch_prctl_set(ARCH_SET_CPUID, tc.input));
> +
> + if (TST_RET == tc.set_exp)
> + if (tc.set_exp == -1)
> + tst_res((TST_ERR == tc.tst_errno ? TPASS : TFAIL),
> + "set cpuid, expect: %s, get: %s",
> + tst_strerrno(tc.tst_errno),
> + tst_strerrno(TST_ERR));
> + else
> + tst_res(TPASS, "set cpuid succeed.");
> + else
> + tst_res(TFAIL, "set cpuid failed.");
This is kind of ugly, why can't we just do:
if (tag) TST_EXP_PASS(arch_prctl_set(ARCH_SET_CPUID, index)); else TST_EXP_FAIL(arch_prctl_set(ARCH_SET_CPUID, index), ENODEV);
> + TEST(arch_prctl_get(ARCH_GET_CPUID));
> +
> + if (TST_RET == tc.get_exp)
> + tst_res(TPASS, "get cpuid succeed.");
> + else
> + tst_res(TFAIL, "get cpuid failed.");
We have to check the errno here as well, just branch on the tag as well:
if (tag) {
TEST(arch_prctl_get(ARCH_GET_CPUID));
if (TST_RET == index)
tst_res(TPASS, "...");
else
tst_res(FAIL, "...");
} else {
TST_EXP_FAIL(arch_prctl_get(ARCH_GET_CPUID), ENODEV);
}Generally the use of TST_EXP_FAIL() is prefered whenever possible.
> +}
> +
> +static struct tst_test test = {
> + .test = run,
> + .setup = setup,
> + .tcnt = ARRAY_SIZE(tcases),
> + .min_kver = "4.12",
> + .supported_archs = (const char *const []){"x86_64", "x86", NULL}
> +};
> +
> +#else /* HAVE_ASM_PRCTL_H */
> +TST_TEST_TCONF("missing <asm/prctl.h>");
> +#endif
> --
> 2.39.3
>
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 Add case about arch_prctl syscall.
Add testcase about arch_prctl syscall.
--- configure.ac | 1 + runtest/syscalls | 2 + .../kernel/syscalls/arch_prctl/.gitignore | 1 + testcases/kernel/syscalls/arch_prctl/Makefile | 8 ++ .../kernel/syscalls/arch_prctl/arch_prctl01.c | 82 +++++++++++++++++++ 5 files changed, 94 insertions(+) create mode 100644 testcases/kernel/syscalls/arch_prctl/.gitignore create mode 100644 testcases/kernel/syscalls/arch_prctl/Makefile create mode 100644 testcases/kernel/syscalls/arch_prctl/arch_prctl01.c
configure.ac +1 -0
@@ -41,6 +41,7 @@ AC_CHECK_DECLS([SEM_STAT_ANY],,,[#include <sys/sem.h>]) AC_CHECK_HEADERS_ONCE([ \ asm/ldt.h \ + asm/prctl.h \ cpuid.h \ emmintrin.h \ ifaddrs.h \
runtest/syscalls +2 -0
@@ -31,6 +31,8 @@ alarm05 alarm05 alarm06 alarm06 alarm07 alarm07 +arch_prctl01 arch_prctl01 + bind01 bind01 bind02 bind02 bind03 bind03
testcases/kernel/syscalls/arch_prctl/.gitignore new file +1 -0
@@ -0,0 +1 @@ +/arch_prctl01
testcases/kernel/syscalls/arch_prctl/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) UnionTech Software Technology Co.,Ltd. 2024 + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/arch_prctl/arch_prctl01.c new file +82 -0
82 lines not on this page · raw message
Signature · 5 lines
2.39.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Applied, thanks.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp