Skip to contentSkip to conversation

tests/unit: Remove debug statements in test-nested-aio-poll.c

PATCH Superseded Philippe Mathieu-Daudé 3 participants 3 messages Apr 19, 2024 – Apr 20, 2024

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/unit: Remove debug statements in test-nested-aio-poll.c

We are running this test since almost a year; it is safe to remove its debug statements, which clutter CI jobs output:

▶ 88/100 /nested-aio-poll OK
io_read 0x16bb26158
io_poll_true 0x16bb26158

Quoted 1 line

io_poll_ready

io_read 0x16bb26164
< io_poll_ready
io_poll_true 0x16bb26158
io_poll_false 0x16bb26164

Quoted 1 line

io_poll_ready

io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_read 0x16bb26164
< io_poll_ready
88/100 qemu:unit / test-nested-aio-poll OK

---
 tests/unit/test-nested-aio-poll.c | 7 -------
 1 file changed, 7 deletions(-)
tests/unit/test-nested-aio-poll.c +0 -7
index db33742af3..d8fd92c43b 100644
@@ -30,19 +30,16 @@ typedef struct {
 
 static void io_read(EventNotifier *notifier)
 {
-    fprintf(stderr, "%s %p\n", __func__, notifier);
     event_notifier_test_and_clear(notifier);
 }
 
 static bool io_poll_true(void *opaque)
 {
-    fprintf(stderr, "%s %p\n", __func__, opaque);
     return true;
 }
 
 static bool io_poll_false(void *opaque)
 {
-    fprintf(stderr, "%s %p\n", __func__, opaque);
     return false;
 }
 
@@ -50,8 +47,6 @@ static void io_poll_ready(EventNotifier *notifier)
 {
     TestData *td = container_of(notifier, TestData, poll_notifier);
 
-    fprintf(stderr, "> %s\n", __func__);
-
     g_assert(!td->nested);
     td->nested = true;
 
@@ -62,8 +57,6 @@ static void io_poll_ready(EventNotifier *notifier)
     g_assert(aio_poll(td->ctx, true));
 
     td->nested = false;
-
-    fprintf(stderr, "< %s\n", __func__);
 }
 
 /* dummy_notifier never triggers */
Signature · 1 line
2.41.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Philippe Mathieu-Daudé

We are running this test since almost a year; it is

Grammar suggestion:

We have been running this test for almost a year;

Quoted 25 lines

safe to remove its debug statements, which clutter CI jobs output:

▶ 88/100 /nested-aio-poll OK
io_read 0x16bb26158
io_poll_true 0x16bb26158

Quoted 1 line

io_poll_ready

io_read 0x16bb26164
< io_poll_ready
io_poll_true 0x16bb26158
io_poll_false 0x16bb26164

Quoted 1 line

io_poll_ready

io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_poll_false 0x16bb26164
io_read 0x16bb26164
< io_poll_ready
88/100 qemu:unit / test-nested-aio-poll OK

Quoted 4 lines
---
 tests/unit/test-nested-aio-poll.c | 7 -------
 1 file changed, 7 deletions(-)
Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org
Reviewed-by on v1 1/1
#2 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 26 lines · Philippe Mathieu-Daudé

We are running this test since almost a year; it is safe to remove its debug statements, which clutter CI jobs output:

   ▶  88/100 /nested-aio-poll                      OK
   io_read 0x16bb26158
   io_poll_true 0x16bb26158
   > io_poll_ready
   io_read 0x16bb26164
   < io_poll_ready
   io_poll_true 0x16bb26158
   io_poll_false 0x16bb26164
   > io_poll_ready
   io_poll_false 0x16bb26164
   io_poll_false 0x16bb26164
   io_poll_false 0x16bb26164
   io_poll_false 0x16bb26164
   io_poll_false 0x16bb26164
   io_poll_false 0x16bb26164
   io_poll_false 0x16bb26164
   io_poll_false 0x16bb26164
   io_poll_false 0x16bb26164
   io_read 0x16bb26164
   < io_poll_ready
   88/100 qemu:unit / test-nested-aio-poll        OK
Quoted 4 lines
---
  tests/unit/test-nested-aio-poll.c | 7 -------
  1 file changed, 7 deletions(-)

r~