perf annotate: Fix data type profiling on stdio
Namhyung Kim
maintainerPATCH 1/1 perf annotate: Fix data type profiling on stdio
The loop in hists__find_annotations() never set the 'nd' pointer to NULL and it makes stdio output repeating the last element forever. I think it doesn't set to NULL for TUI to prevent it from exiting unexpectedly. But it should just set on stdio mode.
--- tools/perf/builtin-annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-annotate.c +1 -1
@@ -491,7 +491,7 @@ static void hists__find_annotations(struct hists *hists,return ; } -if (next !=NULL ) +if (use_browser ==0 || next !=NULL ) nd = next;continue ;
Signature · 1 line
2.44.0.769.g3c40516874-goog
Quoted 8 lines · Namhyung Kim
The loop in
hists__find_annotations()never set the 'nd' pointer to NULL and it makes stdio output repeating the last element forever. I think it doesn't set to NULL for TUI to prevent it from exiting unexpectedly. But it should just set on stdio mode.Fixes d001c7a7f473 ("perf annotate-data: Add hist_entry__annotate_data_tui()")Signed-off-by Namhyung Kim <[email protected]>
Should we have a test to cover things like this?
Thanks,
Ian
Quoted 20 lines
--- tools/perf/builtin-annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/builtin-annotate.c +1
-2@@ -491,7 +491,7 @@ static void hists__find_annotations(struct hists *hists,return ; } -if (next !=NULL ) +if (use_browser ==0 || next !=NULL ) nd = next;continue ; --2.44.0.769.g3c40516874-goog
Namhyung Kim
maintainerQuoted 8 lines · Ian Rogers
Quoted 6 lines · Namhyung Kim
The loop in
hists__find_annotations()never set the 'nd' pointer to NULL and it makes stdio output repeating the last element forever. I think it doesn't set to NULL for TUI to prevent it from exiting unexpectedly. But it should just set on stdio mode.
Quoted 4 lines
Quoted 2 lines
Fixes d001c7a7f473 ("perf annotate-data: Add hist_entry__annotate_data_tui()")Signed-off-by Namhyung Kim <[email protected]>Acked-by Ian Rogers <[email protected]>
Thanks for your review!
Quoted 2 lines
Should we have a test to cover things like this?
Ok, I'll try to add one for perf annotate.
Thanks,
Namhyung
Quoted 9 lines · Namhyung Kim
Quoted 8 lines · Ian Rogers
Quoted 6 lines · Namhyung Kim
The loop in
hists__find_annotations()never set the 'nd' pointer to NULL and it makes stdio output repeating the last element forever. I think it doesn't set to NULL for TUI to prevent it from exiting unexpectedly. But it should just set on stdio mode.
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Fixes d001c7a7f473 ("perf annotate-data: Add hist_entry__annotate_data_tui()")Signed-off-by Namhyung Kim <[email protected]>Acked-by Ian Rogers <[email protected]>Thanks for your review!
Thanks, applied to perf-tools-next,
- Arnaldo
Quoted 7 lines
Quoted 2 lines
Should we have a test to cover things like this?
Ok, I'll try to add one for perf annotate.
Thanks,
Namhyung