Skip to contentSkip to conversation

net: openvswitch: Release reference to netdev

PATCH Applied Jun Gu 5 participants 5 messages Apr 23, 2024 – Apr 25, 2024

Subsystems (3)
lore
Share & tools
lore
reviewer Reviewed-by on v1 1/1
#1 lore raw
In reply to Jun Gu

+ David Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Eelco Chaudron

Quoted 5 lines · Jun Gu

dev_get_by_name will provide a reference on the netdev. So ensure that the reference of netdev is released after completed.

Fixes 2540088b836f ("net: openvswitch: Check vport netdev name")

Hi Jun Gu,

This change looks good to me.

Unfortunately didn't seem to hit netdev for some reason.

And, probably unrelated to that some CCs were missing:
they should be seeded using ./scripts/get_maintainer.pl my.patch

I'd wait for feedback from Jakub on if a repost is needed (because for one thing it's not good to repost within 24h.)

The above notwithstanding,

Quoted 35 lines
---
 net/openvswitch/vport-netdev.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
net/openvswitch/vport-netdev.c +6 -2
index 618edc346c0f..91a11067e458 100644
@@ -78,12 +78,16 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name)
 	int err;
 
 	vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
+	if (!vport->dev) {
+		err = -ENODEV;
+		goto error_free_vport;
+	}
 	/* Ensure that the device exists and that the provided
 	 * name is not one of its aliases.
 	 */
-	if (!vport->dev || strcmp(name, ovs_vport_name(vport))) {
+	if (strcmp(name, ovs_vport_name(vport))) {
 		err = -ENODEV;
-		goto error_free_vport;
+		goto error_put;
 	}
 	netdev_tracker_alloc(vport->dev, &vport->dev_tracker, GFP_KERNEL);
 	if (vport->dev->flags & IFF_LOOPBACK ||
Signature · 6 lines
2.25.1

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Jun Gu

author
#0 lore raw

PATCH 1/1 net: openvswitch: Release reference to netdev

dev_get_by_name will provide a reference on the netdev. So ensure that the reference of netdev is released after completed.

Fixes 2540088b836f ("net: openvswitch: Check vport netdev name")
---
 net/openvswitch/vport-netdev.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
net/openvswitch/vport-netdev.c +6 -2
index 618edc346c0f..91a11067e458 100644
@@ -78,12 +78,16 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name)
 	int err;
 
 	vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
+	if (!vport->dev) {
+		err = -ENODEV;
+		goto error_free_vport;
+	}
 	/* Ensure that the device exists and that the provided
 	 * name is not one of its aliases.
 	 */
-	if (!vport->dev || strcmp(name, ovs_vport_name(vport))) {
+	if (strcmp(name, ovs_vport_name(vport))) {
 		err = -ENODEV;
-		goto error_free_vport;
+		goto error_put;
 	}
 	netdev_tracker_alloc(vport->dev, &vport->dev_tracker, GFP_KERNEL);
 	if (vport->dev->flags & IFF_LOOPBACK ||
Signature · 1 line
2.25.1
#4 lore raw
In reply to Jun Gu
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Tue, 23 Apr 2024 15:37:51 +0800 you wrote:

dev_get_by_name will provide a reference on the netdev. So ensure that the reference of netdev is released after completed.

Fixes 2540088b836f ("net: openvswitch: Check vport netdev name")
---
 net/openvswitch/vport-netdev.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Here is the summary with links:
- [net-next] net: openvswitch: Release reference to netdev

    https://git.kernel.org/netdev/net-next/c/66270920f90f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html