Skip to contentSkip to conversation

drm/amdgpu: fix uninitialized scalar variable warning

PATCH In review Tim Huang 3 participants 3 messages Apr 23, 2024 – Apr 24, 2024

Subsystems (2)
lore
Share & tools
lore

Tim Huang

author
#0 lore raw

PATCH v3 1/1 drm/amdgpu: fix uninitialized scalar variable warning

From: Tim Huang <[email protected]>

Clear warning that uses uninitialized value fw_size.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c +2 -1
index d95555dc5485..fb5de23fa8d8 100644
@@ -1205,7 +1205,8 @@ void amdgpu_gfx_cp_init_microcode(struct amdgpu_device *adev,
 		fw_size = le32_to_cpu(cp_hdr_v2_0->data_size_bytes);
 		break;
 	default:
-		break;
+		dev_err(adev->dev, "Invalid ucode id %u\n", ucode_id);
+		return;
 	}
 
 	if (adev->firmware.load_type == AMDGPU_FW_LOAD_PSP) {
Signature · 1 line
2.39.2
maintainer Reviewed-by on v3 1/1
#1 lore raw

Am 23.04.24 um 16:31 schrieb Tim Huang:

Quoted 5 lines

From: Tim Huang <[email protected]>

Clear warning that uses uninitialized value fw_size.

Quoted 18 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c +2 -1
index d95555dc5485..fb5de23fa8d8 100644
@@ -1205,7 +1205,8 @@ void amdgpu_gfx_cp_init_microcode(struct amdgpu_device *adev,
  		fw_size = le32_to_cpu(cp_hdr_v2_0->data_size_bytes);
  		break;
  	default:
-		break;
+		dev_err(adev->dev, "Invalid ucode id %u\n", ucode_id);
+		return;
  	}
 
  	if (adev->firmware.load_type == AMDGPU_FW_LOAD_PSP) {
Reviewed-by on v3 1/1
#2 lore raw
In reply to Tim Huang

Am 23.04.24 um 16:31 schrieb Tim Huang:

Quoted 5 lines

From: Tim Huang <[email protected]>

Clear warning that uses uninitialized value fw_size.

Quoted 18 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c +2 -1
index d95555dc5485..fb5de23fa8d8 100644
@@ -1205,7 +1205,8 @@ void amdgpu_gfx_cp_init_microcode(struct amdgpu_device *adev,
  		fw_size = le32_to_cpu(cp_hdr_v2_0->data_size_bytes);
  		break;
  	default:
-		break;
+		dev_err(adev->dev, "Invalid ucode id %u\n", ucode_id);
+		return;
  	}
 
  	if (adev->firmware.load_type == AMDGPU_FW_LOAD_PSP) {