kunit: string-stream-test: use KUNIT_DEFINE_ACTION_WRAPPER
PATCH 1/1 kunit: string-stream-test: use KUNIT_DEFINE_ACTION_WRAPPER
Use KUNIT_DEFINE_ACTION_WRAPPER macro to define the 'kfree' and 'string_stream_destroy' wrappers for kunit_add_action.
Signed-off-by Ivan Orlov <[email protected]>
--- lib/kunit/string-stream-test.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
lib/kunit/string-stream-test.c +2 -10
@@ -22,18 +22,10 @@ struct string_stream_test_priv { };/* Avoids a cast warning if kfree() is passed direct to kunit_add_action(). */ -static void kfree_wrapper (void *p) -{ -kfree (p); -} +KUNIT_DEFINE_ACTION_WRAPPER(kfree_wrapper, kfree, const void *);/* Avoids a cast warning if string_stream_destroy() is passed direct to kunit_add_action(). */ -static void cleanup_raw_stream (void *p) -{ -struct string_stream *stream = p; - -string_stream_destroy (stream); -} +KUNIT_DEFINE_ACTION_WRAPPER(cleanup_raw_stream, string_stream_destroy, struct string_stream *);static char *get_concatenated_string (struct kunit *test,struct string_stream *stream) {
Signature · 1 line
2.34.1
Quoted 5 lines · Ivan Orlov
Use
KUNIT_DEFINE_ACTION_WRAPPERmacro to define the 'kfree' and 'string_stream_destroy' wrappers forkunit_add_action.Signed-off-by Ivan Orlov <[email protected]>
Hello!
This looks like a good use of the macro. Thanks!
Reviewed-by Rae Moar <[email protected]>
Thanks!
-Rae
Quoted 32 lines
--- lib/kunit/string-stream-test.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)lib/kunit/string-stream-test.c +2
-11@@ -22,18 +22,10 @@ struct string_stream_test_priv { };/* Avoids a cast warning if kfree() is passed direct to kunit_add_action(). */ -static void kfree_wrapper (void *p) -{ -kfree (p); -} +KUNIT_DEFINE_ACTION_WRAPPER(kfree_wrapper, kfree, const void *);/* Avoids a cast warning if string_stream_destroy() is passed direct to kunit_add_action(). */ -static void cleanup_raw_stream (void *p) -{ -struct string_stream *stream = p; - -string_stream_destroy (stream); -} +KUNIT_DEFINE_ACTION_WRAPPER(cleanup_raw_stream, string_stream_destroy, struct string_stream *);static char *get_concatenated_string (struct kunit *test,struct string_stream *stream) { --2.34.1
Quoted 6 lines · Ivan Orlov
Use
KUNIT_DEFINE_ACTION_WRAPPERmacro to define the 'kfree' and 'string_stream_destroy' wrappers forkunit_add_action.Signed-off-by Ivan Orlov <[email protected]>---
Acked-by David Gow <[email protected]>
Thanks,
-- David