Skip to contentSkip to conversation

target/i386: Introduce SapphireRapids-v3 to add missing features

PATCH Applied Lei Wang 4 participants 4 messages Apr 24, 2024

lore
Share & tools
lore

Lei Wang

author
#0 lore raw

PATCH 1/1 target/i386: Introduce SapphireRapids-v3 to add missing features

Add the missing features(ss, tsc-adjust, cldemote, movdiri, movdir64b) in the SapphireRapids-v3 CPU model.

---
 target/i386/cpu.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
target/i386/cpu.c +11 -0
index fd6af0d763..77e7945152 100644
@@ -3970,6 +3970,17 @@ static const X86CPUDefinition builtin_x86_defs[] = {
                     { /* end of list */ }
                 }
             },
+            {
+                .version = 3,
+                .props = (PropValue[]) {
+                    { "ss", "on" },
+                    { "tsc-adjust", "on" },
+                    { "cldemote", "on" },
+                    { "movdiri", "on" },
+                    { "movdir64b", "on" },
+                    { /* end of list */ }
+                }
+            },
             { /* end of list */ }
         }
     },
Signature · 1 line
2.39.3
#1 lore raw

Hi Lei,

Quoted 8 lines · Lei Wang

Date: Wed, 24 Apr 2024 03:29:12 -0400
From: Lei Wang <[email protected]>
Subject: [PATCH] target/i386: Introduce SapphireRapids-v3 to add missing
features
X-Mailer: git-send-email 2.39.3

Add the missing features(ss, tsc-adjust, cldemote, movdiri, movdir64b) in the SapphireRapids-v3 CPU model.

Considering that these are missing features, not hardware updates/fixes/Linux support changes, then as opposed to adding v3, it would be more appropriate to add these flags directly to the v1 SPR model with Fixes tag (Fixes:
commit 7eb061b06e97 ("i386: Add new CPU model SapphireRapids")).

Regards,
Zhao

#2 lore raw
Quoted 9 lines · Zhao Liu

Hi Lei,

Quoted 6 lines · Lei Wang

Date: Wed, 24 Apr 2024 03:29:12 -0400
From: Lei Wang <[email protected]>
Subject: [PATCH] target/i386: Introduce SapphireRapids-v3 to add missing
features
X-Mailer: git-send-email 2.39.3

Quoted 7 lines
Quoted 2 lines

Add the missing features(ss, tsc-adjust, cldemote, movdiri, movdir64b) in the SapphireRapids-v3 CPU model.

Considering that these are missing features, not hardware updates/fixes/Linux support changes, then as opposed to adding v3, it would be more appropriate to add these flags directly to the v1 SPR model with Fixes tag (Fixes:
commit 7eb061b06e97 ("i386: Add new CPU model SapphireRapids")).

That would break compatibility with v1 CPU models from existing releases of QEMU. Once released, a CPU version is read-only to preserve compatibility, which is why we have the CPU versioning concept.

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|