Skip to contentSkip to conversation

Move mdadm development to Github

DISCUSSION Mariusz Tkaczyk 9 participants 12 messages Apr 24, 2024 – May 6, 2024 MD RAID

lore
Share & tools
lore
#2 lore raw
In reply to Mariusz Tkaczyk
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mariusz" == Mariusz Tkaczyk <[email protected]> writes:

Hello,
In case you didn't notice the patchset:
https://lore.kernel.org/linux-raid/[email protected]/T/#t

For now, I didn't receive any feedback. I would love to hear you before making it real.

I'm really prefer you don't move the mailing list. I hate reading threads on a million different web apps. I don't mind the developement being there, but keeping the mailing list is better in my mind.

#3 lore raw
Quoted 7 lines · On Thu, 25 Apr 2024 17:04:20 -0400 "John Stoffel" <[email protected]> wrote:
Quoted 6 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Mariusz" == Mariusz Tkaczyk <[email protected]> writes:

Hello,
In case you didn't notice the patchset:
https://lore.kernel.org/linux-raid/[email protected]/T/#t

Quoted 8 lines
Quoted 2 lines

For now, I didn't receive any feedback. I would love to hear you before making it real.

I'm really prefer you don't move the mailing list. I hate reading threads on a million different web apps. I don't mind the developement being there, but keeping the mailing list is better in my mind.

To be clear, the mailing list is not moving. The two main changes here as Mariusz outlined in his email:

* The GitHub repo will be the new home of the code and should be considered the main repo. The other will be kept around and also be kept in sync
* Instead of using the mailing list to propose patches, use GitHub Pull Requests. Mariusz is setting up GitHub to send an email to the mailing list so that everyone can still be made aware of new patches in the same manner as before. Just use GitHub moving forward for actual code reviews.

Make sense?

-Paul

Quoted 1 line
#4 lore raw
Quoted 5 lines · Paul E Luse

* Instead of using the mailing list to propose patches, use GitHub Pull Requests. Mariusz is setting up GitHub to send an email to the mailing list so that everyone can still be made aware of new patches in the same manner as before. Just use GitHub moving forward for actual code reviews.

Does that mean contributors now need a github account? That won't go down well with some people I expect ...

Cheers,
Wol

author
#5 lore raw
Quoted 7 lines · On Fri, 26 Apr 2024 08:27:44 +0100 Wols Lists <[email protected]> wrote:
Quoted 5 lines · Paul E Luse

* Instead of using the mailing list to propose patches, use GitHub Pull Requests. Mariusz is setting up GitHub to send an email to the mailing list so that everyone can still be made aware of new patches in the same manner as before. Just use GitHub moving forward for actual code reviews.

Quoted 5 lines

Does that mean contributors now need a github account? That won't go down well with some people I expect ...

Cheers,
Wol

Hi Wol,

There are thousands repositories on Github you have to register to participate and I don't believe that Linux developers may don't have Github account. It is almost impossible to not have a need to sent something to Github.

Here some examples:
https://github.com/iovisor/bcc
https://github.com/axboe/fio
https://github.com/dracutdevs/dracut
https://github.com/util-linux/util-linux
https://github.com/bpftrace/bpftrace
https://github.com/systemd/systemd

I see this as not a problem.

Thanks,
Mariusz

#6 lore raw
Quoted 3 lines · Mariusz Tkaczyk

There are thousands repositories on Github you have to register to participate and I don't believe that Linux developers may don't have Github account. It is almost impossible to not have a need to sent something to Github.

There's plenty of us that refuse to create an account with an evil megacorp just to re-centralize development for no reason at all.

But hey, I'm not a major mdadmin contributor anyway.

#7 lore raw
Quoted 11 lines · On Fri, 26 Apr 2024 03:36:37 -0700 Christoph Hellwig <[email protected]> wrote:
Quoted 4 lines · Mariusz Tkaczyk

There are thousands repositories on Github you have to register to participate and I don't believe that Linux developers may don't have Github account. It is almost impossible to not have a need to sent something to Github.

There's plenty of us that refuse to create an account with an evil megacorp just to re-centralize development for no reason at all.

But hey, I'm not a major mdadmin contributor anyway.

It's true that you "need" to have a github account. That being said, MS has never been friendly to FLOSS/FOSS/OSS, only to mixed source SW. Even through to this day. For example, WSL.

So you can certainly move main dev over there, but please keep other places alive and well because there's literally no reason to think that this "marriage" of MS and OSS will not be an abusive relationship. E.G. some OSS devs have noticed AIs copying their code verbatim which then can wind up in closed source projects.

David

#8 lore raw
In reply to Mariusz Tkaczyk

Hi,

Quoted 13 lines · Mariusz Tkaczyk
Quoted 10 lines · On Fri, 26 Apr 2024 08:27:44 +0100 Wols Lists <[email protected]> wrote:
Quoted 5 lines · Paul E Luse

* Instead of using the mailing list to propose patches, use GitHub Pull Requests. Mariusz is setting up GitHub to send an email to the mailing list so that everyone can still be made aware of new patches in the same manner as before. Just use GitHub moving forward for actual code reviews.

Does that mean contributors now need a github account? That won't go down well with some people I expect ...

Quoted 8 lines
Quoted 2 lines

Cheers,
Wol

Hi Wol,

There are thousands repositories on Github you have to register to participate and I don't believe that Linux developers may don't have Github account. It is almost impossible to not have a need to sent something to Github.

Will it still be able to send and apply patches through maillist? It's important for us because I just can't create pr at GitHub in my company, already tried with Paul, due to our company policy. :( Although I can do this at home...

Thanks,
Kuai

Quoted 16 lines

Here some examples:
https://github.com/iovisor/bcc
https://github.com/axboe/fio
https://github.com/dracutdevs/dracut
https://github.com/util-linux/util-linux
https://github.com/bpftrace/bpftrace
https://github.com/systemd/systemd

I see this as not a problem.

Thanks,
Mariusz

.

#9 lore raw
Quoted 21 lines · Yu Kuai

Hi,

Quoted 18 lines · Mariusz Tkaczyk
Quoted 7 lines · On Fri, 26 Apr 2024 08:27:44 +0100 Wols Lists <[email protected]> wrote:
Quoted 5 lines · Paul E Luse

* Instead of using the mailing list to propose patches, use GitHub Pull Requests. Mariusz is setting up GitHub to send an email to the mailing list so that everyone can still be made aware of new patches in the same manner as before.  Just use GitHub moving forward for actual code reviews.

Quoted 5 lines

Does that mean contributors now need a github account? That won't go down well with some people I expect ...

Cheers,
Wol

Hi Wol,

Quoted 9 lines
Quoted 3 lines

There are thousands repositories on Github you have to register to participate and I don't believe that Linux developers may don't have Github account. It is almost impossible to not have a need to sent something to Github.

Will it still be able to send and apply patches through maillist? It's important for us because I just can't create pr at GitHub in my company, already tried with Paul, due to our company policy. :( Although I can do this at home...

I do think this is a valid point.
(Having been in Beijing recently I do share the pain from Kuai :-)

We really should keep the mailing list alive, and enable people to choose which interface suits them best.
I don't have a problem in switching to github as the primary tree, but we should keep the original location intact as a mirror and continue to allow people to use the mailing list to send patches.

This is especially important for low-volume mailing lists, where we have quite a few occasional contributors, and we should strive to make it as easy (and convenient) as possible for them.

Cheers,

Hannes

Quoted 18 lines
Quoted 16 lines

Here some examples:
https://github.com/iovisor/bcc
https://github.com/axboe/fio
https://github.com/dracutdevs/dracut
https://github.com/util-linux/util-linux
https://github.com/bpftrace/bpftrace
https://github.com/systemd/systemd

I see this as not a problem.

Thanks,
Mariusz

.

#10 lore raw
Quoted 11 lines · Hannes Reinecke

We really should keep the mailing list alive, and enable people to choose which interface suits them best.
I don't have a problem in switching to github as the primary tree, but we should keep the original location intact as a mirror and continue to allow people to use the mailing list to send patches.

This is especially important for low-volume mailing lists, where we have quite a few occasional contributors, and we should strive to make it as easy (and convenient) as possible for them.

Well they're planning to keep the mailing list - it isn't an mdadm list anyway. So long as they keep an eye on the list for list responses.

A lot of people (like me) go near github maybe once in a blue moon. Expecting non-dedicated developers to check regularly is a very big ask. Expecting reviewers to know what to do on github is a big ask!

I use github for a project, and really don't know my way around it.

Cheers,
Wol

author
#11 lore raw
In reply to Hannes Reinecke
Quoted 44 lines · On Tue, 30 Apr 2024 13:15:18 +0200 Hannes Reinecke <[email protected]> wrote:
Quoted 28 lines · Yu Kuai

Hi,

Quoted 17 lines · Mariusz Tkaczyk
Quoted 8 lines · On Fri, 26 Apr 2024 08:27:44 +0100 Wols Lists <[email protected]> wrote:
Quoted 6 lines · Paul E Luse

* Instead of using the mailing list to propose patches, use GitHub Pull Requests. Mariusz is setting up GitHub to send an email to the mailing
    list so that everyone can still be made aware of new patches in the same manner as before.  Just use GitHub moving forward for actual code reviews.

Quoted 5 lines

Does that mean contributors now need a github account? That won't go down well with some people I expect ...

Cheers,
Wol

Quoted 7 lines

Hi Wol,

There are thousands repositories on Github you have to register to participate
and I don't believe that Linux developers may don't have Github account. It is
almost impossible to not have a need to sent something to Github.

Quoted 5 lines

Will it still be able to send and apply patches through maillist? It's important for us because I just can't create pr at GitHub in my company, already tried with Paul, due to our company policy. :( Although I can do this at home...

I do think this is a valid point.
(Having been in Beijing recently I do share the pain from Kuai :-)

We really should keep the mailing list alive, and enable people to choose which interface suits them best.
I don't have a problem in switching to github as the primary tree, but we should keep the original location intact as a mirror and continue to allow people to use the mailing list to send patches.

Quoted 9 lines

This is especially important for low-volume mailing lists, where we have quite a few occasional contributors, and we should strive to make it as easy (and convenient) as possible for them.

Cheers,

Hannes

Quoted 1 line
Quoted 1 line

That one is good. For those exceptional cases I'm totally fine to do review on ML but I will request the justification why pull request cannot be created. I will create pull request myself or ask someone else to do this, not a big deal.

I will send v3.

Thanks Kuai and Hannes,
Mariusz