Skip to contentSkip to conversation

RDMA/efa: Add shutdown notifier

PATCH Superseded Michael Margolin 4 participants 6 messages Apr 25, 2024 – Apr 29, 2024

Subsystems (2)
lore
Share & tools
lore

Michael Margolin

author maintainer
#0 lore raw

PATCH 1/1 RDMA/efa: Add shutdown notifier

Add driver function to stop the device and release any active IRQs as preparation for shutdown. This should fix issues cased by unexpected AQ interrupts when booting kernel using kexec and possible data integrity issues when the system is being shutdown during traffic.

---
 drivers/infiniband/hw/efa/efa_main.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/infiniband/hw/efa/efa_main.c +11 -0
index 5fa3603c80d8..d1a48f988f6c 100644
@@ -671,11 +671,22 @@ static void efa_remove(struct pci_dev *pdev)
 	efa_remove_device(pdev);
 }
 
+static void efa_shutdown(struct pci_dev *pdev)
+{
+	struct efa_dev *dev = pci_get_drvdata(pdev);
+
+	efa_destroy_eqs(dev);
+	efa_com_dev_reset(&dev->edev, EFA_REGS_RESET_SHUTDOWN);
+	efa_free_irq(dev, &dev->admin_irq);
+	efa_disable_msix(dev);
+}
+
 static struct pci_driver efa_pci_driver = {
 	.name           = DRV_MODULE_NAME,
 	.id_table       = efa_pci_tbl,
 	.probe          = efa_probe,
 	.remove         = efa_remove,
+	.shutdown       = efa_shutdown,
 };
 
 module_pci_driver(efa_pci_driver);
Signature · 1 line
2.40.1
#1 lore raw

Hi Michael,

Thanks a lot for the patch.

Thanks,
Tao Liu

Quoted 43 lines · Michael Margolin

Add driver function to stop the device and release any active IRQs as preparation for shutdown. This should fix issues cased by unexpected AQ interrupts when booting kernel using kexec and possible data integrity issues when the system is being shutdown during traffic.

---
 drivers/infiniband/hw/efa/efa_main.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/infiniband/hw/efa/efa_main.c +11 -1
index 5fa3603c80d8..d1a48f988f6c 100644
@@ -671,11 +671,22 @@ static void efa_remove(struct pci_dev *pdev)
        efa_remove_device(pdev);
 }
 
+static void efa_shutdown(struct pci_dev *pdev)
+{
+       struct efa_dev *dev = pci_get_drvdata(pdev);
+
+       efa_destroy_eqs(dev);
+       efa_com_dev_reset(&dev->edev, EFA_REGS_RESET_SHUTDOWN);
+       efa_free_irq(dev, &dev->admin_irq);
+       efa_disable_msix(dev);
+}
+
 static struct pci_driver efa_pci_driver = {
        .name           = DRV_MODULE_NAME,
        .id_table       = efa_pci_tbl,
        .probe          = efa_probe,
        .remove         = efa_remove,
+       .shutdown       = efa_shutdown,
 };
 
 module_pci_driver(efa_pci_driver);
--

2.40.1

#2 lore raw
In reply to Michael Margolin
Quoted 2 lines · Michael Margolin

Add driver function to stop the device and release any active IRQs as preparation for shutdown. This should fix issues cased by unexpected AQ

s/cased/caused ?

Zhu Yanjun

Quoted 37 lines

interrupts when booting kernel using kexec and possible data integrity issues when the system is being shutdown during traffic.

---
  drivers/infiniband/hw/efa/efa_main.c | 11 +++++++++++
  1 file changed, 11 insertions(+)
drivers/infiniband/hw/efa/efa_main.c +11 -0
index 5fa3603c80d8..d1a48f988f6c 100644
@@ -671,11 +671,22 @@ static void efa_remove(struct pci_dev *pdev)
  	efa_remove_device(pdev);
  }
 
+static void efa_shutdown(struct pci_dev *pdev)
+{
+	struct efa_dev *dev = pci_get_drvdata(pdev);
+
+	efa_destroy_eqs(dev);
+	efa_com_dev_reset(&dev->edev, EFA_REGS_RESET_SHUTDOWN);
+	efa_free_irq(dev, &dev->admin_irq);
+	efa_disable_msix(dev);
+}
+
  static struct pci_driver efa_pci_driver = {
  	.name           = DRV_MODULE_NAME,
  	.id_table       = efa_pci_tbl,
  	.probe          = efa_probe,
  	.remove         = efa_remove,
+	.shutdown       = efa_shutdown,
  };
 
  module_pci_driver(efa_pci_driver);
author maintainer
#3 lore raw
Quoted 11 lines · Zhu Yanjun

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.

Quoted 2 lines · Michael Margolin

Add driver function to stop the device and release any active IRQs as preparation for shutdown. This should fix issues cased by unexpected AQ

s/cased/caused ?

Zhu Yanjun

Right, thanks.

Michael

author maintainer
#4 lore raw

PATCH v2 1/1 RDMA/efa: Add shutdown notifier

In reply to Zhu Yanjun

Add driver function to stop the device and release any active IRQs as preparation for shutdown. This should fix issues caused by unexpected AQ interrupts when booting kernel using kexec and possible data integrity issues when the system is being shutdown during traffic.

---
 drivers/infiniband/hw/efa/efa_main.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/infiniband/hw/efa/efa_main.c +11 -0
index 5fa3603c80d8..d1a48f988f6c 100644
@@ -671,11 +671,22 @@ static void efa_remove(struct pci_dev *pdev)
 	efa_remove_device(pdev);
 }
 
+static void efa_shutdown(struct pci_dev *pdev)
+{
+	struct efa_dev *dev = pci_get_drvdata(pdev);
+
+	efa_destroy_eqs(dev);
+	efa_com_dev_reset(&dev->edev, EFA_REGS_RESET_SHUTDOWN);
+	efa_free_irq(dev, &dev->admin_irq);
+	efa_disable_msix(dev);
+}
+
 static struct pci_driver efa_pci_driver = {
 	.name           = DRV_MODULE_NAME,
 	.id_table       = efa_pci_tbl,
 	.probe          = efa_probe,
 	.remove         = efa_remove,
+	.shutdown       = efa_shutdown,
 };
 
 module_pci_driver(efa_pci_driver);
Signature · 1 line
2.40.1
maintainer Applied
#5 lore raw
Quoted 11 lines · Michael Margolin

Add driver function to stop the device and release any active IRQs as preparation for shutdown. This should fix issues caused by unexpected AQ interrupts when booting kernel using kexec and possible data integrity issues when the system is being shutdown during traffic.

---
 drivers/infiniband/hw/efa/efa_main.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Applied to for-next

Jason