Skip to contentSkip to conversation

bcachefs: Use filemap_read() to simplify the execution flow

PATCH New Youling Tang 1 participant 1 message Apr 25, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcachefs: Use filemap_read() to simplify the execution flow

From: Youling Tang <[email protected]>

Using filemap_read() can reduce unnecessary code execution for non IOCB_DIRECT paths.

---
 fs/bcachefs/fs-io-direct.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/bcachefs/fs-io-direct.c +2 -2
index 09d21aef879a..4072a6ba0d51 100644
@@ -179,7 +179,7 @@ ssize_t bch2_read_iter(struct kiocb *iocb, struct iov_iter *iter)
 	struct bch_inode_info *inode = file_bch_inode(file);
 	struct address_space *mapping = file->f_mapping;
 	size_t count = iov_iter_count(iter);
-	ssize_t ret;
+	ssize_t ret = 0;
 
 	if (!count)
 		return 0; /* skip atime */
@@ -205,7 +205,7 @@ ssize_t bch2_read_iter(struct kiocb *iocb, struct iov_iter *iter)
 			iocb->ki_pos += ret;
 	} else {
 		bch2_pagecache_add_get(inode);
-		ret = generic_file_read_iter(iocb, iter);
+		ret = filemap_read(iocb, iter, ret);
 		bch2_pagecache_add_put(inode);
 	}
 out:
Signature · 1 line
2.34.1