rng: Introduce SPL_DM_RNG
Subsystems (4)
PATCH 1/3 rng: Introduce SPL_DM_RNG
Add SPL variant of DM_RNG so that the DM_RNG can be disabled in SPL if necessary. This may be necessary due to e.g. size constraints of the SPL.
---
Cc: Angelo Dureghello <[email protected]>
Cc: Emanuele Ghidoli <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Gaurav Jain <[email protected]>
Cc: Heinrich Schuchardt <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Simon Glass <[email protected]>
Cc: Stefan Roese <[email protected]>
Cc: Sughosh Ganu <[email protected]>
Cc: Svyatoslav Ryhel <[email protected]>
Cc: Tim Harvey <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: [email protected]
--- boot/pxe_utils.c | 4 +--- boot/vbe_request.c | 2 +- drivers/Makefile | 2 +- drivers/crypto/fsl/jr.c | 4 ++-- drivers/rng/Kconfig | 7 +++++++ drivers/rng/Makefile | 2 +- lib/uuid.c | 2 +- net/net_rand.h | 2 +- test/dm/Makefile | 2 +- 9 files changed, 16 insertions(+), 11 deletions(-)
boot/pxe_utils.c +1 -3
@@ -21,9 +21,7 @@#include <errno.h> #include <linux/list.h> -#ifdef CONFIG_DM_RNG #include <rng.h> -#endif #include <splash.h> #include <asm/io.h>
@@ -323,7 +321,7 @@ static int label_localboot(struct pxe_label *label)static void label_boot_kaslrseed (void ) { -#ifdef CONFIG_DM_RNG +#if CONFIG_IS_ENABLED (DM_RNG )ulong fdt_addr;struct fdt_header *working_fdt;size_t n =0x8 ;
boot/vbe_request.c +1 -1
@@ -36,7 +36,7 @@ static int handle_random_req(ofnode node, int default_size,u32 size;int ret; -if (!IS_ENABLED (CONFIG_DM_RNG )) +if (!CONFIG_IS_ENABLED (DM_RNG ))return -ENOTSUPP ;if (ofnode_read_u32 (node,"vbe,size" , &size)) {
drivers/Makefile +1 -1
@@ -126,7 +126,7 @@ obj-$(CONFIG_W1_EEPROM) += w1-eeprom/ obj-$(CONFIG_MACH_PIC32) += ddr/microchip/ obj-$(CONFIG_FUZZ) += fuzz/ obj-$(CONFIG_DM_HWSPINLOCK) += hwspinlock/ -obj-$(CONFIG_DM_RNG) += rng/ +obj-$(CONFIG_$(SPL_TPL_)DM_RNG) += rng/ endif obj-y += soc/
drivers/crypto/fsl/jr.c +2 -2
@@ -787,7 +787,7 @@ init: }#if CONFIG_IS_ENABLED (OF_CONTROL )if (ofnode_valid (scu_node)) { -if (IS_ENABLED (CONFIG_DM_RNG )) { +if (CONFIG_IS_ENABLED (DM_RNG )) { ret =device_bind_driver (NULL ,"caam-rng" ,"caam-rng" ,NULL );if (ret)printf ("Couldn't bind rng driver (%d)\n" , ret);
@@ -810,7 +810,7 @@ init:return -1 ; } -if (IS_ENABLED (CONFIG_DM_RNG )) { +if (CONFIG_IS_ENABLED (DM_RNG )) { ret =device_bind_driver (NULL ,"caam-rng" ,"caam-rng" ,NULL );if (ret)
drivers/rng/Kconfig +7 -0
@@ -6,6 +6,13 @@ config DM_RNG This interface is used to initialise the rng device and to read the random seed from the device. +config SPL_DM_RNG + bool "Driver support for Random Number Generator devices in SPL" + depends on SPL_DM + help + This option is an SPL-variant of the DM_RNG option. + See the help of DM_RNG for details. + if DM_RNG config RNG_MESON
drivers/rng/Makefile +1 -1
@@ -3,7 +3,7 @@ # Copyright (c) 2019, Linaro Limited # -obj-$(CONFIG_DM_RNG) += rng-uclass.o +obj-$(CONFIG_$(SPL_TPL_)DM_RNG) += rng-uclass.o obj-$(CONFIG_RNG_MESON) += meson-rng.o obj-$(CONFIG_RNG_SANDBOX) += sandbox_rng.o obj-$(CONFIG_RNG_MSM) += msm_rng.o
lib/uuid.c +1 -1
@@ -378,7 +378,7 @@ void gen_rand_uuid(unsigned char *uuid_bin)struct udevice *devp;u32 randv =0 ; -if (IS_ENABLED (CONFIG_DM_RNG )) { +if (CONFIG_IS_ENABLED (DM_RNG )) { ret =uclass_get_device (UCLASS_RNG ,0 , &devp);if (!ret) { ret =dm_rng_read (devp, &randv,sizeof (randv));
net/net_rand.h +1 -1
@@ -42,7 +42,7 @@ static inline void srand_mac(void)struct udevice *devp;u32 randv =0 ; -if (IS_ENABLED (CONFIG_DM_RNG )) { +if (CONFIG_IS_ENABLED (DM_RNG )) { ret =uclass_get_device (UCLASS_RNG ,0 , &devp);if (ret) { ret =dm_rng_read (devp, &randv,sizeof (randv));
test/dm/Makefile +1 -1
@@ -102,7 +102,7 @@ obj-$(CONFIG_DM_RESET) += reset.o obj-$(CONFIG_SYSRESET) += sysreset.o obj-$(CONFIG_DM_REGULATOR) += regulator.o obj-$(CONFIG_CMD_RKMTD) += rkmtd.o -obj-$(CONFIG_DM_RNG) += rng.o +obj-$(CONFIG_$(SPL_TPL_)DM_RNG) += rng.o obj-$(CONFIG_DM_RTC) += rtc.o obj-$(CONFIG_SCMI_FIRMWARE) += scmi.o obj-$(CONFIG_SCSI) += scsi.o
Signature · 1 line
2.43.0
PATCH 2/3 crypto/fsl: Introduce SPL_FSL_CAAM_RNG
Add SPL variant of SPL_FSL_CAAM_RNG so that the SPL_FSL_CAAM_RNG can be disabled in SPL if necessary. This may be necessary due to e.g. size constraints of the SPL.
---
Cc: Angelo Dureghello <[email protected]>
Cc: Emanuele Ghidoli <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Gaurav Jain <[email protected]>
Cc: Heinrich Schuchardt <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Simon Glass <[email protected]>
Cc: Stefan Roese <[email protected]>
Cc: Sughosh Ganu <[email protected]>
Cc: Svyatoslav Ryhel <[email protected]>
Cc: Tim Harvey <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: [email protected]
--- drivers/crypto/fsl/Kconfig | 7 +++++++ drivers/crypto/fsl/Makefile | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-)
drivers/crypto/fsl/Kconfig +7 -0
@@ -78,6 +78,13 @@ config FSL_CAAM_RNG using the prediction resistance flag which means the DRGB is reseeded from the TRNG every time random data is generated. +config SPL_FSL_CAAM_RNG + bool "Enable CAAM Random Number Generator support in SPL" + depends on SPL_DM_RNG + help + This option is an SPL-variant of the FSL_CAAM_RNG option. + See the help of FSL_CAAM_RNG for details. + endif config FSL_DCP_RNG
drivers/crypto/fsl/Makefile +1 -1
@@ -6,6 +6,6 @@ obj-y += sec.o obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o obj-$(CONFIG_CMD_BLOB)$(CONFIG_IMX_CAAM_DEK_ENCAP) += fsl_blob.o obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o -obj-$(CONFIG_FSL_CAAM_RNG) += rng.o +obj-$(CONFIG_$(SPL_TPL_)FSL_CAAM_RNG) += rng.o obj-$(CONFIG_FSL_DCP_RNG) += dcp_rng.o obj-$(CONFIG_FSL_MFGPROT) += fsl_mfgprot.o
Signature · 1 line
2.43.0
Re: [PATCH 2/3] crypto/fsl: Introduce SPL_FSL_CAAM_RNG
Quoted 57 lines · Marek Vasut
Add SPL variant of
SPL_FSL_CAAM_RNGso that theSPL_FSL_CAAM_RNGcan be disabled in SPL if necessary. This may be necessary due to e.g. size constraints of the SPL.Signed-off-by Marek Vasut <[email protected]>---
Cc: Angelo Dureghello <[email protected]>
Cc: Emanuele Ghidoli <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Gaurav Jain <[email protected]>
Cc: Heinrich Schuchardt <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Simon Glass <[email protected]>
Cc: Stefan Roese <[email protected]>
Cc: Sughosh Ganu <[email protected]>
Cc: Svyatoslav Ryhel <[email protected]>
Cc: Tim Harvey <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: [email protected]--- drivers/crypto/fsl/Kconfig | 7 +++++++ drivers/crypto/fsl/Makefile | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-)drivers/crypto/fsl/Kconfig +7
-0@@ -78,6 +78,13 @@ config FSL_CAAM_RNG using the prediction resistance flag which means the DRGB is reseeded from the TRNG every time random data is generated. +config SPL_FSL_CAAM_RNG + bool "Enable CAAM Random Number Generator support in SPL" + depends on SPL_DM_RNG + help + This option is an SPL-variant of the FSL_CAAM_RNG option. + See the help of FSL_CAAM_RNG for details. + endif config FSL_DCP_RNGdrivers/crypto/fsl/Makefile +1
-2@@ -6,6 +6,6 @@ obj-y += sec.o obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o obj-$(CONFIG_CMD_BLOB)$(CONFIG_IMX_CAAM_DEK_ENCAP) += fsl_blob.o obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o -obj-$(CONFIG_FSL_CAAM_RNG) += rng.o +obj-$(CONFIG_$(SPL_TPL_)FSL_CAAM_RNG) += rng.o obj-$(CONFIG_FSL_DCP_RNG) += dcp_rng.o obj-$(CONFIG_FSL_MFGPROT) += fsl_mfgprot.o --
Quoted 2 lines
2.43.0
Marek,
Thanks - this series does solve the issue I am seeing in the SPL when enabling DM_RNG. Is this going to cause an issue for people who expect it to be currently enabled and now have to manually enable it?
Best Regards,
Tim
Re: [PATCH 2/3] crypto/fsl: Introduce SPL_FSL_CAAM_RNG
Quoted 9 lines · Tim Harvey
Quoted 9 lines
drivers/crypto/fsl/Makefile +0
-1@@ -6,6 +6,6 @@ obj-y += sec.o obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o obj-$(CONFIG_CMD_BLOB)$(CONFIG_IMX_CAAM_DEK_ENCAP) += fsl_blob.o obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o -obj-$(CONFIG_FSL_CAAM_RNG) += rng.o
Quoted 8 lines
Quoted 6 lines
drivers/crypto/fsl/Makefile +1
-1+obj-$(CONFIG_$(SPL_TPL_)FSL_CAAM_RNG) += rng.o obj-$(CONFIG_FSL_DCP_RNG) += dcp_rng.o obj-$(CONFIG_FSL_MFGPROT) += fsl_mfgprot.o --2.43.0
Marek,
Hi,
Quoted 3 lines
Thanks - this series does solve the issue I am seeing in the SPL when enabling
DM_RNG. Is this going to cause an issue for people who expect it to be currently enabled and now have to manually enable it?
That's a good question. If I do '$ git grep FSL_CAAM_RNG' , there seem to be no users, so I don't think we need to worry here, right ?
With SPL_DM_RNG i.e. 1/3 I am a bit more concerned. But, looking at the users that enable DM_RNG, I am not seeing any obvious ones that would require SPL_DM_RNG too. What do you think ?
Re: [PATCH 2/3] crypto/fsl: Introduce SPL_FSL_CAAM_RNG
Quoted 26 lines · Marek Vasut
Quoted 9 lines · Tim Harvey
Quoted 9 lines
drivers/crypto/fsl/Makefile +0
-0@@ -6,6 +6,6 @@ obj-y += sec.oobj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o obj-$(CONFIG_CMD_BLOB)$(CONFIG_IMX_CAAM_DEK_ENCAP) += fsl_blob.o obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o -obj-$(CONFIG_FSL_CAAM_RNG) += rng.o
Quoted 8 lines
Quoted 6 lines
+obj-$(CONFIG_$(SPL_TPL_)FSL_CAAM_RNG) += rng.o
obj-$(CONFIG_FSL_DCP_RNG) += dcp_rng.o
obj-$(CONFIG_FSL_MFGPROT) += fsl_mfgprot.o
--
2.43.0Marek,
Hi,
Quoted 3 lines
Thanks - this series does solve the issue I am seeing in the SPL when enabling
DM_RNG. Is this going to cause an issue for people who expect it to be currently enabled and now have to manually enable it?
Quoted 6 lines
That's a good question. If I do '$ git grep
FSL_CAAM_RNG' , there seem to be no users, so I don't think we need to worry here, right ?With
SPL_DM_RNGi.e. 1/3 I am a bit more concerned. But, looking at the users that enableDM_RNG, I am not seeing any obvious ones that would requireSPL_DM_RNGtoo. What do you think ?
Grepping for UCLASS_RNG should find usages.
The only possible SPL usage seems to be in net/net_rand.h. Here a fallback to the mac address as seed exists.
Best regards
Heinrich
Re: [PATCH 2/3] crypto/fsl: Introduce SPL_FSL_CAAM_RNG
Quoted 30 lines · Heinrich Schuchardt
Quoted 29 lines · Marek Vasut
Quoted 9 lines · Tim Harvey
Quoted 9 lines
drivers/crypto/fsl/Makefile +0
-0@@ -6,6 +6,6 @@ obj-y += sec.oobj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o obj-$(CONFIG_CMD_BLOB)$(CONFIG_IMX_CAAM_DEK_ENCAP) += fsl_blob.o obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o -obj-$(CONFIG_FSL_CAAM_RNG) += rng.o
Quoted 8 lines
Quoted 6 lines
+obj-$(CONFIG_$(SPL_TPL_)FSL_CAAM_RNG) += rng.o
obj-$(CONFIG_FSL_DCP_RNG) += dcp_rng.o
obj-$(CONFIG_FSL_MFGPROT) += fsl_mfgprot.oSignature · 1 line
2.43.0Marek,
Hi,
Quoted 3 lines
Thanks - this series does solve the issue I am seeing in the SPL when enabling
DM_RNG. Is this going to cause an issue for people who expect it to be currently enabled and now have to manually enable it?That's a good question. If I do '$ git grep
FSL_CAAM_RNG' , there seem to be no users, so I don't think we need to worry here, right ?
Quoted 8 lines
Quoted 3 lines
With
SPL_DM_RNGi.e. 1/3 I am a bit more concerned. But, looking at the users that enableDM_RNG, I am not seeing any obvious ones that would requireSPL_DM_RNGtoo. What do you think ?Grepping for
UCLASS_RNGshould find usages.The only possible SPL usage seems to be in
net/net_rand.h. Here a fallback to the mac address as seed exists.
So this may need to be tested on AM335x with SPL ethernet boot ? +CC Nishanth ?
Re: [PATCH 2/3] crypto/fsl: Introduce SPL_FSL_CAAM_RNG
In reply to Heinrich SchuchardtQuoted 35 lines · Heinrich Schuchardt
Quoted 26 lines · Marek Vasut
Quoted 9 lines · Tim Harvey
Quoted 9 lines
drivers/crypto/fsl/Makefile +0
-1@@ -6,6 +6,6 @@ obj-y += sec.o obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o obj-$(CONFIG_CMD_BLOB)$(CONFIG_IMX_CAAM_DEK_ENCAP) += fsl_blob.o obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o -obj-$(CONFIG_FSL_CAAM_RNG) += rng.oQuoted 8 lines
Quoted 6 lines
drivers/crypto/fsl/Makefile +1
-1+obj-$(CONFIG_$(SPL_TPL_)FSL_CAAM_RNG) += rng.o obj-$(CONFIG_FSL_DCP_RNG) += dcp_rng.o obj-$(CONFIG_FSL_MFGPROT) += fsl_mfgprot.o --2.43.0
Marek,
Hi,
Quoted 3 lines
Thanks - this series does solve the issue I am seeing in the SPL when enabling
DM_RNG. Is this going to cause an issue for people who expect it to be currently enabled and now have to manually enable it?Quoted 6 lines
That's a good question. If I do '$ git grep
FSL_CAAM_RNG' , there seem to be no users, so I don't think we need to worry here, right ?With
SPL_DM_RNGi.e. 1/3 I am a bit more concerned. But, looking at the users that enableDM_RNG, I am not seeing any obvious ones that would requireSPL_DM_RNGtoo. What do you think ?
Quoted 9 lines
Grepping for
UCLASS_RNGshould find usages.The only possible SPL usage seems to be in
net/net_rand.h. Here a fallback to the mac address as seed exists.Best regards
Heinrich
Hi Heinrich,
looks like its also used in lib/uuid.c by CONFIG_RANDOM_UUID and the few configs have CONFIG_RANDOM_UUID=y do not have DM_RNG=y so not an issue.
srand_mac is used in:net/bootp.c which is CONFIG_CMD_BOOTP so not SPL net/dhcpv6.c which is CONIFG_CMD_DHCP6 so not in SPL net/net.c which is used by CONFIG_SPL_DM_ETH and the fallback you refer to but 'git grep DM_RNG=y configs/ | cut -d: -f1 | xargs grep SPL_DM_ETH' shows no results so I think this is ok right?
but I also see lib/efi_loader/efi_rng.c where UCLASS_RNG used by efi_rng_protocol - I don't know anything about efi... is this going to be used by SPL?
Best Regards,
Tim
Re: [PATCH 2/3] crypto/fsl: Introduce SPL_FSL_CAAM_RNG
Quoted 59 lines · Tim Harvey
Quoted 35 lines · Heinrich Schuchardt
Quoted 26 lines · Marek Vasut
Quoted 9 lines · Tim Harvey
Quoted 9 lines
drivers/crypto/fsl/Makefile +0
-1@@ -6,6 +6,6 @@ obj-y += sec.o obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o obj-$(CONFIG_CMD_BLOB)$(CONFIG_IMX_CAAM_DEK_ENCAP) += fsl_blob.o obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o -obj-$(CONFIG_FSL_CAAM_RNG) += rng.oQuoted 8 lines
Quoted 6 lines
drivers/crypto/fsl/Makefile +1
-1+obj-$(CONFIG_$(SPL_TPL_)FSL_CAAM_RNG) += rng.o obj-$(CONFIG_FSL_DCP_RNG) += dcp_rng.o obj-$(CONFIG_FSL_MFGPROT) += fsl_mfgprot.o --2.43.0
Marek,
Hi,
Quoted 3 lines
Thanks - this series does solve the issue I am seeing in the SPL when enabling
DM_RNG. Is this going to cause an issue for people who expect it to be currently enabled and now have to manually enable it?Quoted 6 lines
That's a good question. If I do '$ git grep
FSL_CAAM_RNG' , there seem to be no users, so I don't think we need to worry here, right ?With
SPL_DM_RNGi.e. 1/3 I am a bit more concerned. But, looking at the users that enableDM_RNG, I am not seeing any obvious ones that would requireSPL_DM_RNGtoo. What do you think ?Quoted 9 lines
Grepping for
UCLASS_RNGshould find usages.The only possible SPL usage seems to be in
net/net_rand.h. Here a fallback to the mac address as seed exists.Best regards
Heinrich
Hi Heinrich,
looks like its also used in
lib/uuid.cbyCONFIG_RANDOM_UUIDand the few configs haveCONFIG_RANDOM_UUID=ydo not have DM_RNG=y so not an issue.
srand_macis used in:net/bootp.cwhich isCONFIG_CMD_BOOTPso not SPLnet/dhcpv6.cwhich isCONIFG_CMD_DHCP6so not in SPLnet/net.cwhich is used byCONFIG_SPL_DM_ETHand the fallback you refer to but 'git grep DM_RNG=y configs/ | cut -d: -f1 | xargs grepSPL_DM_ETH' shows no results so I think this is ok right?
Quoted 3 lines
but I also see
lib/efi_loader/efi_rng.cwhereUCLASS_RNGused byefi_rng_protocol- I don't know anything about efi... is this going to be used by SPL?
UEFI is only relevant in main U-Boot. The EFI_RNG_PROTOCOL is used for KASLR by Linux but you can boot without it.
Best regards
Heinrich
RE: [EXT] Re: [PATCH 2/3] crypto/fsl: Introduce SPL_FSL_CAAM_RNG
In reply to Marek VasutHi Marek
Quoted 44 lines
-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Friday, April 26, 2024 9:33 AM
To: [email protected]
Cc: [email protected]; Angelo Dureghello <[email protected]>; Emanuele Ghidoli <[email protected]>; Fabio Estevam <[email protected]>; Gaurav Jain <[email protected]>; Heinrich Schuchardt <[email protected]>; Michal Simek <[email protected]>; Simon Glass <[email protected]>; Stefan Roese <[email protected]>; Sughosh Ganu <[email protected]>; Svyatoslav Ryhel <[email protected]>; Tom Rini <[email protected]>
Subject: [EXT] Re: [PATCH 2/3]crypto/fsl: IntroduceSPL_FSL_CAAM_RNGCaution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
Quoted 9 lines · Tim Harvey
Quoted 9 lines
(quoted diff) +0
-0b/drivers/crypto/fsl/Makefile index
7a2543e16cc..4fbce519a0b100644drivers/crypto/fsl/Makefile +0
-1@@ -6,6 +6,6 @@ obj-y += sec.o obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o obj-$(CONFIG_CMD_BLOB)$(CONFIG_IMX_CAAM_DEK_ENCAP) += fsl_blob.o obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o -obj-$(CONFIG_FSL_CAAM_RNG) += rng.oQuoted 8 lines
Quoted 6 lines
drivers/crypto/fsl/Makefile +1
-1+obj-$(CONFIG_$(SPL_TPL_)FSL_CAAM_RNG) += rng.o obj-$(CONFIG_FSL_DCP_RNG) += dcp_rng.o obj-$(CONFIG_FSL_MFGPROT) += fsl_mfgprot.o --2.43.0
Marek,
Hi,
Quoted 3 lines
Thanks - this series does solve the issue I am seeing in the SPL when enabling
DM_RNG. Is this going to cause an issue for people who expect it to be currently enabled and now have to manually enable it?
Quoted 6 lines
That's a good question. If I do '$ git grep
FSL_CAAM_RNG' , there seem to be no users, so I don't think we need to worry here, right ?With
SPL_DM_RNGi.e. 1/3 I am a bit more concerned. But, looking at the users that enableDM_RNG, I am not seeing any obvious ones that would requireSPL_DM_RNGtoo. What do you think ?
FSL_CAAM_RNG is enabled based on DM_RNG. This patch will disable the build of drivers/crypto/fsl/rng.c in SPL.
Regards
Gaurav Jain
Re: [EXT] Re: [PATCH 2/3] crypto/fsl: Introduce SPL_FSL_CAAM_RNG
On 4/29/24 11:02 AM, Gaurav Jain wrote:
Hi,
Quoted 24 lines
Quoted 24 lines
Quoted 9 lines
Quoted 9 lines
(quoted diff) +0
-0b/drivers/crypto/fsl/Makefile index
7a2543e16cc..4fbce519a0b100644drivers/crypto/fsl/Makefile +0
-1@@ -6,6 +6,6 @@ obj-y += sec.o obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o obj-$(CONFIG_CMD_BLOB)$(CONFIG_IMX_CAAM_DEK_ENCAP) += fsl_blob.o obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o -obj-$(CONFIG_FSL_CAAM_RNG) += rng.oQuoted 8 lines
Quoted 6 lines
drivers/crypto/fsl/Makefile +1
-1+obj-$(CONFIG_$(SPL_TPL_)FSL_CAAM_RNG) += rng.o obj-$(CONFIG_FSL_DCP_RNG) += dcp_rng.o obj-$(CONFIG_FSL_MFGPROT) += fsl_mfgprot.o --2.43.0
Marek,
Hi,
Quoted 3 lines
Thanks - this series does solve the issue I am seeing in the SPL when enabling
DM_RNG. Is this going to cause an issue for people who expect it to be currently enabled and now have to manually enable it?
Quoted 8 lines
Quoted 6 lines
That's a good question. If I do '$ git grep
FSL_CAAM_RNG' , there seem to be no users, so I don't think we need to worry here, right ?With
SPL_DM_RNGi.e. 1/3 I am a bit more concerned. But, looking at the users that enableDM_RNG, I am not seeing any obvious ones that would requireSPL_DM_RNGtoo. What do you think ?
FSL_CAAM_RNGis enabled based onDM_RNG. This patch will disable the build ofdrivers/crypto/fsl/rng.cin SPL.
Is that actually a problem for any supported platform ? (that is what is being discussed in this thread already)
PATCH 3/3 crypto/fsl: Differentiate between CAAM and DCP in Kconfig entry
In reply to Marek VasutDifferentiate between "Enable Random Number Generator support" and "Enable Random Number Generator support" in Kconfig entry, mark the first as CAAM and the second as DCP, otherwise users cannot easily decide which of the options is which and enable the correct one.
---
Cc: Angelo Dureghello <[email protected]>
Cc: Emanuele Ghidoli <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Gaurav Jain <[email protected]>
Cc: Heinrich Schuchardt <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Simon Glass <[email protected]>
Cc: Stefan Roese <[email protected]>
Cc: Sughosh Ganu <[email protected]>
Cc: Svyatoslav Ryhel <[email protected]>
Cc: Tim Harvey <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: [email protected]
--- drivers/crypto/fsl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/fsl/Kconfig +2 -2
@@ -69,7 +69,7 @@ config FSL_CAAM_JR_NTZ_ACCESS driver is used. config FSL_CAAM_RNG - bool "Enable Random Number Generator support" + bool "Enable CAAM Random Number Generator support" depends on DM_RNG default y help
@@ -88,7 +88,7 @@ config SPL_FSL_CAAM_RNG endif config FSL_DCP_RNG - bool "Enable Random Number Generator support" + bool "Enable DCP Random Number Generator support" depends on DM_RNG help Enable support for the hardware based random number generator
Signature · 1 line
2.43.0
Fabio Estevam
AppliedQuoted 6 lines · Marek Vasut
Add SPL variant of
DM_RNGso that theDM_RNGcan be disabled in SPL if necessary. This may be necessary due to e.g. size constraints of the SPL.Signed-off-by Marek Vasut <[email protected]>
Applied all, thanks.