Skip to contentSkip to conversation

drm/amdgpu: fix overflowed array index read warning

PATCH In review Tim Huang 3 participants 3 messages Apr 26, 2024

Subsystems (2)
lore
Share & tools
lore

Tim Huang

author
#0 lore raw

PATCH 1/1 drm/amdgpu: fix overflowed array index read warning

Clear overflowed array index read warning by cast operation.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c +2 -1
index 06f0a6534a94..15c240656470 100644
@@ -473,8 +473,9 @@ static ssize_t amdgpu_debugfs_ring_read(struct file *f, char __user *buf,
 					size_t size, loff_t *pos)
 {
 	struct amdgpu_ring *ring = file_inode(f)->i_private;
-	int r, i;
 	uint32_t value, result, early[3];
+	loff_t i;
+	int r;
 
 	if (*pos & 3 || size & 3)
 		return -EINVAL;
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Tim Huang

Clear overflowed array index read warning by cast operation.

Quoted 22 lines
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c +2 -2
index 06f0a6534a94..15c240656470 100644
@@ -473,8 +473,9 @@ static ssize_t amdgpu_debugfs_ring_read(struct file *f, char __user *buf,
                                        size_t size, loff_t *pos)
 {
        struct amdgpu_ring *ring = file_inode(f)->i_private;
-       int r, i;
        uint32_t value, result, early[3];
+       loff_t i;
+       int r;
 
        if (*pos & 3 || size & 3)
                return -EINVAL;
--

2.39.2

Reviewed-by on v1 1/1
#2 lore raw
In reply to Tim Huang

Am 26.04.24 um 02:27 schrieb Tim Huang:

Quoted 3 lines

Clear overflowed array index read warning by cast operation.

Quoted 19 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c +2 -1
index 06f0a6534a94..15c240656470 100644
@@ -473,8 +473,9 @@ static ssize_t amdgpu_debugfs_ring_read(struct file *f, char __user *buf,
  					size_t size, loff_t *pos)
  {
  	struct amdgpu_ring *ring = file_inode(f)->i_private;
-	int r, i;
  	uint32_t value, result, early[3];
+	loff_t i;
+	int r;
 
  	if (*pos & 3 || size & 3)
  		return -EINVAL;