SUNRPC: Remove comment for sp_lock
Subsystems (3)
PATCH 1/1 SUNRPC: Remove comment for sp_lock
It is obsolete since sp_lock was discarded in commit 580a25756a9f ("SUNRPC: discard sp_lock").
--- net/sunrpc/svc_xprt.c | 1 - 1 file changed, 1 deletion(-)
net/sunrpc/svc_xprt.c +0 -1
@@ -46,7 +46,6 @@ static LIST_HEAD(svc_xprt_class_list);/* SMP locking strategy: * -* svc_pool->sp_lock protects most of the fields of that pool. * svc_serv->sv_lock protects sv_tempsocks, sv_permsocks, sv_tmpcnt. * when both need to be taken (rare), svc_serv->sv_lock is first. * The "service mutex" protects svc_serv->sv_nrthread.
Signature · 1 line
2.35.3
Quoted 13 lines · Guoqing Jiang
It is obsolete since
sp_lockwas discarded in commit580a25756a9f("SUNRPC: discardsp_lock").Signed-off-by Guoqing Jiang <[email protected]>--- net/sunrpc/svc_xprt.c | 1 - 1 file changed, 1 deletion(-)net/sunrpc/svc_xprt.c +0
-0
net/sunrpc/svc_xprt.c static LIST_HEAD(svc_xprt_class_list); · line 51
Quoted 7 lines
net/sunrpc/svc_xprt.c +0
-1@@ -46,7 +46,6 @@ static LIST_HEAD(svc_xprt_class_list);/* SMP locking strategy: * -* svc_pool->sp_lock protects most of the fields of that pool. * svc_serv->sv_lock protects sv_tempsocks, sv_permsocks, sv_tmpcnt. * when both need to be taken (rare), svc_serv->sv_lock is first. * The "service mutex" protects svc_serv->sv_nrthread.
I usually make an effort to find those sorts of things but I obviously missed it this time.
Thanks.
NeilBrown
Hi Neil,
Quoted 15 lines · NeilBrown
Quoted 14 lines · Guoqing Jiang
It is obsolete since
sp_lockwas discarded in commit580a25756a9f("SUNRPC: discardsp_lock").Signed-off-by Guoqing Jiang <[email protected]>--- net/sunrpc/svc_xprt.c | 1 - 1 file changed, 1 deletion(-)net/sunrpc/svc_xprt.c +0
-0@@ -46,7 +46,6 @@ static LIST_HEAD(svc_xprt_class_list);
Quoted 10 lines
net/sunrpc/svc_xprt.c static LIST_HEAD(svc_xprt_class_list); · line 51
Quoted 6 lines
net/sunrpc/svc_xprt.c +0
-1/* SMP locking strategy: * -* svc_pool->sp_lock protects most of the fields of that pool. * svc_serv->sv_lock protects sv_tempsocks, sv_permsocks, sv_tmpcnt. * when both need to be taken (rare), svc_serv->sv_lock is first. * The "service mutex" protects svc_serv->sv_nrthread. I usually make an effort to find those sorts of things but I obviously missed it this time.
Thanks.
I find it occasionally during investigate one nfs issue 😁.
Quoted 1 line
Reviewed-by NeilBrown <[email protected]>
Thanks for your review!
Guoqing
Chuck Lever
AppliedQuoted 23 lines · Guoqing Jiang
It is obsolete since
sp_lockwas discarded in commit580a25756a9f("SUNRPC: discardsp_lock").Signed-off-by Guoqing Jiang <[email protected]>--- net/sunrpc/svc_xprt.c | 1 - 1 file changed, 1 deletion(-)net/sunrpc/svc_xprt.c +0
-1@@ -46,7 +46,6 @@ static LIST_HEAD(svc_xprt_class_list);/* SMP locking strategy: * -* svc_pool->sp_lock protects most of the fields of that pool. * svc_serv->sv_lock protects sv_tempsocks, sv_permsocks, sv_tmpcnt. * when both need to be taken (rare), svc_serv->sv_lock is first. * The "service mutex" protects svc_serv->sv_nrthread. Signature · 1 line
2.35.3
Applied to nfsd-next (for 6.10). Thank you!
Signature · 1 line
Chuck Lever