Skip to contentSkip to conversation

crash-add-prefix-for-crash-dumping-messages.patch removed from -mm tree

merged mm-nonmm-stable Andrew Morton 1 participant 1 message Apr 26, 2024

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: crash: add prefix for crash dumping messages
has been removed from the -mm tree. Its filename was
crash-add-prefix-for-crash-dumping-messages.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Baoquan He <[email protected]>
Subject: crash: add prefix for crash dumping messages
Date: Thu, 18 Apr 2024 11:58:43 +0800

Add pr_fmt() to kernel/crash_core.c to add the module name to debugging message printed as prefix.

And also add prefix 'crashkernel:' to two lines of message printing code in kernel/crash_reserve.c. In kernel/crash_reserve.c, almost all debugging messages have 'crashkernel:' prefix or there's keyword crashkernel at the beginning or in the middle, adding pr_fmt() makes it redundant.

---

 kernel/crash_core.c    |    2 ++
 kernel/crash_reserve.c |    4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)
kernel/crash_core.c renamed from kernel/crash_core.c~crash-add-prefix-for-crash-dumping-messages +2 -0
@@ -4,6 +4,8 @@
  * Copyright (C) 2002-2004 Eric Biederman  <[email protected]>
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/buildid.h>
 #include <linux/init.h>
 #include <linux/utsname.h>
kernel/crash_reserve.c renamed from kernel/crash_reserve.c~crash-add-prefix-for-crash-dumping-messages +2 -2
@@ -109,7 +109,7 @@ static int __init parse_crashkernel_mem(
 
 		size = memparse(cur, &tmp);
 		if (cur == tmp) {
-			pr_warn("Memory value expected\n");
+			pr_warn("crashkernel: Memory value expected\n");
 			return -EINVAL;
 		}
 		cur = tmp;
@@ -132,7 +132,7 @@ static int __init parse_crashkernel_mem(
 			cur++;
 			*crash_base = memparse(cur, &tmp);
 			if (cur == tmp) {
-				pr_warn("Memory value expected after '@'\n");
+				pr_warn("crahskernel: Memory value expected after '@'\n");
 				return -EINVAL;
 			}
 		}

_

Patches currently in -mm which might be from [email protected] are

kexec-fix-the-unexpected-kexec_dprintk-macro.patch