Skip to contentSkip to conversation

clocksource: Make the int help prompt unit readable in ncurses

PATCH Applied Borislav Petkov 5 participants 6 messages Apr 28, 2024 – Apr 29, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clocksource: Make the int help prompt unit readable in ncurses

From: "Borislav Petkov (AMD)" <[email protected]>

When doing

make menuconfig

and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the help says:

  │ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
  │ Type  : integer
  │ Range : [50 1000]
  │ Defined at kernel/time/Kconfig:204
  │   Prompt: Clocksource watchdog maximum allowable skew (in   s)

^^^^^

  │   Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]

because on some terminals, it cannot display the 'μ' char, unicode number 0x3bc.

So simply write it out so that there's no trouble.

Cc Paul E. McKenney <[email protected]>
Cc Waiman Long <[email protected]>
---
 kernel/time/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/Kconfig +1 -1
index fc3b1a06c981..8ebb6d5a106b 100644
@@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
 	  the size of the kernel image.
 
 config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
-	int "Clocksource watchdog maximum allowable skew (in μs)"
+	int "Clocksource watchdog maximum allowable skew (in microseconds)"
 	depends on CLOCKSOURCE_WATCHDOG
 	range 50 1000
 	default 125
Signature · 1 line
2.43.0
Acked-by on v1 1/1
#1 lore raw
Quoted 18 lines · Borislav Petkov

From: "Borislav Petkov (AMD)" <[email protected]>

When doing

make menuconfig

and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the help says:

  │ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
  │ Type  : integer
  │ Range : [50 1000]
  │ Defined at kernel/time/Kconfig:204
  │   Prompt: Clocksource watchdog maximum allowable skew (in   s)

^^^^^

  │   Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]
Quoted 8 lines

because on some terminals, it cannot display the 'μ' char, unicode number 0x3bc.

So simply write it out so that there's no trouble.

Cc Paul E. McKenney <[email protected]>
Cc Waiman Long <[email protected]>

Thanks.

Quoted 17 lines
---
 kernel/time/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/Kconfig +1 -1
index fc3b1a06c981..8ebb6d5a106b 100644
@@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
 	  the size of the kernel image.
 
 config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
-	int "Clocksource watchdog maximum allowable skew (in μs)"
+	int "Clocksource watchdog maximum allowable skew (in microseconds)"
 	depends on CLOCKSOURCE_WATCHDOG
 	range 50 1000
 	default 125
Signature · 3 lines
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
Acked-by on v1 1/1
#2 lore raw
In reply to Borislav Petkov
Quoted 18 lines · Borislav Petkov

From: "Borislav Petkov (AMD)" <[email protected]>

When doing

make menuconfig

and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the help says:

  │ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
  │ Type  : integer
  │ Range : [50 1000]
  │ Defined at kernel/time/Kconfig:204
  │   Prompt: Clocksource watchdog maximum allowable skew (in   s)

^^^^^

  │   Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]
Quoted 8 lines

because on some terminals, it cannot display the 'μ' char, unicode number 0x3bc.

So simply write it out so that there's no trouble.

Cc Paul E. McKenney <[email protected]>
Cc Waiman Long <[email protected]>

So all the world is not yet a UTF-8? ;-)

Quoted 20 lines
---
 kernel/time/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/Kconfig +1 -1
index fc3b1a06c981..8ebb6d5a106b 100644
@@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
 	  the size of the kernel image.
 
 config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
-	int "Clocksource watchdog maximum allowable skew (in μs)"
+	int "Clocksource watchdog maximum allowable skew (in microseconds)"
 	depends on CLOCKSOURCE_WATCHDOG
 	range 50 1000
 	default 125
Signature · 1 line
2.43.0
#5 lore raw
In reply to Borislav Petkov
The following commit has been merged into the timers/core branch of tip:

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     54db412e618e9c43e5167f809a901f554e8c43e2
Gitweb:        https://git.kernel.org/tip/54db412e618e9c43e5167f809a901f554e8c43e2
Author:        Borislav Petkov (AMD) <[email protected]>
AuthorDate:    Sun, 28 Apr 2024 12:21:43 +02:00
Committer:     Thomas Gleixner <[email protected]>
CommitterDate: Tue, 30 Apr 2024 00:12:22 +02:00

clocksource: Make the int help prompt unit readable in ncurses

When doing

make menuconfig

and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the help says:

  │ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
  │ Type  : integer
  │ Range : [50 1000]
  │ Defined at kernel/time/Kconfig:204
  │   Prompt: Clocksource watchdog maximum allowable skew (in   s)

^^^

  │   Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]

because on some terminals, it cannot display the 'μ' char, unicode number 0x3bc.

So simply write it out so that there's no trouble.

---
 kernel/time/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/Kconfig +1 -1
index fc3b1a0..8ebb6d5 100644
@@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
 	  the size of the kernel image.
 
 config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
-	int "Clocksource watchdog maximum allowable skew (in μs)"
+	int "Clocksource watchdog maximum allowable skew (in microseconds)"
 	depends on CLOCKSOURCE_WATCHDOG
 	range 50 1000
 	default 125
#3 lore raw
In reply to Paul E. McKenney
Quoted 1 line · Paul E. McKenney

So all the world is not yet a UTF-8? ;-)

... and it's not like I'm not trying. I have a fairly new debian testing, xterm v390 and libncurses5 v6.3 but nope, no joy.

I betcha it is some stupid conversion thing.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#4 lore raw
Quoted 7 lines · Borislav Petkov
Quoted 1 line · Paul E. McKenney

So all the world is not yet a UTF-8? ;-)

... and it's not like I'm not trying. I have a fairly new debian testing, xterm v390 and libncurses5 v6.3 but nope, no joy.

I betcha it is some stupid conversion thing.

Worse things could happen! ;-)

Thanx, Paul