gobi: Use LOW_POWER instead of PERSIST_LOW_POWER
PATCH 1/2 gobi: Use LOW_POWER instead of PERSIST_LOW_POWER
PERSIST_LOW_POWER setting is supposed to tell the device that it should not enter online state at the next bootup. Unfortunately, no USB devices tested seem to honor this setting.
Telit devices in particular will turn off the SIM and become unusable until set back into online mode. Use low-power instead of persistent low power state instead. AlwaysOnline support is now no longer needed.
--- plugins/gobi.c | 4 ++-- plugins/udevng.c | 1 - 2 files changed, 2 insertions(+), 3 deletions(-)
plugins/gobi.c +2 -2
@@ -226,7 +226,7 @@ static void get_oper_mode_cb(struct qmi_result *result, void *user_data)switch (data->oper_mode) {case QMI_DMS_OPER_MODE_ONLINE : param =qmi_param_new_uint8 (QMI_DMS_PARAM_OPER_MODE , -QMI_DMS_OPER_MODE_PERSIST_LOW_POWER ); +QMI_DMS_OPER_MODE_LOW_POWER );if (!param) {shutdown_device (modem);return ;
@@ -480,7 +480,7 @@ static int gobi_disable(struct ofono_modem *modem) goto out; param =qmi_param_new_uint8 (QMI_DMS_PARAM_OPER_MODE , -QMI_DMS_OPER_MODE_PERSIST_LOW_POWER ); +QMI_DMS_OPER_MODE_LOW_POWER );if (!param)return -ENOMEM ;
plugins/udevng.c +0 -1
@@ -850,7 +850,6 @@ static gboolean setup_telitqmi(struct modem_info *modem)return FALSE;ofono_modem_set_boolean (modem->modem,"ForceSimLegacy" , TRUE); -ofono_modem_set_boolean (modem->modem,"AlwaysOnline" , TRUE);return TRUE; }
Signature · 1 line
2.44.0
PATCH 2/2 udevng: Add support for Telit FN990
--- plugins/udevng.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
plugins/udevng.c +6 -2
@@ -834,7 +834,8 @@ static gboolean setup_telitqmi(struct modem_info *modem)DBG ("%s %s %s %s %s" , info->devnode, info->interface, info->number, info->label, subsystem); -if (g_strcmp0 (info->interface,"255/255/255" ) ==0 && +if ((!g_strcmp0 (info->interface,"255/255/255" ) || + !g_strcmp0 (info->interface,"255/255/80" )) &&g_strcmp0 (info->number,"02" ) ==0 ) {if (g_strcmp0 (subsystem,"net" ) ==0 ) net = info;
@@ -849,7 +850,8 @@ static gboolean setup_telitqmi(struct modem_info *modem)if (setup_qmi (modem, qmi, net) <0 )return FALSE; -ofono_modem_set_boolean (modem->modem,"ForceSimLegacy" , TRUE); +if (g_strcmp0 (modem->model,"1070" )) +ofono_modem_set_boolean (modem->modem,"ForceSimLegacy" , TRUE);return TRUE; }
@@ -2037,6 +2039,8 @@ static struct { { "telit", "cdc_acm", "1bc7", "0021" }, { "telitqmi", "qmi_wwan", "1bc7", "1201" }, { "telitqmi", "option", "1bc7", "1201" }, + { "telitqmi", "qmi_wwan", "1bc7", "1070" }, + { "telitqmi", "option", "1bc7", "1070" }, { "droid", "qmi_wwan", "22b8", "2a70" }, { "droid", "option", "22b8", "2a70" }, { "nokia", "option", "0421", "060e" },
Signature · 1 line
2.44.0
This series was applied to ofono.git (master) by Denis Kenzior <[email protected]>:
Hello:
This series was applied to ofono.git (master)
by Denis Kenzior <[email protected]>:
Quoted 9 lines · On Tue, 30 Apr 2024 12:37:34 -0500 you wrote:
PERSIST_LOW_POWERsetting is supposed to tell the device that it should not enter online state at the next bootup. Unfortunately, no USB devices tested seem to honor this setting.Telit devices in particular will turn off the SIM and become unusable until set back into online mode. Use low-power instead of persistent low power state instead. AlwaysOnline support is now no longer needed.
[...]
Here is the summary with links:
- [1/2] gobi: Use LOW_POWER instead of PERSIST_LOW_POWER
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=75ba0c33e3e3 - [2/2] udevng: Add support for Telit FN990 https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=e41785fbd397
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html