Skip to contentSkip to conversation

fs: Do not allow get_file() to resurrect 0 f_count

PATCH In review Kees Cook 8 participants 26 messages May 2, 2024 – May 6, 2024

Subsystems (8)
DRM drivers VFS DRM misc Kbuild +4 more subsystems
lore
Share & tools
lore

Kees Cook

author
#0 lore raw

cover fs: Do not allow get_file() to resurrect 0 f_count

Hi,

Failure with f_count reference counting are better contained by an actual reference counting type, like refcount_t. The first step is for get_file() to use inc_not_zero to avoid resurrection. I also found a couple open-coded modifications of f_count that should be using get_file(). Since long ago, f_count was switched to atomic_long_t, so to get proper reference count checking, I've added a refcount_long_t API, and then converted f_count to refcount_long_t.

Now if there are underflows (or somehow an overflow), we'll see them reported.

-Kees

Kees Cook (5):
fs: Do not allow get_file() to resurrect 0 f_count drm/vmwgfx: Do not directly manipulate file->f_count drm/i915: Do not directly manipulate file->f_count
refcount: Introduce refcount_long_t and APIs
fs: Convert struct file::f_count to refcount_long_t

 MAINTAINERS                           |   2 +-
 Makefile                              |  11 +-
 drivers/gpu/drm/i915/gt/shmem_utils.c |   5 +-
 drivers/gpu/drm/vmwgfx/ttm_object.c   |   2 +-
 fs/file.c                             |   4 +-
 fs/file_table.c                       |   6 +-
 include/linux/fs.h                    |   7 +-
 include/linux/refcount-impl.h         | 344 ++++++++++++++++++++++++++
 include/linux/refcount.h              | 341 +------------------------
 include/linux/refcount_types.h        |  12 +
 lib/refcount.c                        |  17 +-
 11 files changed, 398 insertions(+), 353 deletions(-)
 create mode 100644 include/linux/refcount-impl.h
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH 1/5 fs: Do not allow get_file() to resurrect 0 f_count

If f_count reaches 0, calling get_file() should be a failure. Adjust to use atomic_long_inc_not_zero() and return NULL on failure. In the future get_file() can be annotated with __must_check, though that is not currently possible.

---
Cc: Christian Brauner <[email protected]>
Cc: Alexander Viro <[email protected]>
Cc: Jan Kara <[email protected]>
Cc: [email protected]

---
 include/linux/fs.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/fs.h +2 -1
index 00fc429b0af0..210bbbfe9b83 100644
@@ -1038,7 +1038,8 @@ struct file_handle {
 
 static inline struct file *get_file(struct file *f)
 {
-	atomic_long_inc(&f->f_count);
+	if (unlikely(!atomic_long_inc_not_zero(&f->f_count)))
+		return NULL;
 	return f;
 }
 
Signature · 1 line
2.34.1
#2 lore raw
Quoted 4 lines · Kees Cook

If f_count reaches 0, calling get_file() should be a failure. Adjust to use atomic_long_inc_not_zero() and return NULL on failure. In the future get_file() can be annotated with __must_check, though that is not currently possible.

[...]

include/linux/fs.h struct file_handle { · line 1044

Quoted 7 lines

static inline struct file *get_file(struct file *f) {

include/linux/fs.h +2 -1
-       atomic_long_inc(&f->f_count);
+       if (unlikely(!atomic_long_inc_not_zero(&f->f_count)))
+               return NULL;
        return f;
 }

Oh, I really don't like this...

In most code, if you call get_file() on a file and see refcount zero, that basically means you're in a UAF write situation, or that you could be in such a situation if you had raced differently. It's basically just like refcount_inc() in that regard.

And get_file() has semantics just like refcount_inc(): The caller guarantees that it is already holding a reference to the file; and if the caller is wrong about that, their subsequent attempt to clean up the reference that they think they were already holding will likely lead to UAF too. If get_file() sees a zero refcount, there is no safe way to continue. And all existing callers of get_file() expect the return value to be the same as the non-NULL pointer they passed in, so they'll either ignore the result of this check and barrel on, or oops with a NULL deref.

For callers that want to actually try incrementing file refcounts that could be zero, which is only possible under specific circumstances, we have helpers like get_file_rcu() and get_file_active().

Can't you throw a CHECK_DATA_CORRUPTION() or something like that in there instead?

author
#3 lore raw
Quoted 14 lines · Jann Horn
Quoted 4 lines · Kees Cook

If f_count reaches 0, calling get_file() should be a failure. Adjust to use atomic_long_inc_not_zero() and return NULL on failure. In the future get_file() can be annotated with __must_check, though that is not currently possible.

[...]

include/linux/fs.h struct file_handle { · line 1044

Quoted 7 lines

static inline struct file *get_file(struct file *f) {

include/linux/fs.h +2 -1
-       atomic_long_inc(&f->f_count);
+       if (unlikely(!atomic_long_inc_not_zero(&f->f_count)))
+               return NULL;
        return f;
 }
Quoted 6 lines

Oh, I really don't like this...

In most code, if you call get_file() on a file and see refcount zero, that basically means you're in a UAF write situation, or that you could be in such a situation if you had raced differently. It's basically just like refcount_inc() in that regard.

Shouldn't the system attempt to not make things worse if it encounters an inc-from-0 condition? Yes, we've already lost the race for a UaF condition, but maybe don't continue on.

Quoted 2 lines

And get_file() has semantics just like refcount_inc(): The caller guarantees that it is already holding a reference to the file; and if

Yes, but if that guarantee is violated, we should do something about it.

Quoted 11 lines

the caller is wrong about that, their subsequent attempt to clean up the reference that they think they were already holding will likely lead to UAF too. If get_file() sees a zero refcount, there is no safe way to continue. And all existing callers of get_file() expect the return value to be the same as the non-NULL pointer they passed in, so they'll either ignore the result of this check and barrel on, or oops with a NULL deref.

For callers that want to actually try incrementing file refcounts that could be zero, which is only possible under specific circumstances, we have helpers like get_file_rcu() and get_file_active().

So what's going on in here:
https://lore.kernel.org/linux-hardening/[email protected]/

Quoted 2 lines

Can't you throw a CHECK_DATA_CORRUPTION() or something like that in there instead?

I'm open to suggestions, but given what's happening with struct dma_buf above, it seems like this is a state worth checking for?

Signature · 1 line
Kees Cook
#4 lore raw
Quoted 39 lines · Kees Cook
Quoted 14 lines · Jann Horn
Quoted 4 lines · Kees Cook

If f_count reaches 0, calling get_file() should be a failure. Adjust to use atomic_long_inc_not_zero() and return NULL on failure. In the future get_file() can be annotated with __must_check, though that is not currently possible.

[...]

include/linux/fs.h struct file_handle { · line 1044

Quoted 7 lines

static inline struct file *get_file(struct file *f) {

include/linux/fs.h +2 -1
-       atomic_long_inc(&f->f_count);
+       if (unlikely(!atomic_long_inc_not_zero(&f->f_count)))
+               return NULL;
        return f;
 }
Quoted 6 lines

Oh, I really don't like this...

In most code, if you call get_file() on a file and see refcount zero, that basically means you're in a UAF write situation, or that you could be in such a situation if you had raced differently. It's basically just like refcount_inc() in that regard.

Shouldn't the system attempt to not make things worse if it encounters an inc-from-0 condition? Yes, we've already lost the race for a UaF condition, but maybe don't continue on.

Quoted 2 lines

And get_file() has semantics just like refcount_inc(): The caller guarantees that it is already holding a reference to the file; and if

Yes, but if that guarantee is violated, we should do something about it.

Quoted 8 lines

the caller is wrong about that, their subsequent attempt to clean up the reference that they think they were already holding will likely lead to UAF too. If get_file() sees a zero refcount, there is no safe way to continue. And all existing callers of get_file() expect the return value to be the same as the non-NULL pointer they passed in, so they'll either ignore the result of this check and barrel on, or oops with a NULL deref.

Quoted 6 lines
Quoted 3 lines

For callers that want to actually try incrementing file refcounts that could be zero, which is only possible under specific circumstances, we have helpers like get_file_rcu() and get_file_active().

So what's going on in here:
https://lore.kernel.org/linux-hardening/[email protected]/

Afaict, there's dma_buf_export() that allocates a new file and sets:

file->private_data = dmabuf;
dmabuf->file = file;

The file has f_op->release::dma_buf_file_release() as it's f_op->release method. When that's called the file's refcount is already zero but the file has not been freed yet. This will remove the dmabuf from some public list but it won't free it.

Then we see that any dentry allocated for such a dmabuf file will have dma_buf_dentry_ops which in turn has dentry->d_release::dma_buf_release() which is where the actual release of the dma buffer happens taken from dentry->d_fsdata.

That whole thing calls allocate_file_pseudo() which allocates a new dentry specific to that struct file. That dentry is unhashed (no lookup) and thus isn't retained so when dput() is called and it's the last reference it's immediately followed by dentry->d_release::dma_buf_release() which wipes the dmabuf itself.

The lifetime of the dmabuf is managed via fget()/fput(). So the lifetime of the dmabuf and the lifetime of the file are almost identical afaict:

__fput()
-> f_op->release::dma_buf_file_release() // handles file specific freeing -> dput()
-> d_op->d_release::dma_buf_release() // handles dmabuf freeing

                                         // including the driver specific stuff.

If you fput() the file then the dmabuf will be freed as well immediately after it when the dput() happens in __fput() (I struggle to come up with an explanation why the freeing of the dmabuf is moved to dentry->d_release instead of f_op->release itself but that's a separate matter.).

So on the face of it without looking a little closer

static bool __must_check get_dma_buf_unless_doomed(struct dma_buf *dmabuf)

{
        return atomic_long_inc_not_zero(&dmabuf->file->f_count) != 0L;
}

looks wrong or broken. Because if dmabuf->file->f_count is 0 it implies that @dmabuf should have already been freed. So the bug would be in accessing @dmabuf. And if @dmabuf is valid then it automatically means that dmabuf->file->f_count isn't 0. So it looks like it could just use get_file().

_But_ the interesting bits are in ttm_object_device_init(). This steals the dma_buf_ops into tdev->ops. It then takes dma_buf_ops->release and stores it away into tdev->dma_buf_release. Then it overrides the dma_buf_ops->release with ttm_prime_dmabuf_release(). And that's where the very questionable magic happens.

So now let's say the dmabuf is freed because of lat fput(). We now get f_op->release::dma_buf_file_release(). Then it's followed by dput() and ultimately dentry->d_release::dma_buf_release() as mentioned above.

But now when we get:

dentry->d_release::dma_buf_release()
-> dmabuf->ops->release::ttm_prime_dmabuf_release()

instead of the original dmabuf->ops->release method that was stolen into tdev->dmabuf_release. And ttm_prime_dmabuf_release() now calls tdev->dma_buf_release() which just frees the data associated with the dmabuf not the dmabuf itself.

ttm_prime_dmabuf_release() then takes prime->mutex_lock replacing prime->dma_buf with NULL.

The same lock is taken in ttm_prime_handle_to_fd() which is picking that dmabuf from prime->dmabuf. So the interesting case is when ttm_prime_dma_buf_release() has called tdev->dmabuf_release() and but someone else maanged to grab prime->mutex_lock before ttm_prime_dma_buf_release() could grab it to NULL prime->dma_buf.

So at that point @dmabuf hasn't been freed yet and is still valid. So dereferencing prime->dma_buf is still valid and by extension dma_buf->file as their lifetimes are tied.

IOW, that should just use get_file_active() which handles that just fine.

And while that get_dma_buf_unless_doomed() thing is safe that whole code reeks of a level of complexity that's asking for trouble.

But that has zero to do with get_file() and it is absolutely not a reason to mess with it's semantics impacting every caller in the tree.

Quoted 6 lines
Quoted 3 lines

Can't you throw a CHECK_DATA_CORRUPTION() or something like that in there instead?

I'm open to suggestions, but given what's happening with struct dma_buf above, it seems like this is a state worth checking for?

No, it's really not. If you use get_file() you better know that you're already holding a valid reference that's no reason to make it suddenly fail.

#5 lore raw

On Fri, 3 May 2024 11:02:57 +0200 Christian Brauner <[email protected]>

Quoted 142 lines · Kees Cook
Quoted 39 lines · Jann Horn
Quoted 14 lines · Kees Cook
Quoted 4 lines

If f_count reaches 0, calling get_file() should be a failure. Adjust to use atomic_long_inc_not_zero() and return NULL on failure. In the future get_file() can be annotated with __must_check, though that is not currently possible.

[...]

include/linux/fs.h struct file_handle { · line 1044

Quoted 7 lines

static inline struct file *get_file(struct file *f) {

include/linux/fs.h +2 -1
-       atomic_long_inc(&f->f_count);
+       if (unlikely(!atomic_long_inc_not_zero(&f->f_count)))
+               return NULL;
        return f;
 }
Quoted 6 lines

Oh, I really don't like this...

In most code, if you call get_file() on a file and see refcount zero, that basically means you're in a UAF write situation, or that you could be in such a situation if you had raced differently. It's basically just like refcount_inc() in that regard.

Shouldn't the system attempt to not make things worse if it encounters an inc-from-0 condition? Yes, we've already lost the race for a UaF condition, but maybe don't continue on.

Quoted 2 lines

And get_file() has semantics just like refcount_inc(): The caller guarantees that it is already holding a reference to the file; and if

Yes, but if that guarantee is violated, we should do something about it.

Quoted 8 lines

the caller is wrong about that, their subsequent attempt to clean up the reference that they think they were already holding will likely lead to UAF too. If get_file() sees a zero refcount, there is no safe way to continue. And all existing callers of get_file() expect the return value to be the same as the non-NULL pointer they passed in, so they'll either ignore the result of this check and barrel on, or oops with a NULL deref.

Quoted 6 lines
Quoted 3 lines

For callers that want to actually try incrementing file refcounts that could be zero, which is only possible under specific circumstances, we have helpers like get_file_rcu() and get_file_active().

So what's going on in here:
https://lore.kernel.org/linux-hardening/[email protected]/

Afaict, there's dma_buf_export() that allocates a new file and sets:

file->private_data = dmabuf;
dmabuf->file = file;

The file has f_op->release::dma_buf_file_release() as it's f_op->release method. When that's called the file's refcount is already zero but the file has not been freed yet. This will remove the dmabuf from some public list but it won't free it.

Then we see that any dentry allocated for such a dmabuf file will have dma_buf_dentry_ops which in turn has dentry->d_release::dma_buf_release() which is where the actual release of the dma buffer happens taken from dentry->d_fsdata.

That whole thing calls allocate_file_pseudo() which allocates a new dentry specific to that struct file. That dentry is unhashed (no lookup) and thus isn't retained so when dput() is called and it's the last reference it's immediately followed by dentry->d_release::dma_buf_release() which wipes the dmabuf itself.

The lifetime of the dmabuf is managed via fget()/fput(). So the lifetime of the dmabuf and the lifetime of the file are almost identical afaict:

__fput()
-> f_op->release::dma_buf_file_release() // handles file specific freeing -> dput()
-> d_op->d_release::dma_buf_release() // handles dmabuf freeing

                                         // including the driver specific stuff.

If you fput() the file then the dmabuf will be freed as well immediately after it when the dput() happens in __fput() (I struggle to come up with an explanation why the freeing of the dmabuf is moved to dentry->d_release instead of f_op->release itself but that's a separate matter.).

So on the face of it without looking a little closer

static bool __must_check get_dma_buf_unless_doomed(struct dma_buf *dmabuf)

{
        return atomic_long_inc_not_zero(&dmabuf->file->f_count) != 0L;
}

looks wrong or broken. Because if dmabuf->file->f_count is 0 it implies that @dmabuf should have already been freed. So the bug would be in accessing @dmabuf. And if @dmabuf is valid then it automatically means that dmabuf->file->f_count isn't 0. So it looks like it could just use get_file().

_But_ the interesting bits are in ttm_object_device_init(). This steals the dma_buf_ops into tdev->ops. It then takes dma_buf_ops->release and stores it away into tdev->dma_buf_release. Then it overrides the dma_buf_ops->release with ttm_prime_dmabuf_release(). And that's where the very questionable magic happens.

So now let's say the dmabuf is freed because of lat fput(). We now get f_op->release::dma_buf_file_release(). Then it's followed by dput() and ultimately dentry->d_release::dma_buf_release() as mentioned above.

But now when we get:

dentry->d_release::dma_buf_release()
-> dmabuf->ops->release::ttm_prime_dmabuf_release()

instead of the original dmabuf->ops->release method that was stolen into tdev->dmabuf_release. And ttm_prime_dmabuf_release() now calls tdev->dma_buf_release() which just frees the data associated with the dmabuf not the dmabuf itself.

ttm_prime_dmabuf_release() then takes prime->mutex_lock replacing prime->dma_buf with NULL.

The same lock is taken in ttm_prime_handle_to_fd() which is picking that dmabuf from prime->dmabuf. So the interesting case is when ttm_prime_dma_buf_release() has called tdev->dmabuf_release() and but someone else maanged to grab prime->mutex_lock before ttm_prime_dma_buf_release() could grab it to NULL prime->dma_buf.

So at that point @dmabuf hasn't been freed yet and is still valid. So dereferencing prime->dma_buf is still valid and by extension dma_buf->file as their lifetimes are tied.

IOW, that should just use get_file_active() which handles that just fine.

And while that get_dma_buf_unless_doomed() thing is safe that whole code reeks of a level of complexity that's asking for trouble.

But that has zero to do with get_file() and it is absolutely not a reason to mess with it's semantics impacting every caller in the tree.

Quoted 4 lines
Quoted 3 lines

Can't you throw a CHECK_DATA_CORRUPTION() or something like that in there instead?

Quoted 7 lines
Quoted 2 lines

I'm open to suggestions, but given what's happening with struct dma_buf above, it seems like this is a state worth checking for?

No, it's really not. If you use get_file() you better know that you're already holding a valid reference that's no reason to make it suddenly fail.

But the simple question is, why are you asking dma_buf to poll a 0 f_count file? All fine if you are not.

author
#6 lore raw

PATCH 2/5 drm/vmwgfx: Do not directly manipulate file->f_count

In reply to Kees Cook

The correct helper for taking an f_count reference is get_file(). Now that it checks for 0 counts, use it and check results.

---
Cc: Zack Rusin <[email protected]>
Cc: Broadcom internal kernel review list <[email protected]>
Cc: Maarten Lankhorst <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Thomas Zimmermann <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]

---
 drivers/gpu/drm/vmwgfx/ttm_object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vmwgfx/ttm_object.c +1 -1
index 6806c05e57f6..68d8ee3020b1 100644
@@ -475,7 +475,7 @@ void ttm_object_device_release(struct ttm_object_device **p_tdev)
  */
 static bool __must_check get_dma_buf_unless_doomed(struct dma_buf *dmabuf)
 {
-	return atomic_long_inc_not_zero(&dmabuf->file->f_count) != 0L;
+	return get_file(dmabuf->file) != NULL;
 }
 
 /**
Signature · 1 line
2.34.1
author
#7 lore raw

PATCH 3/5 drm/i915: Do not directly manipulate file->f_count

In reply to Kees Cook

The correct helper for taking an f_count reference is get_file(). Use it and check results.

---
Cc: Jani Nikula <[email protected]>
Cc: Joonas Lahtinen <[email protected]>
Cc: Rodrigo Vivi <[email protected]>
Cc: Tvrtko Ursulin <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Andi Shyti <[email protected]>
Cc: Lucas De Marchi <[email protected]>
Cc: Matt Atwood <[email protected]>
Cc: Matthew Auld <[email protected]>
Cc: Nirmoy Das <[email protected]>
Cc: Jonathan Cavitt <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 drivers/gpu/drm/i915/gt/shmem_utils.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/shmem_utils.c +3 -2
index bccc3a1200bc..dc25e6dc884b 100644
@@ -38,8 +38,9 @@ struct file *shmem_create_from_object(struct drm_i915_gem_object *obj)
 	void *ptr;
 
 	if (i915_gem_object_is_shmem(obj)) {
-		file = obj->base.filp;
-		atomic_long_inc(&file->f_count);
+		file = get_file(obj->base.filp);
+		if (!file)
+			return ERR_PTR(-ESRCH);
 		return file;
 	}
 
Signature · 1 line
2.34.1
author
#8 lore raw

PATCH 4/5 refcount: Introduce refcount_long_t and APIs

In reply to Kees Cook

Duplicate the refcount_t types and APIs gain refcount_long_t. This is needed for larger counters that while currently very unlikely to overflow, still want to detect and mitigate underflow.

Generate refcount-long.h via direct string replacements. Doing macros like compat_binfmt_elf doesn't appear to work well.

---
Cc: Will Deacon <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Boqun Feng <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: Kent Overstreet <[email protected]>
Cc: Masahiro Yamada <[email protected]>
Cc: Nathan Chancellor <[email protected]>
Cc: Nicolas Schier <[email protected]>
Cc: [email protected]

---
 MAINTAINERS                    |   2 +-
 Makefile                       |  11 +-
 include/linux/refcount-impl.h  | 344 +++++++++++++++++++++++++++++++++
 include/linux/refcount.h       | 341 +-------------------------------
 include/linux/refcount_types.h |  12 ++
 lib/refcount.c                 |  17 +-
 6 files changed, 385 insertions(+), 342 deletions(-)
 create mode 100644 include/linux/refcount-impl.h
MAINTAINERS +1 -1
index 7c121493f43d..2e6c8eaab194 100644
@@ -3360,7 +3360,7 @@ S:	Maintained
 F:	Documentation/atomic_*.txt
 F:	arch/*/include/asm/atomic*.h
 F:	include/*/atomic*.h
-F:	include/linux/refcount.h
+F:	include/linux/refcount*.h
 F:	scripts/atomic/
 
 ATTO EXPRESSSAS SAS/SATA RAID SCSI DRIVER
Makefile +10 -1
index 4bef6323c47d..a4bdcd34f323 100644
@@ -1190,7 +1190,9 @@ PHONY += prepare archprepare
 
 archprepare: outputmakefile archheaders archscripts scripts include/config/kernel.release \
 	asm-generic $(version_h) include/generated/utsrelease.h \
-	include/generated/compile.h include/generated/autoconf.h remove-stale-files
+	include/generated/compile.h include/generated/autoconf.h \
+	include/generated/refcount-long.h \
+	remove-stale-files
 
 prepare0: archprepare
 	$(Q)$(MAKE) $(build)=scripts/mod
@@ -1262,6 +1264,13 @@ filechk_compile.h = $(srctree)/scripts/mkcompile_h \
 include/generated/compile.h: FORCE
 	$(call filechk,compile.h)
 
+include/generated/refcount-long.h: $(srctree)/include/linux/refcount-impl.h
+	$(Q)$(PERL) -pe 's/\b(atomic|(__)?refcount)_/\1_long_/g;	\
+			 s/ATOMIC_/ATOMIC_LONG_/g;			\
+			 s/(REFCOUNT)_(IMPL|INIT|MAX|SAT)/\1_LONG_\2/g;	\
+			 s/\b(U?)INT_/\1LONG_/g;			\
+			 s/\bint\b/long/g;' $< >$@
+
 PHONY += headerdep
 headerdep:
 	$(Q)find $(srctree)/include/ -name '*.h' | xargs --max-args 1 \
include/linux/refcount-impl.h new file +344 -0

344 lines not on this page · raw message

include/linux/refcount.h +4 -337

357 lines not on this page · raw message

include/linux/refcount_types.h +12 -0
index 162004f06edf..6ea02d6a9623 100644
@@ -16,4 +16,16 @@ typedef struct refcount_struct {
 	atomic_t refs;
 } refcount_t;
 
+/**
+ * typedef refcount_long_t - variant of atomic64_t specialized for reference counts
+ * @refs: atomic_long_t counter field
+ *
+ * The counter saturates at REFCOUNT_LONG_SATURATED and will not move once
+ * there. This avoids wrapping the counter and causing 'spurious'
+ * use-after-free bugs.
+ */
+typedef struct refcount_long_struct {
+	atomic_long_t refs;
+} refcount_long_t;
+
 #endif /* _LINUX_REFCOUNT_TYPES_H */
lib/refcount.c +14 -3
index a207a8f22b3c..201304b7d7a5 100644
@@ -10,10 +10,8 @@
 
 #define REFCOUNT_WARN(str)	WARN_ONCE(1, "refcount_t: " str ".\n")
 
-void refcount_warn_saturate(refcount_t *r, enum refcount_saturation_type t)
+static void refcount_report_saturation(enum refcount_saturation_type t)
 {
-	refcount_set(r, REFCOUNT_SATURATED);
-
 	switch (t) {
 	case REFCOUNT_ADD_NOT_ZERO_OVF:
 		REFCOUNT_WARN("saturated; leaking memory");
@@ -34,8 +32,21 @@ void refcount_warn_saturate(refcount_t *r, enum refcount_saturation_type t)
 		REFCOUNT_WARN("unknown saturation event!?");
 	}
 }
+
+void refcount_warn_saturate(refcount_t *r, enum refcount_saturation_type t)
+{
+	refcount_set(r, REFCOUNT_SATURATED);
+	refcount_report_saturation(t);
+}
 EXPORT_SYMBOL(refcount_warn_saturate);
 
+void refcount_long_warn_saturate(refcount_long_t *r, enum refcount_saturation_type t)
+{
+	refcount_long_set(r, REFCOUNT_LONG_SATURATED);
+	refcount_report_saturation(t);
+}
+EXPORT_SYMBOL(refcount_long_warn_saturate);
+
 /**
  * refcount_dec_if_one - decrement a refcount if it is 1
  * @r: the refcount
Signature · 1 line
2.34.1
#9 lore raw

Re: [PATCH 4/5] refcount: Introduce refcount_long_t and APIs

we noticed a WARNING is our boot tests. as we understand, the WARNING is not introduced by this patch, instead, just changing stats as below. however, we failed to bisect…

hi, Kees Cook,

we noticed a WARNING is our boot tests.
as we understand, the WARNING is not introduced by this patch, instead, just changing stats as below.
however, we failed to bisect "dmesg.WARNING:at_lib/refcount.c:#refcount_warn_saturate"
which shows in parent commit to capture real commit which introduced the WARNING

just made this report FYI what we observed in our boot tests.

8090de6a0536f462 93b9cd30de232c9b4e27221dff6
---------------- ---------------------------
fail:runs %reproduction fail:runs
| | |
:6 100% 6:6 dmesg.EIP:refcount_report_saturation
6:6 -100% :6 dmesg.EIP:refcount_warn_saturate
:6 100% 6:6 dmesg.WARNING:at_lib/refcount.c:#refcount_report_saturation
6:6 -100% :6 dmesg.WARNING:at_lib/refcount.c:#refcount_warn_saturate

Hello,

kernel test robot noticed "WARNING:at_lib/refcount.c:#refcount_report_saturation" on:

commit: 93b9cd30de232c9b4e27221dff6d02ac557b86eb ("[PATCH 4/5] refcount: Introduce refcount_long_t and APIs")
url: https://github.com/intel-lab-lkp/linux/commits/Kees-Cook/fs-Do-not-allow-get_file-to-resurrect-0-f_count/20240503-063542
base: https://git.kernel.org/cgit/linux/kernel/git/vfs/vfs.git vfs.all
patch link: https://lore.kernel.org/all/[email protected]/
patch subject: [PATCH 4/5] refcount: Introduce refcount_long_t and APIs

in testcase: boot

compiler: gcc-13
test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G

(please refer to attached dmesg/kmsg for entire log/backtrace)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-lkp/[email protected]

[    2.683270][    T1] ------------[ cut here ]------------
[    2.684014][    T1] refcount_t: decrement hit 0; leaking memory.
[ 2.684829][ T1] WARNING: CPU: 0 PID: 1 at lib/refcount.c:29 refcount_report_saturation (lib/refcount.c:29 (discriminator 1)) 
[    2.686080][    T1] Modules linked in:
[    2.686633][    T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.9.0-rc3-00078-g93b9cd30de23 #1 ade0d32fff89aed56247bad9c6991c6e60a975d2
[    2.688188][    T1] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
[ 2.689523][ T1] EIP: refcount_report_saturation (lib/refcount.c:29 (discriminator 1)) 
[ 2.690327][ T1] Code: c2 01 e8 92 8a b1 ff 0f 0b 58 c9 31 c0 31 d2 31 c9 c3 8d b4 26 00 00 00 00 68 ec bc f4 c1 c6 05 3e 42 4a c2 01 e8 6f 8a b1 ff <0f> 0b 5a c9 31 c0 31 d2 31 c9 c3 55 89 c1 89 d0 c7 01 00 00 00 c0
All code
========
   0:	c2 01 e8             	ret    $0xe801
   3:	92                   	xchg   %eax,%edx
   4:	8a b1 ff 0f 0b 58    	mov    0x580b0fff(%rcx),%dh
   a:	c9                   	leave
   b:	31 c0                	xor    %eax,%eax
   d:	31 d2                	xor    %edx,%edx
   f:	31 c9                	xor    %ecx,%ecx
  11:	c3                   	ret
  12:	8d b4 26 00 00 00 00 	lea    0x0(%rsi,%riz,1),%esi
  19:	68 ec bc f4 c1       	push   $0xffffffffc1f4bcec
  1e:	c6 05 3e 42 4a c2 01 	movb   $0x1,-0x3db5bdc2(%rip)        # 0xffffffffc24a4263
  25:	e8 6f 8a b1 ff       	call   0xffffffffffb18a99
  2a:*	0f 0b                	ud2		<-- trapping instruction
  2c:	5a                   	pop    %rdx
  2d:	c9                   	leave
  2e:	31 c0                	xor    %eax,%eax
  30:	31 d2                	xor    %edx,%edx
  32:	31 c9                	xor    %ecx,%ecx
  34:	c3                   	ret
  35:	55                   	push   %rbp
  36:	89 c1                	mov    %eax,%ecx
  38:	89 d0                	mov    %edx,%eax
  3a:	c7 01 00 00 00 c0    	movl   $0xc0000000,(%rcx)

Code starting with the faulting instruction
===========================================

   0:	0f 0b                	ud2
   2:	5a                   	pop    %rdx
   3:	c9                   	leave
   4:	31 c0                	xor    %eax,%eax
   6:	31 d2                	xor    %edx,%edx
   8:	31 c9                	xor    %ecx,%ecx
   a:	c3                   	ret
   b:	55                   	push   %rbp
   c:	89 c1                	mov    %eax,%ecx
   e:	89 d0                	mov    %edx,%eax
  10:	c7 01 00 00 00 c0    	movl   $0xc0000000,(%rcx)
[    2.692770][    T1] EAX: 00000000 EBX: e19ee0c4 ECX: 00000000 EDX: 00000000
[    2.693685][    T1] ESI: e19ee0c0 EDI: c37ad880 EBP: c3767dd0 ESP: c3767dcc
[    2.694597][    T1] DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068 EFLAGS: 00010246
[    2.695638][    T1] CR0: 80050033 CR2: ffcb2000 CR3: 02723000 CR4: 00040690
[    2.696557][    T1] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[    2.697464][    T1] DR6: fffe0ff0 DR7: 00000400
[    2.698106][    T1] Call Trace:
[ 2.698586][ T1] ? show_regs (arch/x86/kernel/dumpstack.c:479) 
[ 2.699197][ T1] ? refcount_report_saturation (lib/refcount.c:29 (discriminator 1)) 
[ 2.699975][ T1] ? __warn (kernel/panic.c:694) 
[ 2.700547][ T1] ? refcount_report_saturation (lib/refcount.c:29 (discriminator 1)) 
[ 2.701322][ T1] ? report_bug (lib/bug.c:201 lib/bug.c:219) 
[ 2.701960][ T1] ? exc_overflow (arch/x86/kernel/traps.c:252) 
[ 2.702584][ T1] ? handle_bug (arch/x86/kernel/traps.c:218) 
[ 2.703208][ T1] ? exc_invalid_op (arch/x86/kernel/traps.c:260 (discriminator 1)) 
[ 2.703850][ T1] ? handle_exception (arch/x86/entry/entry_32.S:1047) 
[ 2.704538][ T1] ? devkmsg_open (kernel/printk/printk.c:596 kernel/printk/printk.c:615 kernel/printk/printk.c:919) 
[ 2.705173][ T1] ? exc_overflow (arch/x86/kernel/traps.c:252) 
[ 2.705798][ T1] ? refcount_report_saturation (lib/refcount.c:29 (discriminator 1)) 
[ 2.706578][ T1] ? exc_overflow (arch/x86/kernel/traps.c:252) 
[ 2.707215][ T1] ? refcount_report_saturation (lib/refcount.c:29 (discriminator 1)) 
[ 2.707994][ T1] refcount_warn_saturate (lib/refcount.c:40) 
[ 2.708693][ T1] __reset_page_owner (include/linux/refcount-impl.h:318 include/linux/refcount-impl.h:333 mm/page_owner.c:228 mm/page_owner.c:266) 
[ 2.709377][ T1] __free_pages_ok (include/linux/mmzone.h:1100 mm/page_alloc.c:1144 mm/page_alloc.c:1270) 
[ 2.710036][ T1] make_alloc_exact (mm/page_alloc.c:4828 (discriminator 1)) 
[ 2.710687][ T1] alloc_pages_exact (mm/page_alloc.c:4859) 
[ 2.711357][ T1] alloc_large_system_hash (mm/mm_init.c:2531) 
[ 2.712095][ T1] inet_hashinfo2_init (net/ipv4/inet_hashtables.c:1193 (discriminator 1)) 
[ 2.712770][ T1] tcp_init (net/ipv4/tcp.c:4714) 
[ 2.713348][ T1] inet_init (net/ipv4/af_inet.c:2032) 
[ 2.713949][ T1] ? ipv4_offload_init (net/ipv4/af_inet.c:1942) 
[ 2.714640][ T1] do_one_initcall (init/main.c:1238) 
[ 2.715294][ T1] ? rdinit_setup (init/main.c:1286) 
[ 2.715927][ T1] do_initcalls (init/main.c:1299 (discriminator 1) init/main.c:1316 (discriminator 1)) 
[ 2.716542][ T1] ? rest_init (init/main.c:1429) 
[ 2.717157][ T1] kernel_init_freeable (init/main.c:1550) 
[ 2.717852][ T1] kernel_init (init/main.c:1439) 
[ 2.718455][ T1] ret_from_fork (arch/x86/kernel/process.c:153) 
[ 2.719085][ T1] ? rest_init (init/main.c:1429) 
[ 2.719700][ T1] ret_from_fork_asm (arch/x86/entry/entry_32.S:737) 
[ 2.720348][ T1] entry_INT80_32 (arch/x86/entry/entry_32.S:944) 
[    2.720999][    T1] irq event stamp: 263893
[ 2.721599][ T1] hardirqs last enabled at (263903): console_unlock (arch/x86/include/asm/irqflags.h:26 arch/x86/include/asm/irqflags.h:67 arch/x86/include/asm/irqflags.h:127 kernel/printk/printk.c:341 kernel/printk/printk.c:2731 kernel/printk/printk.c:3050) 
[ 2.722782][ T1] hardirqs last disabled at (263912): console_unlock (kernel/printk/printk.c:339 (discriminator 3) kernel/printk/printk.c:2731 (discriminator 3) kernel/printk/printk.c:3050 (discriminator 3)) 
[ 2.723947][ T1] softirqs last enabled at (263164): release_sock (net/core/sock.c:3560) 
[ 2.725080][ T1] softirqs last disabled at (263162): release_sock (net/core/sock.c:3549) 
[    2.726210][    T1] ---[ end trace 0000000000000000 ]---

The kernel config and materials to reproduce are available at:
https://download.01.org/0day-ci/archive/20240506/[email protected]

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
author
#10 lore raw

PATCH 5/5 fs: Convert struct file::f_count to refcount_long_t

In reply to Kees Cook

Underflow of f_count needs to be more carefully detected than it currently is. The results of get_file() should be checked, but the first step is detection. Redefine f_count from atomic_long_t to refcount_long_t.

---
Cc: Christian Brauner <[email protected]>
Cc: Alexander Viro <[email protected]>
Cc: Jan Kara <[email protected]>
Cc: [email protected]

---
 fs/file.c          | 4 ++--
 fs/file_table.c    | 6 +++---
 include/linux/fs.h | 6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)
fs/file.c +2 -2
index 3b683b9101d8..570424dd634b 100644
@@ -865,7 +865,7 @@ static struct file *__get_file_rcu(struct file __rcu **f)
 	if (!file)
 		return NULL;
 
-	if (unlikely(!atomic_long_inc_not_zero(&file->f_count)))
+	if (unlikely(!refcount_long_inc_not_zero(&file->f_count)))
 		return ERR_PTR(-EAGAIN);
 
 	file_reloaded = rcu_dereference_raw(*f);
@@ -987,7 +987,7 @@ static inline struct file *__fget_files_rcu(struct files_struct *files,
 		 * barrier. We only really need an 'acquire' one to
 		 * protect the loads below, but we don't have that.
 		 */
-		if (unlikely(!atomic_long_inc_not_zero(&file->f_count)))
+		if (unlikely(!refcount_long_inc_not_zero(&file->f_count)))
 			continue;
 
 		/*
fs/file_table.c +3 -3
index 4f03beed4737..f29e7b94bca1 100644
@@ -167,7 +167,7 @@ static int init_file(struct file *f, int flags, const struct cred *cred)
 	 * fget-rcu pattern users need to be able to handle spurious
 	 * refcount bumps we should reinitialize the reused file first.
 	 */
-	atomic_long_set(&f->f_count, 1);
+	refcount_long_set(&f->f_count, 1);
 	return 0;
 }
 
@@ -470,7 +470,7 @@ static DECLARE_DELAYED_WORK(delayed_fput_work, delayed_fput);
 
 void fput(struct file *file)
 {
-	if (atomic_long_dec_and_test(&file->f_count)) {
+	if (refcount_long_dec_and_test(&file->f_count)) {
 		struct task_struct *task = current;
 
 		if (unlikely(!(file->f_mode & (FMODE_BACKING | FMODE_OPENED)))) {
@@ -503,7 +503,7 @@ void fput(struct file *file)
  */
 void __fput_sync(struct file *file)
 {
-	if (atomic_long_dec_and_test(&file->f_count))
+	if (refcount_long_dec_and_test(&file->f_count))
 		__fput(file);
 }
 
include/linux/fs.h +3 -3
index 210bbbfe9b83..b8f6cce7c39d 100644
@@ -1001,7 +1001,7 @@ struct file {
 	 */
 	spinlock_t		f_lock;
 	fmode_t			f_mode;
-	atomic_long_t		f_count;
+	refcount_long_t		f_count;
 	struct mutex		f_pos_lock;
 	loff_t			f_pos;
 	unsigned int		f_flags;
@@ -1038,7 +1038,7 @@ struct file_handle {
 
 static inline struct file *get_file(struct file *f)
 {
-	if (unlikely(!atomic_long_inc_not_zero(&f->f_count)))
+	if (unlikely(!refcount_long_inc_not_zero(&f->f_count)))
 		return NULL;
 	return f;
 }
@@ -1046,7 +1046,7 @@ static inline struct file *get_file(struct file *f)
 struct file *get_file_rcu(struct file __rcu **f);
 struct file *get_file_active(struct file **f);
 
-#define file_count(x)	atomic_long_read(&(x)->f_count)
+#define file_count(x)	refcount_long_read(&(x)->f_count)
 
 #define	MAX_NON_LFS	((1UL<<31) - 1)
 
Signature · 1 line
2.34.1
maintainer
#11 lore raw

Re: [PATCH 5/5] fs: Convert struct file::f_count to refcount_long_t

Quoted 4 lines · Kees Cook

Underflow of f_count needs to be more carefully detected than it currently is. The results of get_file() should be checked, but the first step is detection. Redefine f_count from atomic_long_t to refcount_long_t.

It is used on fairly hot paths. What's more, it's not
at all obvious what the hell would right semantics be.

author
#12 lore raw

Re: [PATCH 5/5] fs: Convert struct file::f_count to refcount_long_t

Quoted 8 lines · Al Viro
Quoted 4 lines · Kees Cook

Underflow of f_count needs to be more carefully detected than it currently is. The results of get_file() should be checked, but the first step is detection. Redefine f_count from atomic_long_t to refcount_long_t.

It is used on fairly hot paths. What's more, it's not
at all obvious what the hell would right semantics be.

I think we've put performance concerns between refcount_t and atomic_t to rest long ago. If there is a real workload where it's a problem, let's find it! :)

As for semantics, what do you mean? Detecting dec-below-zero means we catch underflow, and detected inc-from-zero means we catch resurrection attempts. In both cases we avoid double-free, but we have already lost to a potential dangling reference to a freed struct file. But just letting f_count go bad seems dangerous.

Signature · 1 line
Kees Cook
maintainer
#13 lore raw

Re: [PATCH 5/5] fs: Convert struct file::f_count to refcount_long_t

Quoted 5 lines · Kees Cook

As for semantics, what do you mean? Detecting dec-below-zero means we catch underflow, and detected inc-from-zero means we catch resurrection attempts. In both cases we avoid double-free, but we have already lost to a potential dangling reference to a freed struct file. But just letting f_count go bad seems dangerous.

Detected inc-from-zero can also mean an RCU lookup detecting a descriptor in the middle of getting closed. And it's more subtle than that, actually, thanks to SLAB_TYPESAFE_BY_RCU for struct file.

author
#14 lore raw

Re: [PATCH 5/5] fs: Convert struct file::f_count to refcount_long_t

Quoted 11 lines · Al Viro
Quoted 5 lines · Kees Cook

As for semantics, what do you mean? Detecting dec-below-zero means we catch underflow, and detected inc-from-zero means we catch resurrection attempts. In both cases we avoid double-free, but we have already lost to a potential dangling reference to a freed struct file. But just letting f_count go bad seems dangerous.

Detected inc-from-zero can also mean an RCU lookup detecting a descriptor in the middle of getting closed. And it's more subtle than that, actually, thanks to SLAB_TYPESAFE_BY_RCU for struct file.

But isn't that already handled by __get_file_rcu()? i.e. shouldn't it be impossible for a simple get_file() to ever see a 0 f_count under normal conditions?

Signature · 1 line
Kees Cook
maintainer
#15 lore raw

Re: [PATCH 5/5] fs: Convert struct file::f_count to refcount_long_t

Quoted 9 lines · Kees Cook
Quoted 8 lines · Al Viro
Quoted 5 lines · Kees Cook

As for semantics, what do you mean? Detecting dec-below-zero means we catch underflow, and detected inc-from-zero means we catch resurrection attempts. In both cases we avoid double-free, but we have already lost to a potential dangling reference to a freed struct file. But just letting f_count go bad seems dangerous.

Quoted 7 lines
Quoted 3 lines

Detected inc-from-zero can also mean an RCU lookup detecting a descriptor in the middle of getting closed. And it's more subtle than that, actually, thanks to SLAB_TYPESAFE_BY_RCU for struct file.

But isn't that already handled by __get_file_rcu()? i.e. shouldn't it be impossible for a simple get_file() to ever see a 0 f_count under normal conditions?

For get_file() it is impossible. The comment about semantics had been about the sane ways to recover if such crap gets detected.

__get_file_rcu() is a separate story - consider the comment in there:
* atomic_long_inc_not_zero() above provided a full memory
* barrier when we acquired a reference.
*
* This is paired with the write barrier from assigning to the
* __rcu protected file pointer so that if that pointer still
* matches the current file, we know we have successfully
* acquired a reference to the right file.

and IIRC, refcount_t is weaker wrt barriers.

author
#16 lore raw

Re: [PATCH 5/5] fs: Convert struct file::f_count to refcount_long_t

Quoted 30 lines · Al Viro
Quoted 9 lines · Kees Cook
Quoted 8 lines · Al Viro
Quoted 5 lines · Kees Cook

As for semantics, what do you mean? Detecting dec-below-zero means we catch underflow, and detected inc-from-zero means we catch resurrection attempts. In both cases we avoid double-free, but we have already lost to a potential dangling reference to a freed struct file. But just letting f_count go bad seems dangerous.

Quoted 7 lines
Quoted 3 lines

Detected inc-from-zero can also mean an RCU lookup detecting a descriptor in the middle of getting closed. And it's more subtle than that, actually, thanks to SLAB_TYPESAFE_BY_RCU for struct file.

But isn't that already handled by __get_file_rcu()? i.e. shouldn't it be impossible for a simple get_file() to ever see a 0 f_count under normal conditions?

For get_file() it is impossible. The comment about semantics had been about the sane ways to recover if such crap gets detected.

__get_file_rcu() is a separate story - consider the comment in there:
* atomic_long_inc_not_zero() above provided a full memory
* barrier when we acquired a reference.
*
* This is paired with the write barrier from assigning to the
* __rcu protected file pointer so that if that pointer still
* matches the current file, we know we have successfully
* acquired a reference to the right file.

Quoted 1 line

and IIRC, refcount_t is weaker wrt barriers.

I think that was also fixed for refcount_t. I'll need to go dig out the commit...

But anyway, there needs to be a general "oops I hit 0"-aware form of get_file(), and it seems like it should just be get_file() itself...

Signature · 1 line
Kees Cook
maintainer
#17 lore raw

Re: [PATCH 5/5] fs: Convert struct file::f_count to refcount_long_t

Quoted 2 lines · Kees Cook

But anyway, there needs to be a general "oops I hit 0"-aware form of get_file(), and it seems like it should just be get_file() itself...

... which brings back the question of what's the sane damage mitigation for that. Adding arseloads of never-exercised failure exits is generally a bad idea - it's asking for bitrot and making the thing harder to review in future.

author
#18 lore raw

Re: [PATCH 5/5] fs: Convert struct file::f_count to refcount_long_t

Quoted 9 lines · Al Viro
Quoted 2 lines · Kees Cook

But anyway, there needs to be a general "oops I hit 0"-aware form of get_file(), and it seems like it should just be get_file() itself...

... which brings back the question of what's the sane damage mitigation for that. Adding arseloads of never-exercised failure exits is generally a bad idea - it's asking for bitrot and making the thing harder to review in future.

Linus seems to prefer best-effort error recovery to sprinkling BUG()s around. But if that's really the solution, then how about get_file() switching to to use inc_not_zero and BUG on 0?

Signature · 1 line
Kees Cook
#19 lore raw

Re: [PATCH 5/5] fs: Convert struct file::f_count to refcount_long_t

Quoted 6 lines · Kees Cook
Quoted 5 lines · Al Viro
Quoted 2 lines · Kees Cook

But anyway, there needs to be a general "oops I hit 0"-aware form of get_file(), and it seems like it should just be get_file() itself...

Quoted 8 lines
Quoted 4 lines

... which brings back the question of what's the sane damage mitigation for that. Adding arseloads of never-exercised failure exits is generally a bad idea - it's asking for bitrot and making the thing harder to review in future.

Linus seems to prefer best-effort error recovery to sprinkling BUG()s around. But if that's really the solution, then how about get_file() switching to to use inc_not_zero and BUG on 0?

Making get_file() return an error is not an option. For all current callers that's pointless churn for a condition that's not supposed to happen at all.

Additionally, iirc *_inc_not_zero() variants are implemented with try_cmpxchg() which scales poorly under contention for a condition that's not supposed to happen.

maintainer
#20 lore raw

Re: [PATCH 5/5] fs: Convert struct file::f_count to refcount_long_t

Quoted 16 lines · Christian Brauner
Quoted 6 lines · Kees Cook
Quoted 5 lines · Al Viro
Quoted 2 lines · Kees Cook

But anyway, there needs to be a general "oops I hit 0"-aware form of get_file(), and it seems like it should just be get_file() itself...

Quoted 8 lines
Quoted 4 lines

... which brings back the question of what's the sane damage mitigation for that. Adding arseloads of never-exercised failure exits is generally a bad idea - it's asking for bitrot and making the thing harder to review in future.

Linus seems to prefer best-effort error recovery to sprinkling BUG()s around. But if that's really the solution, then how about get_file() switching to to use inc_not_zero and BUG on 0?

Quoted 7 lines

Making get_file() return an error is not an option. For all current callers that's pointless churn for a condition that's not supposed to happen at all.

Additionally, iirc *_inc_not_zero() variants are implemented with try_cmpxchg() which scales poorly under contention for a condition that's not supposed to happen.

	unsigned long old = atomic_long_fetch_inc_relaxed(&f->f_count);
	WARN_ON(!old);

Or somesuch might be an option?

#21 lore raw

Re: [PATCH 5/5] fs: Convert struct file::f_count to refcount_long_t

Quoted 21 lines · Peter Zijlstra
Quoted 20 lines · Christian Brauner
Quoted 6 lines · Kees Cook
Quoted 5 lines · Al Viro
Quoted 2 lines · Kees Cook

But anyway, there needs to be a general "oops I hit 0"-aware form of get_file(), and it seems like it should just be get_file() itself...

Quoted 8 lines
Quoted 4 lines

... which brings back the question of what's the sane damage mitigation for that. Adding arseloads of never-exercised failure exits is generally a bad idea - it's asking for bitrot and making the thing harder to review in future.

Linus seems to prefer best-effort error recovery to sprinkling BUG()s around. But if that's really the solution, then how about get_file() switching to to use inc_not_zero and BUG on 0?

Making get_file() return an error is not an option. For all current callers that's pointless churn for a condition that's not supposed to happen at all.

Quoted 8 lines
Quoted 3 lines

Additionally, iirc *_inc_not_zero() variants are implemented with try_cmpxchg() which scales poorly under contention for a condition that's not supposed to happen.

	unsigned long old = atomic_long_fetch_inc_relaxed(&f->f_count);
	WARN_ON(!old);

Or somesuch might be an option?

Yeah, I'd be fine with that. WARN_ON() (or WARN_ON_ONCE() even?) and then people can do their panic_on_warn stuff to get the BUG_ON() behavior if they want to.

#22 lore raw

✗ Fi.CI.CHECKPATCH: warning for fs: Do not allow get_file() to resurrect 0 f_count

In reply to Kees Cook
== Series Details ==

== Series Details ==

Series: fs: Do not allow get_file() to resurrect 0 f_count
URL : https://patchwork.freedesktop.org/series/133157/
State : warning

== Summary ==

Error: dim checkpatch failed
05a74d02542d fs: Do not allow get_file() to resurrect 0 f_count cb506a379959 drm/vmwgfx: Do not directly manipulate file->f_count -:20: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "get_file" #20: FILE: drivers/gpu/drm/vmwgfx/ttm_object.c:474:
+ return get_file(dmabuf->file) != NULL;

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
82672373ae1d drm/i915: Do not directly manipulate file->f_count
1f5237fd1d94 refcount: Introduce refcount_long_t and APIs
-:58: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #58:
new file mode 100644

-:398: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #398: FILE: include/linux/refcount-impl.h:336:
+extern __must_check bool refcount_dec_if_one(refcount_t *r);

-:399: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #399: FILE: include/linux/refcount-impl.h:337:
+extern __must_check bool refcount_dec_not_one(refcount_t *r);

-:400: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#400: FILE: include/linux/refcount-impl.h:338:
+extern __must_check bool refcount_dec_and_mutex_lock(refcount_t *r, struct mutex *lock) __cond_acquires(lock);

-:400: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#400: FILE: include/linux/refcount-impl.h:338:
+extern __must_check bool refcount_dec_and_mutex_lock(refcount_t *r, struct mutex *lock) __cond_acquires(lock);

-:401: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#401: FILE: include/linux/refcount-impl.h:339:
+extern __must_check bool refcount_dec_and_lock(refcount_t *r, spinlock_t *lock) __cond_acquires(lock);

-:401: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#401: FILE: include/linux/refcount-impl.h:339:
+extern __must_check bool refcount_dec_and_lock(refcount_t *r, spinlock_t *lock) __cond_acquires(lock);

-:402: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #402: FILE: include/linux/refcount-impl.h:340:
+extern __must_check bool refcount_dec_and_lock_irqsave(refcount_t *r,

-:787: WARNING:NEW_TYPEDEFS: do not add new typedefs #787: FILE: include/linux/refcount_types.h:27:
+typedef struct refcount_long_struct {

total: 0 errors, 4 warnings, 5 checks, 780 lines checked 7c03be650afd fs: Convert struct file::f_count to refcount_long_t

#24 lore raw

✓ Fi.CI.BAT: success for fs: Do not allow get_file() to resurrect 0 f_count

In reply to Kees Cook
== Series Details ==

== Series Details ==

Series: fs: Do not allow get_file() to resurrect 0 f_count
URL : https://patchwork.freedesktop.org/series/133157/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_14698 -> Patchwork_133157v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/index.html

Participating hosts (40 -> 30)
------------------------------

Additional (2): fi-rkl-11600 bat-arls-1
Missing (12): fi-kbl-7567u bat-dg1-7 bat-kbl-2 fi-bsw-n3050 fi-apl-guc fi-snb-2520m fi-glk-j4005 fi-kbl-8809g fi-cfl-8109u fi-elk-e7500 bat-dg2-11 bat-arls-3

Known issues
------------

Here are the changes found in Patchwork_133157v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@debugfs_test@basic-hwmon:
- fi-rkl-11600: NOTRUN -> [SKIP][1] ([i915#9318])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/fi-rkl-11600/igt@[email protected]
- bat-arls-1: NOTRUN -> [SKIP][2] ([i915#9318])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/fi-rkl-11600/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#4613]) +3 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/fi-rkl-11600/igt@[email protected]

* igt@gem_lmem_swapping@random-engines:
- bat-arls-1: NOTRUN -> [SKIP][5] ([i915#10213]) +3 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@gem_mmap@basic:
- bat-arls-1: NOTRUN -> [SKIP][6] ([i915#4083])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@gem_render_tiled_blits@basic:
- bat-arls-1: NOTRUN -> [SKIP][7] ([i915#10197] / [i915#10211] / [i915#4079])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@gem_tiled_blits@basic:
- bat-arls-1: NOTRUN -> [SKIP][8] ([i915#10196] / [i915#4077]) +2 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][9] ([i915#3282])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html
- bat-arls-1: NOTRUN -> [SKIP][10] ([i915#10206] / [i915#4079])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@gem_tiled_pread_basic.html

* igt@i915_pm_rps@basic-api:
- bat-arls-1: NOTRUN -> [SKIP][11] ([i915#10209])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@kms_addfb_basic@addfb25-x-tiled-legacy:
- bat-arls-1: NOTRUN -> [SKIP][12] ([i915#10200]) +9 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-rkl-11600: NOTRUN -> [SKIP][13] ([i915#4103]) +1 other test skip
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/fi-rkl-11600/igt@[email protected]
- bat-arls-1: NOTRUN -> [SKIP][14] ([i915#10202]) +1 other test skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@kms_dsc@dsc-basic:
- fi-rkl-11600: NOTRUN -> [SKIP][15] ([i915#3555] / [i915#3840])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/fi-rkl-11600/igt@[email protected]
- bat-arls-1: NOTRUN -> [SKIP][16] ([i915#9886])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][17]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/fi-rkl-11600/igt@[email protected]
- bat-arls-1: NOTRUN -> [SKIP][18] ([i915#10207])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@kms_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][19] ([i915#5354])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/fi-rkl-11600/igt@[email protected]
- bat-arls-1: NOTRUN -> [SKIP][20] ([i915#9812])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@kms_psr@psr-primary-mmap-gtt:
- bat-arls-1: NOTRUN -> [SKIP][21] ([i915#9732]) +3 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@kms_psr@psr-sprite-plane-onoff:
- fi-rkl-11600: NOTRUN -> [SKIP][22] ([i915#1072] / [i915#9732]) +3 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/fi-rkl-11600/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][23] ([i915#3555])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/fi-rkl-11600/igt@[email protected]
- bat-arls-1: NOTRUN -> [SKIP][24] ([i915#10208] / [i915#8809])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-arls-1: NOTRUN -> [SKIP][25] ([i915#10212] / [i915#3708])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@prime_vgem@basic-gtt:
- bat-arls-1: NOTRUN -> [SKIP][26] ([i915#10196] / [i915#3708] / [i915#4077]) +1 other test skip
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][27] ([i915#3291] / [i915#3708]) +2 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/fi-rkl-11600/igt@[email protected]
- bat-arls-1: NOTRUN -> [SKIP][28] ([i915#10214] / [i915#3708])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

* igt@prime_vgem@basic-write:
- bat-arls-1: NOTRUN -> [SKIP][29] ([i915#10216] / [i915#3708])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-arls-1/igt@[email protected]

#### Possible fixes ####

* igt@gem_lmem_swapping@basic@lmem0:
- bat-dg2-9: [FAIL][30] ([i915#10378]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/bat-dg2-9/igt@gem_lmem_swapping@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-dg2-9/igt@gem_lmem_swapping@[email protected]

* igt@i915_pm_rpm@module-reload:
- {bat-mtlp-9}: [CRASH][32] ([i915#10911]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/bat-mtlp-9/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/bat-mtlp-9/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#10196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10196
[i915#10197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10197
[i915#10200]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10200
[i915#10202]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10202
[i915#10206]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10206
[i915#10207]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10207
[i915#10208]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10208
[i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
[i915#10211]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10211
[i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
[i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
[i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
[i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
[i915#10378]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10378
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#10911]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10911
[i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
[i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9812
[i915#9886]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9886

Build changes
-------------

* Linux: CI_DRM_14698 -> Patchwork_133157v1

CI-20190529: 20190529
CI_DRM_14698: 93a8e4035f726bffeadef90df0971c12b674fe7e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7828: 68a055ff91b91dadb01d9501cd8670f654b5b952 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_133157v1: 93a8e4035f726bffeadef90df0971c12b674fe7e @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/index.html

#25 lore raw

✓ Fi.CI.IGT: success for fs: Do not allow get_file() to resurrect 0 f_count

In reply to Kees Cook
== Series Details ==

== Series Details ==

Series: fs: Do not allow get_file() to resurrect 0 f_count
URL : https://patchwork.freedesktop.org/series/133157/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_14698_full -> Patchwork_133157v1_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (9 -> 9)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in Patchwork_133157v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@api_intel_bb@object-reloc-keep-cache:
- shard-dg1: NOTRUN -> [SKIP][1] ([i915#8411])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@device_reset@unbind-cold-reset-rebind:
- shard-dg1: NOTRUN -> [SKIP][2] ([i915#7701])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@drm_fdinfo@busy-check-all@bcs0:
- shard-dg1: NOTRUN -> [SKIP][3] ([i915#8414]) +15 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@drm_fdinfo@[email protected]

* igt@drm_fdinfo@busy-check-all@ccs0:
- shard-mtlp: NOTRUN -> [SKIP][4] ([i915#8414]) +11 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@drm_fdinfo@[email protected]

* igt@drm_fdinfo@virtual-busy-idle:
- shard-dg2: NOTRUN -> [SKIP][5] ([i915#8414])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@gem_ccs@block-copy-compressed:
- shard-dg1: NOTRUN -> [SKIP][6] ([i915#3555] / [i915#9323]) +1 other test skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@gem_compute@compute-square:
- shard-mtlp: NOTRUN -> [SKIP][7] ([i915#9310])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@gem_create@create-ext-set-pat:
- shard-dg1: NOTRUN -> [SKIP][8] ([i915#8562])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@[email protected]

* igt@gem_ctx_persistence@heartbeat-close:
- shard-dg1: NOTRUN -> [SKIP][9] ([i915#8555]) +1 other test skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@gem_ctx_persistence@heartbeat-hostile:
- shard-mtlp: NOTRUN -> [SKIP][10] ([i915#8555])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@gem_ctx_persistence@processes:
- shard-snb: NOTRUN -> [SKIP][11] ([i915#1099])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-snb4/igt@[email protected]

* igt@gem_ctx_sseu@invalid-args:
- shard-mtlp: NOTRUN -> [SKIP][12] ([i915#280])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-dg1: NOTRUN -> [FAIL][13] ([i915#5784])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@gem_exec_balancer@bonded-dual:
- shard-dg1: NOTRUN -> [SKIP][14] ([i915#4771])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@gem_exec_balancer@bonded-semaphore:
- shard-dg1: NOTRUN -> [SKIP][15] ([i915#4812]) +3 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@gem_exec_capture@capture@vecs0-lmem0:
- shard-dg1: NOTRUN -> [FAIL][16] ([i915#10386]) +1 other test fail
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@gem_exec_capture@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglu: [PASS][17] -> [FAIL][18] ([i915#2842]) +1 other test fail
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-tglu-2/igt@gem_exec_fair@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-tglu-3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-solo:
- shard-mtlp: NOTRUN -> [SKIP][19] ([i915#4473])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: NOTRUN -> [FAIL][20] ([i915#2842])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-glk1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-rkl: [PASS][21] -> [FAIL][22] ([i915#2842])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-rkl-3/igt@gem_exec_fair@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-rkl-3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-sync:
- shard-dg2: NOTRUN -> [SKIP][23] ([i915#3539])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@gem_exec_fair@basic-throttle:
- shard-dg1: NOTRUN -> [SKIP][24] ([i915#3539])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@gem_exec_flush@basic-uc-rw-default:
- shard-dg1: NOTRUN -> [SKIP][25] ([i915#3539] / [i915#4852]) +6 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@gem_exec_flush@basic-wb-ro-default:
- shard-dg2: NOTRUN -> [SKIP][26] ([i915#3539] / [i915#4852])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@gem_exec_reloc@basic-gtt:
- shard-dg2: NOTRUN -> [SKIP][27] ([i915#3281]) +3 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@gem_exec_reloc@basic-wc-read:
- shard-dg1: NOTRUN -> [SKIP][28] ([i915#3281]) +17 other tests skip
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@gem_exec_reloc@basic-write-wc-noreloc:
- shard-mtlp: NOTRUN -> [SKIP][29] ([i915#3281]) +6 other tests skip
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@gem_exec_schedule@thriceslice:
- shard-snb: NOTRUN -> [SKIP][30] +46 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-snb4/igt@[email protected]

* igt@gem_fenced_exec_thrash@no-spare-fences-busy:
- shard-dg1: NOTRUN -> [SKIP][31] ([i915#4860]) +4 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@[email protected]

* igt@gem_fenced_exec_thrash@no-spare-fences-interruptible:
- shard-mtlp: NOTRUN -> [SKIP][32] ([i915#4860]) +3 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@gem_fenced_exec_thrash@too-many-fences:
- shard-dg2: NOTRUN -> [SKIP][33] ([i915#4860])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@gem_lmem_swapping@heavy-multi@lmem0:
- shard-dg1: NOTRUN -> [FAIL][34] ([i915#10378])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@parallel-random:
- shard-mtlp: NOTRUN -> [SKIP][35] ([i915#4613])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-verify-ccs@lmem0:
- shard-dg1: NOTRUN -> [SKIP][36] ([i915#4423] / [i915#4565])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@random:
- shard-glk: NOTRUN -> [SKIP][37] ([i915#4613]) +2 other tests skip
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-glk4/igt@[email protected]

* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: [PASS][38] -> [TIMEOUT][39] ([i915#5493])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg2-10/igt@gem_lmem_swapping@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-10/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@verify-random-ccs@lmem0:
- shard-dg1: NOTRUN -> [SKIP][40] ([i915#4565]) +2 other tests skip
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@gem_lmem_swapping@[email protected]

* igt@gem_mmap@bad-offset:
- shard-mtlp: NOTRUN -> [SKIP][41] ([i915#4083])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@gem_mmap_gtt@coherency:
- shard-dg1: NOTRUN -> [SKIP][42] ([i915#4077]) +17 other tests skip
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-dg2: NOTRUN -> [SKIP][43] ([i915#4077]) +2 other tests skip
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@gem_mmap_gtt@fault-concurrent:
- shard-mtlp: NOTRUN -> [SKIP][44] ([i915#4077]) +3 other tests skip
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@gem_mmap_wc@write:
- shard-dg2: NOTRUN -> [SKIP][45] ([i915#4083]) +2 other tests skip
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@gem_mmap_wc@write-read:
- shard-dg1: NOTRUN -> [SKIP][46] ([i915#4083]) +8 other tests skip
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-dg1: NOTRUN -> [SKIP][47] ([i915#3282]) +5 other tests skip
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]
- shard-snb: NOTRUN -> [WARN][48] ([i915#2658])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-snb4/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][49] ([i915#3282])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@gem_pread@uncached:
- shard-dg2: NOTRUN -> [SKIP][50] ([i915#3282])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@gem_pwrite@basic-exhaustion:
- shard-glk: NOTRUN -> [WARN][51] ([i915#2658])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-glk1/igt@[email protected]

* igt@gem_pxp@create-valid-protected-context:
- shard-dg2: NOTRUN -> [SKIP][52] ([i915#4270]) +1 other test skip
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@gem_pxp@verify-pxp-key-change-after-suspend-resume:
- shard-dg1: NOTRUN -> [SKIP][53] ([i915#4270]) +5 other tests skip
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-ccs:
- shard-mtlp: NOTRUN -> [SKIP][54] ([i915#8428]) +1 other test skip
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#5190] / [i915#8428])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@gem_softpin@evict-snoop-interruptible:
- shard-mtlp: NOTRUN -> [SKIP][56] ([i915#4885])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@gem_tiled_pread_pwrite:
- shard-dg1: NOTRUN -> [SKIP][57] ([i915#4079]) +1 other test skip
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@gem_tiled_pread_pwrite.html
- shard-mtlp: NOTRUN -> [SKIP][58] ([i915#4079])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@gem_tiled_pread_pwrite.html

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-dg1: NOTRUN -> [SKIP][59] ([i915#3297] / [i915#4880]) +1 other test skip
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@gem_userptr_blits@mmap-offset-banned@gtt:
- shard-mtlp: NOTRUN -> [SKIP][60] ([i915#3297])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@gem_userptr_blits@[email protected]

* igt@gem_userptr_blits@sd-probe:
- shard-dg1: NOTRUN -> [SKIP][61] ([i915#3297] / [i915#4958])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-dg1: NOTRUN -> [SKIP][62] ([i915#3297]) +1 other test skip
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-mtlp: NOTRUN -> [SKIP][63] ([i915#2856]) +2 other tests skip
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@gen9_exec_parse@bb-start-cmd:
- shard-dg1: NOTRUN -> [SKIP][64] ([i915#2527]) +6 other tests skip
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@i915_fb_tiling:
- shard-mtlp: NOTRUN -> [SKIP][65] ([i915#4881])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@i915_fb_tiling.html
- shard-dg1: NOTRUN -> [SKIP][66] ([i915#4881])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@i915_fb_tiling.html

* igt@i915_module_load@load:
- shard-dg1: NOTRUN -> [SKIP][67] ([i915#6227])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][68] ([i915#6227])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-glk1/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-rkl: [PASS][69] -> [INCOMPLETE][70] ([i915#9820] / [i915#9849])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-rkl-4/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-rkl-1/igt@[email protected]
- shard-snb: [PASS][71] -> [INCOMPLETE][72] ([i915#9849])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-snb5/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-snb2/igt@[email protected]
- shard-tglu: [PASS][73] -> [INCOMPLETE][74] ([i915#10047] / [i915#10887] / [i915#9820])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-tglu-6/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-tglu-2/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@gt0-vecs0:
- shard-dg1: NOTRUN -> [FAIL][75] ([i915#3591])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@i915_pm_rc6_residency@[email protected]

* igt@i915_pm_rps@min-max-config-loaded:
- shard-dg1: NOTRUN -> [SKIP][76] ([i915#6621])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@[email protected]

* igt@i915_pm_rps@thresholds-park@gt0:
- shard-dg2: NOTRUN -> [SKIP][77] ([i915#8925])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@i915_pm_rps@[email protected]

* igt@i915_pm_rps@thresholds@gt0:
- shard-dg1: NOTRUN -> [SKIP][78] ([i915#8925]) +1 other test skip
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@i915_pm_rps@[email protected]

* igt@i915_query@query-topology-coherent-slice-mask:
- shard-mtlp: NOTRUN -> [SKIP][79] ([i915#6188])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@i915_query@test-query-geometry-subslices:
- shard-dg1: NOTRUN -> [SKIP][80] ([i915#5723])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@i915_selftest@mock@memory_region:
- shard-glk: NOTRUN -> [DMESG-WARN][81] ([i915#9311])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-glk2/igt@i915_selftest@mock@memory_region.html

* igt@i915_suspend@basic-s3-without-i915:
- shard-mtlp: NOTRUN -> [SKIP][82] ([i915#6645])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@kms_addfb_basic@addfb25-yf-tiled-legacy:
- shard-dg1: NOTRUN -> [DMESG-WARN][83] ([i915#4423])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_addfb_basic@basic-x-tiled-legacy:
- shard-dg1: NOTRUN -> [SKIP][84] ([i915#4212])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-c-hdmi-a-1-4-mc-ccs:
- shard-dg2: NOTRUN -> [SKIP][85] ([i915#8709]) +11 other tests skip
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-10/igt@kms_async_flips@[email protected]

* igt@kms_async_flips@test-cursor:
- shard-mtlp: NOTRUN -> [SKIP][86] ([i915#10333])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-mtlp: NOTRUN -> [SKIP][87] ([i915#3555])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-mtlp: NOTRUN -> [SKIP][88] ([i915#1769] / [i915#3555])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-dg1: NOTRUN -> [SKIP][89] ([i915#4538] / [i915#5286]) +10 other tests skip
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

* igt@kms_big_fb@y-tiled-32bpp-rotate-180:
- shard-dg2: NOTRUN -> [SKIP][90] ([i915#4538] / [i915#5190]) +1 other test skip
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@kms_big_fb@y-tiled-64bpp-rotate-90:
- shard-dg1: NOTRUN -> [SKIP][91] ([i915#3638]) +8 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-tglu: [PASS][92] -> [FAIL][93] ([i915#3743]) +1 other test fail
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-tglu-5/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-tglu-8/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0:
- shard-dg1: NOTRUN -> [SKIP][94] ([i915#4538]) +10 other tests skip
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-mtlp: NOTRUN -> [SKIP][95] +10 other tests skip
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_joiner@basic-force-joiner:
- shard-dg1: NOTRUN -> [SKIP][96] ([i915#10656])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@kms_ccs@bad-aux-stride-y-tiled-ccs@pipe-c-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][97] ([i915#6095]) +139 other tests skip
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@kms_ccs@[email protected]

* igt@kms_ccs@bad-pixel-format-4-tiled-mtl-rc-ccs-cc@pipe-c-hdmi-a-2:
- shard-glk: NOTRUN -> [SKIP][98] +184 other tests skip
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-glk1/igt@kms_ccs@[email protected]

* igt@kms_ccs@bad-rotation-90-y-tiled-gen12-rc-ccs@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][99] ([i915#10307] / [i915#10434] / [i915#6095]) +3 other tests skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-10/igt@kms_ccs@[email protected]

* igt@kms_ccs@ccs-on-another-bo-yf-tiled-ccs@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][100] ([i915#10307] / [i915#6095]) +199 other tests skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-1/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-primary-basic-y-tiled-gen12-rc-ccs-cc@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][101] ([i915#6095]) +23 other tests skip
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-primary-rotation-180-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][102] ([i915#6095]) +33 other tests skip
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-rkl-1/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-xe2-ccs:
- shard-dg1: NOTRUN -> [SKIP][103] ([i915#10278] / [i915#4423])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_cdclk@plane-scaling@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][104] ([i915#4087]) +3 other tests skip
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-8/igt@kms_cdclk@[email protected]

* igt@kms_chamelium_edid@dp-mode-timings:
- shard-mtlp: NOTRUN -> [SKIP][105] ([i915#7828]) +2 other tests skip
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@kms_chamelium_hpd@dp-hpd-after-suspend:
- shard-dg1: NOTRUN -> [SKIP][106] ([i915#7828]) +14 other tests skip
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_chamelium_hpd@vga-hpd:
- shard-dg2: NOTRUN -> [SKIP][107] ([i915#7828]) +2 other tests skip
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@kms_content_protection@atomic@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][108] ([i915#7173])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-11/igt@kms_content_protection@[email protected]

* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-dg1: NOTRUN -> [SKIP][109] ([i915#3299])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@[email protected]

* igt@kms_content_protection@lic-type-0:
- shard-dg1: NOTRUN -> [SKIP][110] ([i915#9424])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@kms_content_protection@lic-type-1:
- shard-mtlp: NOTRUN -> [SKIP][111] ([i915#6944] / [i915#9424]) +1 other test skip
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@kms_content_protection@type1:
- shard-dg2: NOTRUN -> [SKIP][112] ([i915#7118] / [i915#9424])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@kms_content_protection@uevent:
- shard-dg1: NOTRUN -> [SKIP][113] ([i915#7116] / [i915#9424]) +1 other test skip
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@kms_cursor_crc@cursor-offscreen-32x10:
- shard-mtlp: NOTRUN -> [SKIP][114] ([i915#3555] / [i915#8814]) +2 other tests skip
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@kms_cursor_crc@cursor-offscreen-32x32:
- shard-dg1: NOTRUN -> [SKIP][115] ([i915#3555]) +7 other tests skip
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@[email protected]

* igt@kms_cursor_crc@cursor-onscreen-512x170:
- shard-dg1: NOTRUN -> [SKIP][116] ([i915#3359]) +2 other tests skip
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_cursor_crc@cursor-rapid-movement-32x32:
- shard-dg2: NOTRUN -> [SKIP][117] ([i915#3555])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@kms_cursor_crc@cursor-rapid-movement-512x512:
- shard-mtlp: NOTRUN -> [SKIP][118] ([i915#3359])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle:
- shard-dg1: NOTRUN -> [SKIP][119] ([i915#4103] / [i915#4213])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_cursor_legacy@torture-bo@pipe-a:
- shard-tglu: [PASS][120] -> [DMESG-WARN][121] ([i915#10166])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-tglu-9/igt@kms_cursor_legacy@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-tglu-5/igt@kms_cursor_legacy@[email protected]

* igt@kms_dirtyfb@psr-dirtyfb-ioctl:
- shard-dg1: NOTRUN -> [SKIP][122] ([i915#9723]) +1 other test skip
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@kms_display_modes@mst-extended-mode-negative:
- shard-dg2: NOTRUN -> [SKIP][123] ([i915#8588])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][124] ([i915#3804])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-rkl-3/igt@kms_dither@[email protected]

* igt@kms_dsc@dsc-basic:
- shard-dg1: NOTRUN -> [SKIP][125] ([i915#3555] / [i915#3840]) +1 other test skip
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_feature_discovery@chamelium:
- shard-dg2: NOTRUN -> [SKIP][126] ([i915#4854])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@kms_feature_discovery@display-3x:
- shard-dg1: NOTRUN -> [SKIP][127] ([i915#1839])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_feature_discovery@dp-mst:
- shard-mtlp: NOTRUN -> [SKIP][128] ([i915#9337])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@kms_feature_discovery@psr2:
- shard-dg1: NOTRUN -> [SKIP][129] ([i915#658]) +1 other test skip
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_flip@2x-flip-vs-fences-interruptible:
- shard-dg1: NOTRUN -> [SKIP][130] ([i915#8381])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][131] ([i915#8381])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@kms_flip@2x-flip-vs-modeset:
- shard-mtlp: NOTRUN -> [SKIP][132] ([i915#3637]) +1 other test skip
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@kms_flip@2x-plain-flip-interruptible:
- shard-dg1: NOTRUN -> [SKIP][133] ([i915#9934]) +9 other tests skip
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode:
- shard-dg1: NOTRUN -> [SKIP][134] ([i915#2587] / [i915#2672]) +9 other tests skip
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][135] ([i915#2672])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][136] ([i915#2672] / [i915#3555]) +1 other test skip
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][137] ([i915#8708]) +2 other tests skip
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-dg1: NOTRUN -> [SKIP][138] ([i915#4423])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render:
- shard-dg1: NOTRUN -> [SKIP][139] +73 other tests skip
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-dg1: NOTRUN -> [SKIP][140] ([i915#8708]) +30 other tests skip
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-cpu:
- shard-dg2: [PASS][141] -> [FAIL][142] ([i915#6880])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg2-8/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-tiling-4:
- shard-dg1: NOTRUN -> [SKIP][143] ([i915#5439])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-fullscreen:
- shard-dg2: NOTRUN -> [SKIP][144] ([i915#5354]) +9 other tests skip
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-fullscreen.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][145] ([i915#8708]) +7 other tests skip
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move:
- shard-dg2: NOTRUN -> [SKIP][146] ([i915#10433] / [i915#3458]) +3 other tests skip
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-rte:
- shard-dg2: NOTRUN -> [SKIP][147] ([i915#3458]) +2 other tests skip
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-mtlp: NOTRUN -> [SKIP][148] ([i915#1825]) +8 other tests skip
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary:
- shard-dg1: NOTRUN -> [SKIP][149] ([i915#3458] / [i915#4423])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite:
- shard-dg1: NOTRUN -> [SKIP][150] ([i915#3458]) +26 other tests skip
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@kms_hdmi_inject@inject-audio:
- shard-dg1: NOTRUN -> [SKIP][151] ([i915#433])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@kms_hdr@static-swap:
- shard-dg1: NOTRUN -> [SKIP][152] ([i915#3555] / [i915#8228]) +3 other tests skip
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@[email protected]

* igt@kms_invalid_mode@clock-too-high@pipe-a-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][153] ([i915#9457]) +3 other tests skip
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@kms_invalid_mode@[email protected]

* igt@kms_plane_lowres@tiling-4:
- shard-dg1: NOTRUN -> [SKIP][154] ([i915#3555] / [i915#4423])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [FAIL][155] ([i915#8292])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-rkl-3/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-modifiers@pipe-a-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][156] ([i915#9423]) +3 other tests skip
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-2/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-pixel-format@pipe-c-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][157] ([i915#5176]) +3 other tests skip
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][158] ([i915#9423]) +19 other tests skip
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-75-with-rotation@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][159] ([i915#9423]) +5 other tests skip
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-rkl-1/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][160] ([i915#5176] / [i915#9423]) +3 other tests skip
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-13/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-hdmi-a-3.html

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][161] ([i915#5235]) +1 other test skip
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-rkl-1/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-c-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][162] ([i915#5235]) +15 other tests skip
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][163] ([i915#5235] / [i915#9423] / [i915#9728]) +7 other tests skip
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-3/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][164] ([i915#5235] / [i915#9423]) +15 other tests skip
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-2/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][165] ([i915#5235]) +7 other tests skip
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@kms_plane_scaling@[email protected]

* igt@kms_pm_backlight@bad-brightness:
- shard-dg1: NOTRUN -> [SKIP][166] ([i915#5354]) +1 other test skip
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@[email protected]

* igt@kms_pm_dc@dc3co-vpb-simulation:
- shard-mtlp: NOTRUN -> [SKIP][167] ([i915#9292])
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@kms_pm_dc@dc6-dpms:
- shard-tglu: [PASS][168] -> [FAIL][169] ([i915#9295])
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-tglu-3/igt@[email protected]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-tglu-9/igt@[email protected]

* igt@kms_pm_lpsp@kms-lpsp:
- shard-rkl: NOTRUN -> [SKIP][170] ([i915#9340])
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-rkl-1/igt@[email protected]

* igt@kms_pm_lpsp@screens-disabled:
- shard-dg1: NOTRUN -> [SKIP][171] ([i915#8430])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp:
- shard-dg2: [PASS][172] -> [SKIP][173] ([i915#9519])
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg2-8/igt@[email protected]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-1/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp-stress:
- shard-rkl: [PASS][174] -> [SKIP][175] ([i915#9519]) +1 other test skip
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-rkl-5/igt@[email protected]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-rkl-1/igt@[email protected]

* igt@kms_prime@basic-crc-hybrid:
- shard-mtlp: NOTRUN -> [SKIP][176] ([i915#6524])
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@kms_prime@basic-crc-vgem:
- shard-dg1: NOTRUN -> [SKIP][177] ([i915#6524]) +1 other test skip
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_psr2_sf@fbc-cursor-plane-move-continuous-exceed-fully-sf:
- shard-dg2: NOTRUN -> [SKIP][178] +2 other tests skip
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@kms_psr2_sf@fbc-cursor-plane-move-continuous-exceed-fully-sf.html

* igt@kms_psr2_su@page_flip-nv12:
- shard-dg1: NOTRUN -> [SKIP][179] ([i915#9683])
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@kms_psr2_su@page_flip-nv12.html

* igt@kms_psr@pr-primary-mmap-cpu:
- shard-mtlp: NOTRUN -> [SKIP][180] ([i915#9688]) +7 other tests skip
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@kms_psr@psr2-primary-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][181] ([i915#1072] / [i915#9732]) +3 other tests skip
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@kms_psr@psr2-sprite-mmap-gtt:
- shard-dg1: NOTRUN -> [SKIP][182] ([i915#1072] / [i915#9732]) +34 other tests skip
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-dg1: NOTRUN -> [SKIP][183] ([i915#9685]) +2 other tests skip
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_rotation_crc@exhaust-fences:
- shard-dg2: NOTRUN -> [SKIP][184] ([i915#4235])
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-dg1: NOTRUN -> [SKIP][185] ([i915#5289])
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@kms_rotation_crc@sprite-rotation-90:
- shard-mtlp: NOTRUN -> [SKIP][186] ([i915#4235])
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@kms_setmode@invalid-clone-single-crtc-stealing:
- shard-mtlp: NOTRUN -> [SKIP][187] ([i915#3555] / [i915#8809])
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@kms_sysfs_edid_timing:
- shard-dg1: NOTRUN -> [FAIL][188] ([IGT#2] / [i915#6493])
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@kms_sysfs_edid_timing.html

* igt@kms_tiled_display@basic-test-pattern:
- shard-dg1: NOTRUN -> [SKIP][189] ([i915#8623]) +1 other test skip
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]
- shard-glk: NOTRUN -> [FAIL][190] ([i915#10959])
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-glk4/igt@[email protected]

* igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-3:
- shard-dg1: NOTRUN -> [FAIL][191] ([i915#9196])
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-13/igt@kms_universal_plane@[email protected]

* igt@kms_universal_plane@cursor-fb-leak@pipe-d-hdmi-a-2:
- shard-dg2: NOTRUN -> [FAIL][192] ([i915#9196])
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-2/igt@kms_universal_plane@[email protected]

* igt@kms_vblank@ts-continuation-idle-hang@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [INCOMPLETE][193] ([i915#9508])
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-5/igt@kms_vblank@[email protected]

* igt@kms_vrr@seamless-rr-switch-vrr:
- shard-dg1: NOTRUN -> [SKIP][194] ([i915#9906])
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@kms_writeback@writeback-fb-id-xrgb2101010:
- shard-dg1: NOTRUN -> [SKIP][195] ([i915#2437] / [i915#9412])
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@kms_writeback@writeback-invalid-parameters:
- shard-dg1: NOTRUN -> [SKIP][196] ([i915#2437])
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][197] ([i915#2437])
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-glk1/igt@[email protected]

* igt@perf@mi-rpc:
- shard-dg1: NOTRUN -> [SKIP][198] ([i915#2434])
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@[email protected]

* igt@perf_pmu@cpu-hotplug:
- shard-mtlp: NOTRUN -> [SKIP][199] ([i915#8850])
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][200] ([i915#8850])
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]

* igt@perf_pmu@module-unload:
- shard-dg2: NOTRUN -> [FAIL][201] ([i915#10537] / [i915#5793])
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@prime_vgem@basic-fence-mmap:
- shard-dg2: NOTRUN -> [SKIP][202] ([i915#3708] / [i915#4077])
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@prime_vgem@basic-gtt:
- shard-dg1: NOTRUN -> [SKIP][203] ([i915#3708] / [i915#4077])
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@prime_vgem@basic-read:
- shard-mtlp: NOTRUN -> [SKIP][204] ([i915#3708]) +1 other test skip
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]

* igt@prime_vgem@basic-write:
- shard-dg1: NOTRUN -> [SKIP][205] ([i915#3708]) +1 other test skip
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-17/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][206] ([i915#10216] / [i915#3708])
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@[email protected]

* igt@sriov_basic@bind-unbind-vf:
- shard-dg1: NOTRUN -> [SKIP][207] ([i915#9917])
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-15/igt@[email protected]

* igt@v3d/v3d_get_bo_offset@create-get-offsets:
- shard-dg1: NOTRUN -> [SKIP][208] ([i915#2575]) +20 other tests skip
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@v3d/[email protected]

* igt@v3d/v3d_get_param@get-bad-flags:
- shard-mtlp: NOTRUN -> [SKIP][209] ([i915#2575]) +6 other tests skip
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-2/igt@v3d/[email protected]

* igt@v3d/v3d_wait_bo@unused-bo-0ns:
- shard-dg2: NOTRUN -> [SKIP][210] ([i915#2575]) +2 other tests skip
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@v3d/[email protected]

* igt@vc4/vc4_purgeable_bo@access-purgeable-bo-mem:
- shard-dg1: NOTRUN -> [SKIP][211] ([i915#7711]) +12 other tests skip
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@vc4/[email protected]

* igt@vc4/vc4_purgeable_bo@free-purged-bo:
- shard-mtlp: NOTRUN -> [SKIP][212] ([i915#7711]) +2 other tests skip
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@vc4/[email protected]

* igt@vc4/vc4_tiling@get-bad-handle:
- shard-dg2: NOTRUN -> [SKIP][213] ([i915#7711]) +1 other test skip
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@vc4/[email protected]

#### Possible fixes ####

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglu: [FAIL][214] ([i915#2842]) -> [PASS][215]
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-tglu-4/igt@gem_exec_fair@[email protected]
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-tglu-4/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@basic@lmem0:
- shard-dg2: [FAIL][216] ([i915#10378]) -> [PASS][217] +2 other tests pass
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg2-6/igt@gem_lmem_swapping@[email protected]
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-6/igt@gem_lmem_swapping@[email protected]

* igt@i915_selftest@live@dmabuf:
- shard-mtlp: [DMESG-FAIL][218] -> [PASS][219]
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-mtlp-6/igt@i915_selftest@[email protected]
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-8/igt@i915_selftest@[email protected]

* igt@kms_cursor_edge_walk@64x64-top-bottom@pipe-a-hdmi-a-1:
- shard-snb: [ABORT][220] -> [PASS][221] +1 other test pass
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-snb5/igt@kms_cursor_edge_walk@[email protected]
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-snb2/igt@kms_cursor_edge_walk@[email protected]

* igt@kms_cursor_legacy@single-move@pipe-a:
- shard-mtlp: [DMESG-WARN][222] ([i915#10166]) -> [PASS][223]
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-mtlp-5/igt@kms_cursor_legacy@[email protected]
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-3/igt@kms_cursor_legacy@[email protected]

* igt@kms_cursor_legacy@torture-move@pipe-a:
- shard-dg2: [DMESG-WARN][224] ([i915#10166]) -> [PASS][225]
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg2-5/igt@kms_cursor_legacy@[email protected]
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-5/igt@kms_cursor_legacy@[email protected]

* igt@kms_lease@multimaster-lease:
- shard-dg1: [DMESG-WARN][226] ([i915#4423]) -> [PASS][227] +1 other test pass
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg1-17/igt@[email protected]
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@[email protected]

* igt@kms_pm_dc@dc9-dpms:
- shard-tglu: [SKIP][228] ([i915#4281]) -> [PASS][229]
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-tglu-7/igt@[email protected]
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-tglu-4/igt@[email protected]

* igt@kms_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-dg2: [SKIP][230] ([i915#9519]) -> [PASS][231] +1 other test pass
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg2-4/igt@[email protected]
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-2/igt@[email protected]

* igt@kms_pm_rpm@modeset-non-lpsp:
- shard-rkl: [SKIP][232] ([i915#9519]) -> [PASS][233] +1 other test pass
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-rkl-4/igt@[email protected]
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-rkl-3/igt@[email protected]

* igt@kms_vblank@ts-continuation-idle-hang@pipe-a-hdmi-a-3:
- shard-dg2: [INCOMPLETE][234] ([i915#9508]) -> [PASS][235]
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg2-5/igt@kms_vblank@[email protected]
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-5/igt@kms_vblank@[email protected]

#### Warnings ####

* igt@gem_create@create-ext-cpu-access-big:
- shard-dg2: [ABORT][236] ([i915#9846]) -> [INCOMPLETE][237] ([i915#9364])
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg2-3/igt@[email protected]
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-4/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-mtlp: [ABORT][238] ([i915#10131] / [i915#9820]) -> [ABORT][239] ([i915#10131] / [i915#9697])
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-mtlp-5/igt@[email protected]
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-mtlp-1/igt@[email protected]
- shard-dg2: [INCOMPLETE][240] ([i915#1982] / [i915#9820] / [i915#9849]) -> [INCOMPLETE][241] ([i915#1982] / [i915#9849])
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg2-6/igt@[email protected]
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-6/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-dg1: [SKIP][242] ([i915#4423] / [i915#4538]) -> [SKIP][243] ([i915#4538])
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg1-17/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-dg2: [SKIP][244] ([i915#10433] / [i915#3458]) -> [SKIP][245] ([i915#3458]) +3 other tests skip
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg2-4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu.html

* igt@kms_pm_dc@dc6-dpms:
- shard-rkl: [FAIL][246] ([i915#9295]) -> [SKIP][247] ([i915#3361])
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-rkl-5/igt@[email protected]
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-rkl-1/igt@[email protected]

* igt@kms_pm_dc@dc9-dpms:
- shard-rkl: [SKIP][248] ([i915#4281]) -> [SKIP][249] ([i915#3361])
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-rkl-5/igt@[email protected]
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-rkl-4/igt@[email protected]

* igt@kms_psr@fbc-pr-primary-page-flip:
- shard-dg2: [SKIP][250] ([i915#1072] / [i915#9673] / [i915#9732]) -> [SKIP][251] ([i915#1072] / [i915#9732]) +3 other tests skip
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg2-11/igt@[email protected]
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-10/igt@[email protected]

* igt@kms_psr@fbc-psr-cursor-plane-move:
- shard-dg1: [SKIP][252] ([i915#1072] / [i915#4423] / [i915#9732]) -> [SKIP][253] ([i915#1072] / [i915#9732])
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg1-17/igt@[email protected]
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg1-16/igt@[email protected]

* igt@kms_psr@fbc-psr-primary-mmap-gtt:
- shard-dg2: [SKIP][254] ([i915#1072] / [i915#9732]) -> [SKIP][255] ([i915#1072] / [i915#9673] / [i915#9732]) +15 other tests skip
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14698/shard-dg2-2/igt@[email protected]
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/shard-dg2-11/igt@[email protected]

[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[i915#10047]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10047
[i915#10131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10131
[i915#10166]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10166
[i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
[i915#10278]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10278
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10333]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10333
[i915#10378]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10378
[i915#10386]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10386
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#10537]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10537
[i915#10656]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10656
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#10887]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10887
[i915#10959]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10959
[i915#1099]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1099
[i915#1769]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1839
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
[i915#2434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3743]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3743
[i915#3804]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4087
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4213
[i915#4235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4281
[i915#433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/433
[i915#4423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4423
[i915#4473]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4473
[i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
[i915#4852]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4854
[i915#4860]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4885
[i915#4958]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4958
[i915#5176]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5439]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5439
[i915#5493]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5493
[i915#5723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5784
[i915#5793]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5793
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6188]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6188
[i915#6227]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6227
[i915#6493]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6493
[i915#6524]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6645
[i915#6880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6880
[i915#6944]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6944
[i915#7116]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7173
[i915#7701]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
[i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
[i915#8292]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8292
[i915#8381]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8381
[i915#8411]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
[i915#8430]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8430
[i915#8555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8555
[i915#8562]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8562
[i915#8588]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8588
[i915#8623]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8623
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8709
[i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
[i915#8814]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8814
[i915#8850]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8850
[i915#8925]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8925
[i915#9196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9196
[i915#9292]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9292
[i915#9295]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9295
[i915#9310]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9310
[i915#9311]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9311
[i915#9323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9323
[i915#9337]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9337
[i915#9340]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9340
[i915#9364]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9364
[i915#9412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9412
[i915#9423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9423
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9457]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9457
[i915#9508]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9508
[i915#9519]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9519
[i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
[i915#9683]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9683
[i915#9685]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9685
[i915#9688]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9688
[i915#9697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9697
[i915#9723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9723
[i915#9728]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9728
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9820]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9820
[i915#9846]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9846
[i915#9849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9849
[i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
[i915#9917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9917
[i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934

Build changes
-------------

* Linux: CI_DRM_14698 -> Patchwork_133157v1

CI-20190529: 20190529
CI_DRM_14698: 93a8e4035f726bffeadef90df0971c12b674fe7e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7828: 68a055ff91b91dadb01d9501cd8670f654b5b952 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_133157v1: 93a8e4035f726bffeadef90df0971c12b674fe7e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133157v1/index.html