selftests/x86: fix build errors and warnings found via clang
cover selftests/x86: fix build errors and warnings found via clang
Hi,
Just a bunch of build and warnings fixes that show up when building with clang. Some of these depend on each other, so I'm sending them as a series.
Enjoy!
thanks,
John Hubbard
John Hubbard (7):
selftests/x86: fix Makefile dependencies to work with clang selftests/x86: build test_FISTTP.c with clang selftests/x86: build fsgsbase_restore.c with clang selftests/x86: build sysret_rip.c with clang selftests/x86: avoid -no-pie warnings from clang during compilation selftests/x86: remove (or use) unused variables and functions selftests/x86: fix printk() format warnings
tools/testing/selftests/x86/Makefile | 31 +++++++++++++++---- tools/testing/selftests/x86/amx.c | 16 ---------- .../testing/selftests/x86/clang_helpers_32.S | 11 +++++++ .../testing/selftests/x86/clang_helpers_64.S | 28 +++++++++++++++++ tools/testing/selftests/x86/fsgsbase.c | 6 ---- .../testing/selftests/x86/fsgsbase_restore.c | 11 +++---- tools/testing/selftests/x86/sigreturn.c | 2 +- .../testing/selftests/x86/syscall_arg_fault.c | 1 - tools/testing/selftests/x86/sysret_rip.c | 20 ++++-------- tools/testing/selftests/x86/test_FISTTP.c | 8 ++--- tools/testing/selftests/x86/test_vsyscall.c | 15 +++------ tools/testing/selftests/x86/vdso_restorer.c | 2 ++ 12 files changed, 87 insertions(+), 64 deletions(-) create mode 100644 tools/testing/selftests/x86/clang_helpers_32.S create mode 100644 tools/testing/selftests/x86/clang_helpers_64.S
base-commit: f03359bca01bf4372cf2c118cd9a987a5951b1c8
prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27
Signature · 1 line
2.45.0
PATCH 1/7 selftests/x86: fix Makefile dependencies to work with clang
First of all, in order to build with clang at all, one must first apply Valentin Obst's build fix for LLVM [1]. Once that is done, then when building with clang, via:
make LLVM=1 -C tools/testing/selftests
...the following build failure occurs in selftests/x86:
clang: error: cannot specify -o when generating multiple output files
This happens because, although gcc doesn't complain if you invoke it like this:
gcc file1.c header2.h
...clang won't accept that form--it rejects the .h file(s). Also, the above approach is inaccurate anyway, because file.c includes header2.h in this case, and the inclusion of header2.h on the invocation is an artifact of the Makefile's desire to maintain dependencies.
In Makefiles of this type, a better way to do it is to use Makefile dependencies to trigger the appropriate incremental rebuilds, and separately use file lists (see EXTRA_FILES in this commit) to track what to pass to the compile.
This commit splits those concepts up, by setting up both EXTRA_FILES and the Makefile dependencies with a single call to the new Makefile function extra-files.
That fixes the build failure, while still providing the correct dependencies in all cases.
[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/
--- tools/testing/selftests/x86/Makefile | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-)
tools/testing/selftests/x86/Makefile +15 -6
@@ -73,10 +73,10 @@ all_64: $(BINARIES_64) EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64) $(BINARIES_32): $(OUTPUT)/%_32: %.c helpers.h - $(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl -lm + $(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $< $(EXTRA_FILES) -lrt -ldl -lm $(BINARIES_64): $(OUTPUT)/%_64: %.c helpers.h - $(CC) -m64 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl + $(CC) -m64 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $< $(EXTRA_FILES) -lrt -ldl # x86_64 users should be encouraged to install 32-bit libraries ifeq ($(CAN_BUILD_I386)$(CAN_BUILD_X86_64),01)
@@ -100,10 +100,19 @@ warn_32bit_failure: exit 0; endif -# Some tests have additional dependencies. -$(OUTPUT)/sysret_ss_attrs_64: thunks.S -$(OUTPUT)/ptrace_syscall_32: raw_syscall_helper_32.S -$(OUTPUT)/test_syscall_vdso_32: thunks_32.S +# Add an additional file to the source file list for a given target, and also +# add a Makefile dependency on that same file. However, do these separately, so +# that the compiler invocation ("$(CC) file1.c file2.S") is not combined with +# the dependencies ("header3.h"), because clang, unlike gcc, will not accept +# header files as an input to the compiler invocation. +define extra-files +$(OUTPUT)/$(1): EXTRA_FILES := $(2) +$(OUTPUT)/$(1): $(2) +endef + +$(eval $(call extra-files,sysret_ss_attrs_64,thunks.S)) +$(eval $(call extra-files,ptrace_syscall_32,raw_syscall_helper_32.S)) +$(eval $(call extra-files,test_syscall_vdso_32,thunks_32.S)) # check_initial_reg_state is special: it needs a custom entry, and it # needs to be static so that its interpreter doesn't destroy its initial
Signature · 1 line
2.45.0
PATCH 2/7 selftests/x86: build test_FISTTP.c with clang
In reply to John HubbardFirst of all, in order to build with clang at all, one must first apply Valentin Obst's build fix for LLVM [1]. Once that is done, then when building with clang, via:
make LLVM=1 -C tools/testing/selftests
...the build fails because clang inline asm requires size suffixes for instructions, including the fisttp instruction. In this case, the 16-bit suffix 's' is missing.
Fix by adding an 's' (short) suffix in each place that it is missing.
[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/
--- tools/testing/selftests/x86/test_FISTTP.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
tools/testing/selftests/x86/test_FISTTP.c +4 -4
@@ -25,7 +25,7 @@ int test(void)feclearexcept (FE_DIVBYZERO |FE_INEXACT |FE_INVALID |FE_OVERFLOW |FE_UNDERFLOW ); asmvolatile ("\n" " fld1""\n" -" fisttp res16""\n" +" fisttps res16""\n" " fld1""\n" " fisttpl res32""\n" " fld1""\n"
@@ -45,7 +45,7 @@ int test(void)feclearexcept (FE_DIVBYZERO |FE_INEXACT |FE_INVALID |FE_OVERFLOW |FE_UNDERFLOW ); asmvolatile ("\n" " fldpi""\n" -" fisttp res16""\n" +" fisttps res16""\n" " fldpi""\n" " fisttpl res32""\n" " fldpi""\n"
@@ -66,7 +66,7 @@ int test(void) asmvolatile ("\n" " fldpi""\n" " fchs""\n" -" fisttp res16""\n" +" fisttps res16""\n" " fldpi""\n" " fchs""\n" " fisttpl res32""\n"
@@ -88,7 +88,7 @@ int test(void)feclearexcept (FE_DIVBYZERO |FE_INEXACT |FE_INVALID |FE_OVERFLOW |FE_UNDERFLOW ); asmvolatile ("\n" " fldln2""\n" -" fisttp res16""\n" +" fisttps res16""\n" " fldln2""\n" " fisttpl res32""\n" " fldln2""\n"
Signature · 1 line
2.45.0
PATCH 3/7 selftests/x86: build fsgsbase_restore.c with clang
In reply to John HubbardFirst of all, in order to build with clang at all, one must first apply Valentin Obst's build fix for LLVM [1]. Once that is done, then when building with clang, via:
make LLVM=1 -C tools/testing/selftests
Fix this by moving the inline asm to "pure" assembly, in two new files:clang_helpers_32.S, clang_helpers_64.S.
As a bonus, the pure asm avoids the need for ifdefs, and is now very simple and easy on the eyes.
[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/
--- tools/testing/selftests/x86/Makefile | 2 ++ tools/testing/selftests/x86/clang_helpers_32.S | 11 +++++++++++ tools/testing/selftests/x86/clang_helpers_64.S | 12 ++++++++++++ tools/testing/selftests/x86/fsgsbase_restore.c | 11 +++++------ 4 files changed, 30 insertions(+), 6 deletions(-) create mode 100644 tools/testing/selftests/x86/clang_helpers_32.S create mode 100644 tools/testing/selftests/x86/clang_helpers_64.S
tools/testing/selftests/x86/Makefile +2 -0
@@ -113,6 +113,8 @@ endef $(eval $(call extra-files,sysret_ss_attrs_64,thunks.S)) $(eval $(call extra-files,ptrace_syscall_32,raw_syscall_helper_32.S)) $(eval $(call extra-files,test_syscall_vdso_32,thunks_32.S)) +$(eval $(call extra-files,fsgsbase_restore_64,clang_helpers_64.S)) +$(eval $(call extra-files,fsgsbase_restore_32,clang_helpers_32.S)) # check_initial_reg_state is special: it needs a custom entry, and it # needs to be static so that its interpreter doesn't destroy its initial
tools/testing/selftests/x86/clang_helpers_32.S new file +11 -0
@@ -0,0 +1,11 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * 32-bit assembly helpers for asm operations that lack support in both gcc and + * clang. For example, clang asm does not support segment prefixes. + */ +.global dereference_seg_base +dereference_seg_base: + mov %fs:(0), %eax + ret + +.section .note.GNU-stack,"",%progbits
tools/testing/selftests/x86/clang_helpers_64.S new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * 64-bit assembly helpers for asm operations that lack support in both gcc and + * clang. For example, clang asm does not support segment prefixes. + */ +.global dereference_seg_base + +dereference_seg_base: + mov %gs:(0), %rax + ret + +.section .note.GNU-stack,"",%progbits
tools/testing/selftests/x86/fsgsbase_restore.c +5 -6
@@ -39,12 +39,11 @@# define SEG "%fs"#endif -static unsigned int dereference_seg_base (void ) -{ -int ret; - asmvolatile ("mov %" SEG ":(0), %0" :"=rm" (ret)); -return ret; -} +/* +* Defined in clang_helpers_[32|64].S, because unlike gcc, clang inline asm does +* not support segmentation prefixes. +*/ +unsigned int dereference_seg_base (void );static void init_seg (void ) {
Signature · 1 line
2.45.0
PATCH 4/7 selftests/x86: build sysret_rip.c with clang
In reply to John HubbardFirst of all, in order to build with clang at all, one must first apply Valentin Obst's build fix for LLVM [1]. Once that is done, then when building with clang, via:
make LLVM=1 -C tools/testing/selftests
...the build fails because clang's inline asm doesn't support all of the features that are used in the asm() snippet in sysret_rip.c.
Fix this by moving the asm code into the clang_helpers_64.S file, where it can be built with the assembler's full set of features.
[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/
--- tools/testing/selftests/x86/Makefile | 1 + .../testing/selftests/x86/clang_helpers_64.S | 16 +++++++++++++++ tools/testing/selftests/x86/sysret_rip.c | 20 ++++++------------- 3 files changed, 23 insertions(+), 14 deletions(-)
tools/testing/selftests/x86/Makefile +1 -0
@@ -115,6 +115,7 @@ $(eval $(call extra-files,ptrace_syscall_32,raw_syscall_helper_32.S)) $(eval $(call extra-files,test_syscall_vdso_32,thunks_32.S)) $(eval $(call extra-files,fsgsbase_restore_64,clang_helpers_64.S)) $(eval $(call extra-files,fsgsbase_restore_32,clang_helpers_32.S)) +$(eval $(call extra-files,sysret_rip_64,clang_helpers_64.S)) # check_initial_reg_state is special: it needs a custom entry, and it # needs to be static so that its interpreter doesn't destroy its initial
tools/testing/selftests/x86/clang_helpers_64.S +16 -0
@@ -9,4 +9,20 @@ dereference_seg_base: mov %gs:(0), %rax ret +.global test_page +.global test_syscall_insn + +.pushsection ".text", "ax" +.balign 4096 +test_page: .globl test_page + .fill 4094,1,0xcc + +test_syscall_insn: + syscall + +.ifne . - test_page - 4096 + .error "test page is not one page long" +.endif +.popsection + .section .note.GNU-stack,"",%progbits
tools/testing/selftests/x86/sysret_rip.c +6 -14
@@ -22,21 +22,13 @@#include <sys/mman.h> #include <assert.h> - -asm ( -".pushsection \".text\", \"ax\"\n\t" -".balign 4096\n\t" -"test_page: .globl test_page\n\t" -".fill 4094,1,0xcc\n\t" -"test_syscall_insn:\n\t" -"syscall\n\t" -".ifne . - test_page - 4096\n\t" -".error \"test page is not one page long\"\n\t" -".endif\n\t" -".popsection" - ); - +/* +* These items are in clang_helpers_64.S, in order to avoid clang inline asm +* limitations: +*/ +void test_syscall_ins (void );extern const char test_page[]; +static void const *current_test_page_addr = test_page; static void sethandler(int sig, void (*handler)(int, siginfo_t *, void *),
Signature · 1 line
2.45.0
PATCH 5/7 selftests/x86: avoid -no-pie warnings from clang during compilation
In reply to John HubbardFirst of all, in order to build with clang at all, one must first apply Valentin Obst's build fix for LLVM [1]. Once that is done, then when building with clang, via:
make LLVM=1 -C tools/testing/selftests
...clang warns that -no-pie is "unused during compilation".
This occurs because clang only wants to see -no-pie during linking. Here, we don't have a separate linking stage, so a compiler warning is unavoidable without (wastefully) restructuring the Makefile.
Avoid the warning by simply disabling that warning, for clang builds.
[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/
--- tools/testing/selftests/x86/Makefile | 7 +++++++ 1 file changed, 7 insertions(+)
tools/testing/selftests/x86/Makefile +7 -0
@@ -40,6 +40,13 @@ CFLAGS := -O2 -g -std=gnu99 -pthread -Wall $(KHDR_INCLUDES) # call32_from_64 in thunks.S uses absolute addresses. ifeq ($(CAN_BUILD_WITH_NOPIE),1) CFLAGS += -no-pie + +ifneq ($(LLVM),) +# clang only wants to see -no-pie during linking. Here, we don't have a separate +# linking stage, so a compiler warning is unavoidable without (wastefully) +# restructuring the Makefile. Avoid this by simply disabling that warning. +CFLAGS += -Wno-unused-command-line-argument +endif endif define gen-target-rule-32
Signature · 1 line
2.45.0
PATCH 6/7 selftests/x86: remove (or use) unused variables and functions
In reply to John HubbardFirst of all, in order to build with clang at all, one must first apply Valentin Obst's build fix for LLVM [1]. Once that is done, then when building with clang, via:
make LLVM=1 -C tools/testing/selftests
...quite a few functions are variables are generating "unused" warnings. Fix the warnings by deleting the unused items.
One item, the "nerrs" variable in vsdo_restorer.c's main(), is unused but probably wants to be returned from main(), as a non-zero result. That result is also unused right now, so another option would be to delete it entirely, but this way, main() also gets fixed. It was missing a return value.
[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/
--- tools/testing/selftests/x86/amx.c | 16 ---------------- tools/testing/selftests/x86/fsgsbase.c | 6 ------ tools/testing/selftests/x86/syscall_arg_fault.c | 1 - tools/testing/selftests/x86/test_vsyscall.c | 5 ----- tools/testing/selftests/x86/vdso_restorer.c | 2 ++ 5 files changed, 2 insertions(+), 28 deletions(-)
tools/testing/selftests/x86/amx.c +0 -16
@@ -39,16 +39,6 @@ struct xsave_buffer { }; }; -static inline uint64_t xgetbv (uint32_t index) -{ -uint32_t eax, edx; - - asmvolatile ("xgetbv;" - :"=a" (eax),"=d" (edx) - :"c" (index)); -return eax + ((uint64_t )edx <<32 ); -} -static inline void xsave (struct xsave_buffer *xbuf,uint64_t rfbm) {uint32_t rfbm_lo = rfbm;
@@ -179,12 +169,6 @@ static inline void clear_xstate_header(struct xsave_buffer *buffer)memset (&buffer->header,0 ,sizeof (buffer->header)); } -static inline uint64_t get_xstatebv (struct xsave_buffer *buffer) -{ -/* XSTATE_BV is at the beginning of the header: */ -return *(uint64_t *)&buffer->header; -} -static inline void set_xstatebv (struct xsave_buffer *buffer,uint64_t bv) {/* XSTATE_BV is at the beginning of the header: */
tools/testing/selftests/x86/fsgsbase.c +0 -6
@@ -109,11 +109,6 @@ static inline void wrgsbase(unsigned long gsbase) asmvolatile ("wrgsbase %0" ::"r" (gsbase) :"memory" ); } -static inline void wrfsbase (unsigned long fsbase) -{ - asmvolatile ("wrfsbase %0" ::"r" (fsbase) :"memory" ); -} -enum which_base {FS ,GS };static unsigned long read_base (enum which_base which)
@@ -212,7 +207,6 @@ static void mov_0_gs(unsigned long initial_base, bool schedule) }static volatile unsigned long remote_base; -static volatile bool remote_hard_zero;static volatile unsigned int ftx;/*
tools/testing/selftests/x86/syscall_arg_fault.c +0 -1
@@ -29,7 +29,6 @@ static void sethandler(int sig, void (*handler)(int, siginfo_t *, void *),err (1 ,"sigaction" ); } -static volatile sig_atomic_t sig_traps;static sigjmp_buf jmpbuf;static volatile sig_atomic_t n_errs;
tools/testing/selftests/x86/test_vsyscall.c +0 -5
@@ -160,11 +160,6 @@ static inline long sys_gtod(struct timeval *tv, struct timezone *tz)return syscall (SYS_gettimeofday, tv, tz); } -static inline int sys_clock_gettime (clockid_t id,struct timespec *ts) -{ -return syscall (SYS_clock_gettime, id, ts); -} -static inline long sys_time (time_t *t) {return syscall (SYS_time, t);
tools/testing/selftests/x86/vdso_restorer.c +2 -0
@@ -92,4 +92,6 @@ int main()printf ("[FAIL]\t!SA_SIGINFO handler was not called\n" ); nerrs++; } + +return nerrs; }
Signature · 1 line
2.45.0
PATCH 7/7 selftests/x86: fix printk() format warnings
In reply to John HubbardFirst of all, in order to build with clang at all, one must first apply Valentin Obst's build fix for LLVM [1]. Once that is done, then when building with clang, via:
make LLVM=1 -C tools/testing/selftests
...clang finds and warns about several cases of using the wrong integer size in various printk() format strings.
Fix each by matching it with the size of the associated variable.
[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/
--- tools/testing/selftests/x86/sigreturn.c | 2 +- tools/testing/selftests/x86/test_vsyscall.c | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-)
tools/testing/selftests/x86/sigreturn.c +1 -1
@@ -487,7 +487,7 @@ static void sigtrap(int sig, siginfo_t *info, void *ctx_void)greg_t asm_ss = ctx->uc_mcontext.gregs[REG_CX ];if (asm_ss != sig_ss && sig ==SIGTRAP ) {/* Sanity check failure. */ -printf ("[FAIL]\tSIGTRAP: ss = %hx, frame ss = %hx, ax = %llx\n" , +printf ("[FAIL]\tSIGTRAP: ss = %hx, frame ss = %x, ax = %llx\n" , ss, *ssptr (ctx), (unsigned long long )asm_ss); nerrs++; }
tools/testing/selftests/x86/test_vsyscall.c +5 -5
@@ -328,7 +328,7 @@ static int test_getcpu(int cpu)if (ret_sys ==0 ) {if (cpu_sys != cpu) { -printf ("[FAIL]\tsyscall reported CPU %hu but should be %d\n" , cpu_sys, cpu); +printf ("[FAIL]\tsyscall reported CPU %u but should be %d\n" , cpu_sys, cpu); nerrs++; }
@@ -347,14 +347,14 @@ static int test_getcpu(int cpu) }if (cpu_vdso != cpu) { -printf ("[FAIL]\tvDSO reported CPU %hu but should be %d\n" , cpu_vdso, cpu); +printf ("[FAIL]\tvDSO reported CPU %u but should be %d\n" , cpu_vdso, cpu); nerrs++; }else {printf ("[OK]\tvDSO reported correct CPU\n" ); }if (node_vdso != node) { -printf ("[FAIL]\tvDSO reported node %hu but should be %hu\n" , node_vdso, node); +printf ("[FAIL]\tvDSO reported node %u but should be %u\n" , node_vdso, node); nerrs++; }else {printf ("[OK]\tvDSO reported correct node\n" );
@@ -373,14 +373,14 @@ static int test_getcpu(int cpu) }if (cpu_vsys != cpu) { -printf ("[FAIL]\tvsyscall reported CPU %hu but should be %d\n" , cpu_vsys, cpu); +printf ("[FAIL]\tvsyscall reported CPU %u but should be %d\n" , cpu_vsys, cpu); nerrs++; }else {printf ("[OK]\tvsyscall reported correct CPU\n" ); }if (node_vsys != node) { -printf ("[FAIL]\tvsyscall reported node %hu but should be %hu\n" , node_vsys, node); +printf ("[FAIL]\tvsyscall reported node %u but should be %u\n" , node_vsys, node); nerrs++; }else {printf ("[OK]\tvsyscall reported correct node\n" );
Signature · 1 line
2.45.0