Skip to contentSkip to conversation

I/O errors for ALUA state transitions

PATCH Superseded Martin Wilck 5 participants 6 messages May 3, 2024 – May 7, 2024 SCSI

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 I/O errors for ALUA state transitions

When a host is configured with a few LUNs and IO is running, injecting FC faults repeatedly leads to path recovery problems. The LUNs have 4 paths each and 3 of them come back active after say an FC fault which makes two of the paths go down, instead of all 4. This happens after several iterations of continuous FC faults.

Reason here is that we're returning an I/O error whenever we're encountering sense code 06/04/0a (LOGICAL UNIT NOT ACCESSIBLE, ASYMMETRIC ACCESS STATE TRANSITION) instead of retrying.

mwilck: Resending a modified version of this patch, which was originally authored by Rajashekhar M A from Netapp, and submitted in 2021. Moved the changes to alua_check_sense() as suggested by Mike Christie [1]. Evan Milne had raised the question whether pg->state should be set to transitioning in the UA case [2]. I believe that doing this is correct. SCSI_ACCESS_STATE_TRANSITIONING by itself doesn't cause I/O errors. Our handler schedules an RTPG, which will only result in an I/O error condition if the transitioning timeout expires.

[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/CAGtn9r=kicnTDE2o7Gt5Y=yoidHYD7tG8XdMHEBJTBraVEoOCw@mail.gmail.com/

---
 drivers/scsi/device_handler/scsi_dh_alua.c | 34 +++++++++++++---------
 1 file changed, 20 insertions(+), 14 deletions(-)
drivers/scsi/device_handler/scsi_dh_alua.c +20 -14
index a226dc1b65d7..682d5bb53d14 100644
@@ -414,28 +414,34 @@ static char print_alua_state(unsigned char state)
 	}
 }
 
-static enum scsi_disposition alua_check_sense(struct scsi_device *sdev,
-					      struct scsi_sense_hdr *sense_hdr)
+static enum scsi_disposition alua_handle_state_transition(struct scsi_device *sdev)
 {
 	struct alua_dh_data *h = sdev->handler_data;
 	struct alua_port_group *pg;
 
+	/*
+	 * LUN Not Accessible - ALUA state transition
+	 */
+	rcu_read_lock();
+	pg = rcu_dereference(h->pg);
+	if (pg)
+		pg->state = SCSI_ACCESS_STATE_TRANSITIONING;
+	rcu_read_unlock();
+	alua_check(sdev, false);
+	return NEEDS_RETRY;
+}
+
+static enum scsi_disposition alua_check_sense(struct scsi_device *sdev,
+					      struct scsi_sense_hdr *sense_hdr)
+{
 	switch (sense_hdr->sense_key) {
 	case NOT_READY:
-		if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x0a) {
-			/*
-			 * LUN Not Accessible - ALUA state transition
-			 */
-			rcu_read_lock();
-			pg = rcu_dereference(h->pg);
-			if (pg)
-				pg->state = SCSI_ACCESS_STATE_TRANSITIONING;
-			rcu_read_unlock();
-			alua_check(sdev, false);
-			return NEEDS_RETRY;
-		}
+		if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x0a)
+			return alua_handle_state_transition(sdev);
 		break;
 	case UNIT_ATTENTION:
+		if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x0a)
+			return alua_handle_state_transition(sdev);
 		if (sense_hdr->asc == 0x29 && sense_hdr->ascq == 0x00) {
 			/*
 			 * Power On, Reset, or Bus Device Reset.
Signature · 1 line
2.44.0
#1 lore raw
Quoted 7 lines
drivers/scsi/device_handler/scsi_dh_alua.c +1 -2
-static enum scsi_disposition alua_check_sense(struct scsi_device *sdev,
-					      struct scsi_sense_hdr *sense_hdr)
+static enum scsi_disposition alua_handle_state_transition(struct scsi_device *sdev)
 {
 	struct alua_dh_data *h = sdev->handler_data;
 	struct alua_port_group *pg;
 

drivers/scsi/device_handler/scsi_dh_alua.c static char print_alua_state(unsigned char state) · line 431

Quoted 10 lines
drivers/scsi/device_handler/scsi_dh_alua.c +10 -0
+	/*
+	 * LUN Not Accessible - ALUA state transition
+	 */
+	rcu_read_lock();
+	pg = rcu_dereference(h->pg);
+	if (pg)
+		pg->state = SCSI_ACCESS_STATE_TRANSITIONING;
+	rcu_read_unlock();
+	alua_check(sdev, false);
+	return NEEDS_RETRY;

This always returns NEEDS_RETRY, so you can drop the return value entirely and handle this in the callers.

#2 lore raw
Quoted 15 lines · Christoph Hellwig
Quoted 15 lines

-static enum scsi_disposition alua_check_sense(struct scsi_device *sdev,

(quoted diff) +0 -1
-					      struct

scsi_sense_hdr *sense_hdr)
+static enum scsi_disposition alua_handle_state_transition(struct scsi_device *sdev)
 {
  struct alua_dh_data *h = sdev->handler_data; struct alua_port_group *pg;

drivers/scsi/device_handler/scsi_dh_alua.c +5 -0
+	/*
+	 * LUN Not Accessible - ALUA state transition
+	 */
+	rcu_read_lock();
+	pg = rcu_dereference(h->pg);
Quoted 9 lines

drivers/scsi/device_handler/scsi_dh_alua.c static char print_alua_state(unsigned char state) · line 431

Quoted 5 lines
drivers/scsi/device_handler/scsi_dh_alua.c +5 -0
+	if (pg)
+		pg->state = SCSI_ACCESS_STATE_TRANSITIONING;
+	rcu_read_unlock();
+	alua_check(sdev, false);
+	return NEEDS_RETRY;

This always returns NEEDS_RETRY, so you can drop the return value entirely and handle this in the callers.

I liked being able to write "return alua_handle_state_transition(...)" in the caller. But np, I'll change it.

Martin

#3 lore raw
In reply to Martin Wilck

drivers/scsi/device_handler/scsi_dh_alua.c static char print_alua_state(unsigned char state) · line 443

Quoted 2 lines · Martin Wilck
drivers/scsi/device_handler/scsi_dh_alua.c +1 -0
 	case UNIT_ATTENTION:
+		if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x0a)

Do you need to add this check in alua_tur as well? We are checking for the NOT_READY case.

#4 lore raw
Quoted 8 lines · Mike Christie
Quoted 3 lines · Martin Wilck

  case UNIT_ATTENTION:

(quoted diff) +1 -0
+		if (sense_hdr->asc == 0x04 && sense_hdr->ascq ==

0x0a)

Do you need to add this check in alua_tur as well? We are checking for
the NOT_READY case.

Good point. I'll add the check, I suppose it can't hurt. But I notice that scsi_test_unit_ready() tries to "eat" UA conditions and alua_tur() calls it with ALUA_FAILOVER_RETRIES (5) retries, so checking the sense key in alua_tur() probably won't make much of a difference, either.

[Side note: I am wondering if it makes sense to have scsi_test_unit_ready() retry on UA when called from alua_tur(). After all, alua_tur() is only called to check whether another RTPG must be scheduled. @Hannes?]

Regards,
Martin

#5 lore raw
In reply to Martin Wilck
Quoted 64 lines · Martin Wilck

When a host is configured with a few LUNs and IO is running, injecting FC faults repeatedly leads to path recovery problems. The LUNs have 4 paths each and 3 of them come back active after say an FC fault which makes two of the paths go down, instead of all 4. This happens after several iterations of continuous FC faults.

Reason here is that we're returning an I/O error whenever we're encountering sense code 06/04/0a (LOGICAL UNIT NOT ACCESSIBLE, ASYMMETRIC ACCESS STATE TRANSITION) instead of retrying.

mwilck: Resending a modified version of this patch, which was originally authored by Rajashekhar M A from Netapp, and submitted in 2021. Moved the changes to alua_check_sense() as suggested by Mike Christie [1]. Evan Milne had raised the question whether pg->state should be set to transitioning in the UA case [2]. I believe that doing this is correct. SCSI_ACCESS_STATE_TRANSITIONING by itself doesn't cause I/O errors. Our handler schedules an RTPG, which will only result in an I/O error condition if the transitioning timeout expires.

[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/CAGtn9r=kicnTDE2o7Gt5Y=yoidHYD7tG8XdMHEBJTBraVEoOCw@mail.gmail.com/

---
 drivers/scsi/device_handler/scsi_dh_alua.c | 34 +++++++++++++---------
 1 file changed, 20 insertions(+), 14 deletions(-)
drivers/scsi/device_handler/scsi_dh_alua.c +16 -5
index a226dc1b65d7..682d5bb53d14 100644
@@ -414,28 +414,34 @@ static char print_alua_state(unsigned char state)
 	}
 }
 
-static enum scsi_disposition alua_check_sense(struct scsi_device *sdev,
-					      struct scsi_sense_hdr *sense_hdr)
+static enum scsi_disposition alua_handle_state_transition(struct scsi_device *sdev)
 {
 	struct alua_dh_data *h = sdev->handler_data;
 	struct alua_port_group *pg;
 
+	/*
+	 * LUN Not Accessible - ALUA state transition
+	 */
+	rcu_read_lock();
+	pg = rcu_dereference(h->pg);
+	if (pg)
+		pg->state = SCSI_ACCESS_STATE_TRANSITIONING;
+	rcu_read_unlock();
+	alua_check(sdev, false);
+	return NEEDS_RETRY;
+}
+
+static enum scsi_disposition alua_check_sense(struct scsi_device *sdev,
+					      struct scsi_sense_hdr *sense_hdr)
+{
 	switch (sense_hdr->sense_key) {
 	case NOT_READY:
-		if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x0a) {
-			/*
-			 * LUN Not Accessible - ALUA state transition

drivers/scsi/device_handler/scsi_dh_alua.c static char print_alua_state(unsigned char state) · line 439

Quoted 10 lines
drivers/scsi/device_handler/scsi_dh_alua.c +1 -9
-			 */
-			rcu_read_lock();
-			pg = rcu_dereference(h->pg);
-			if (pg)
-				pg->state = SCSI_ACCESS_STATE_TRANSITIONING;
-			rcu_read_unlock();
-			alua_check(sdev, false);
-			return NEEDS_RETRY;
-		}
+		if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x0a)

Please keep the comment that spells out what this asc/ascq is.

Quoted 8 lines
drivers/scsi/device_handler/scsi_dh_alua.c +3 -0
+			return alua_handle_state_transition(sdev);
 		break;
 	case UNIT_ATTENTION:
+		if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x0a)
+			return alua_handle_state_transition(sdev);
 		if (sense_hdr->asc == 0x29 && sense_hdr->ascq == 0x00) {
 			/*
 			 * Power On, Reset, or Bus Device Reset.
Signature · 2 lines
Damien Le Moal
Western Digital Research