Skip to contentSkip to conversation

selftests/alsa: fix a build warning: return a value in all cases

PATCH In review John Hubbard 2 participants 4 messages May 4, 2024 – May 5, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/alsa: fix a build warning: return a value in all cases

dump_config_tree() is declared to return an int, but the compiler cannot prove that it always returns any value at all. This leads to a clang warning, when building via:

make LLVM=1 -C tools/testing/selftests

Fix this by unconditionally returning the "err" variable if the code reaches the end of the function.

---
 tools/testing/selftests/alsa/conf.c | 2 ++
 1 file changed, 2 insertions(+)
tools/testing/selftests/alsa/conf.c +2 -0
index 89e3656a042d..0109fde53e6f 100644
@@ -116,6 +116,8 @@ static int dump_config_tree(snd_config_t *top)
 	if (snd_config_save(top, out))
 		ksft_exit_fail_msg("config save\n");
 	snd_output_close(out);
+
+	return err;
 }
 
 snd_config_t *conf_load_from_file(const char *filename)

base-commit: ddb4c3f25b7b95df3d6932db0b379d768a6ebdf7
prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27

Signature · 1 line
2.45.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · John Hubbard

dump_config_tree() is declared to return an int, but the compiler cannot prove that it always returns any value at all. This leads to a clang warning, when building via:

make LLVM=1 -C tools/testing/selftests

Fix this by unconditionally returning the "err" variable if the code reaches the end of the function.

maintainer
#2 lore raw
In reply to John Hubbard
Quoted 3 lines · John Hubbard

dump_config_tree() is declared to return an int, but the compiler cannot prove that it always returns any value at all. This leads to a clang warning, when building via:

Though given that the function isn't referenced we could also just delete it.

#3 lore raw
Quoted 7 lines · Mark Brown
Quoted 3 lines · John Hubbard

dump_config_tree() is declared to return an int, but the compiler cannot prove that it always returns any value at all. This leads to a clang warning, when building via:

Though given that the function isn't referenced we could also just delete it.

Even better, thanks for spotting that. I'll send a v2 to delete it.

thanks,

Signature · 2 lines
John Hubbard
NVIDIA