Skip to contentSkip to conversation

selftests/user_events: silence a clang warning: address of packed member

PATCH Superseded John Hubbard 1 participant 1 message May 5, 2024 Kselftest

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/user_events: silence a clang warning: address of packed member

When building with clang, via:

make LLVM=1 -C tools/testing/selftest

...clang warns about "taking address of packed member 'write_index' ". This is not particularly helpful, because the test code really wants to write to exactly this location, and if it ends up being unaligned, then the test won't work (and may segfault, depending on the CPU type).

If that ever comes up, it will be obvious and can be fixed. But all it's doing now is prevent a clean clang build, so disable the warning.

---
 tools/testing/selftests/user_events/Makefile | 5 +++++
 1 file changed, 5 insertions(+)
tools/testing/selftests/user_events/Makefile +5 -0
index 10fcd0066203..617e94344711 100644
@@ -1,5 +1,10 @@
 # SPDX-License-Identifier: GPL-2.0
 CFLAGS += -Wl,-no-as-needed -Wall $(KHDR_INCLUDES)
+
+ifneq ($(LLVM),)
+    CFLAGS += -Wno-address-of-packed-member
+endif
+
 LDLIBS += -lrt -lpthread -lm
 
 TEST_GEN_PROGS = ftrace_test dyn_test perf_test abi_test

base-commit: f462ae0edd3703edd6f22fe41d336369c38b884b
prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27

Signature · 1 line
2.45.0