memcg-reduce-memory-size-of-mem_cgroup_events_index.patch removed from -mm tree
The quilt patch titled
Subject: memcg: reduce memory size of mem_cgroup_events_index
has been removed from the -mm tree. Its filename was
memcg-reduce-memory-size-of-mem_cgroup_events_index.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Shakeel Butt <[email protected]>
Subject: memcg: reduce memory size of mem_cgroup_events_index
Date: Wed, 1 May 2024 10:26:10 -0700
Patch series "memcg: reduce memory consumption by memcg stats", v4.
Most of the memory overhead of a memcg object is due to memcg stats maintained by the kernel. Since stats updates happen in performance critical codepaths, the stats are maintained per-cpu and numa specific stats are maintained per-node * per-cpu. This drastically increase the overhead on large machines i.e. large of CPUs and multiple numa nodes. This patch series tries to reduce the overhead by at least not allocating the memory for stats which are not memcg specific.
This patch (of 8):
mem_cgroup_events_index is a translation table to get the right index of the memcg relevant entry for the general vm_event_item. At the moment, it is defined as integer array. However on a typical system the max entry of vm_event_item (NR_VM_EVENT_ITEMS) is 113, so we don't need to use int as storage type of the array. For now just use int8_t as type and add a BUILD_BUG_ON().
Another benefit of this change is that the translation table fits in 2 cachelines while previously it would require 8 cachelines (assuming 64 bytes cacheline).
---
mm/memcontrol.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
mm/memcontrol.c renamed from mm/memcontrol.c~memcg-reduce-memory-size-of-mem_cgroup_events_index +4 -2
@@ -606,11 +606,13 @@ static const unsigned int memcg_vm_event };#define NR_MEMCG_EVENTS ARRAY_SIZE(memcg_vm_event_stat) -static int mem_cgroup_events_index[NR_VM_EVENT_ITEMS ]__read_mostly ; +static int8_t mem_cgroup_events_index[NR_VM_EVENT_ITEMS ]__read_mostly ;static void init_memcg_events (void ) { -int i; +int8_t i; + +BUILD_BUG_ON (NR_VM_EVENT_ITEMS >=S8_MAX );for (i =0 ; i <NR_MEMCG_EVENTS ; ++i) mem_cgroup_events_index[memcg_vm_event_stat[i]] = i +1 ;
_
Patches currently in -mm which might be from [email protected] are