Skip to contentSkip to conversation

clk: qcom: apss-ipq-pll: remove 'config_ctl_hi_val' from Stromer pll configs

PATCH Applied Gabor Juhos 4 participants 7 messages May 9, 2024 – May 29, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: qcom: apss-ipq-pll: remove 'config_ctl_hi_val' from Stromer pll configs

Since the CONFIG_CTL register is only 32 bits wide in the Stromer and Stromer Plus PLLs , the 'config_ctl_hi_val' values from the IPQ5018 and IPQ5332 configurations are not used so remove those.

No functional changes.

---
Based on 'qcom-clk-for-6.10'

---
 drivers/clk/qcom/apss-ipq-pll.c | 2 --
 1 file changed, 2 deletions(-)
drivers/clk/qcom/apss-ipq-pll.c +0 -2
index 5f7f537e4ecb..e8632db2c542 100644
@@ -70,7 +70,6 @@ static struct clk_alpha_pll ipq_pll_stromer_plus = {
 static const struct alpha_pll_config ipq5018_pll_config = {
 	.l = 0x2a,
 	.config_ctl_val = 0x4001075b,
-	.config_ctl_hi_val = 0x304,
 	.main_output_mask = BIT(0),
 	.aux_output_mask = BIT(1),
 	.early_output_mask = BIT(3),
@@ -84,7 +83,6 @@ static const struct alpha_pll_config ipq5018_pll_config = {
 static const struct alpha_pll_config ipq5332_pll_config = {
 	.l = 0x2d,
 	.config_ctl_val = 0x4001075b,
-	.config_ctl_hi_val = 0x304,
 	.main_output_mask = BIT(0),
 	.aux_output_mask = BIT(1),
 	.early_output_mask = BIT(3),

---
base-commit: 3c5b3e17b8fd1f1add5a9477306c355fab126977
change-id: 20240509-stromer-config-ctl-8cee8e857e13

Best regards,

Signature · 1 line
Gabor Juhos <[email protected]>
#1 lore raw
Quoted 8 lines · Gabor Juhos

Since the CONFIG_CTL register is only 32 bits wide in the Stromer and Stromer Plus PLLs , the 'config_ctl_hi_val' values from the IPQ5018 and IPQ5332 configurations are not used so remove those.

No functional changes.

---

Hm, it sounds suspicious that we'd have these settings then.. Could somebody from QC please confirm that everything's alright here?

Konrad

#2 lore raw
Quoted 5 lines · Konrad Dybcio
Quoted 4 lines · Gabor Juhos

Since the CONFIG_CTL register is only 32 bits wide in the Stromer and Stromer Plus PLLs , the 'config_ctl_hi_val' values from the IPQ5018 and IPQ5332 configurations are not used so remove those.

Quoted 7 lines
Quoted 4 lines

No functional changes.

---

Hm, it sounds suspicious that we'd have these settings then.. Could somebody from QC please confirm that everything's alright here?

I checked the HW doc and yes in both IPQ5018 and IPQ5332 CONFIG_CTL_U register is not implemented. I see offset of CONFIG_CTL_U register is removed in the change[1] by Gabor.

Given that, should we also drop the pll_has_64bit_config() if block from clk_stromer_pll_configure function?

Nevertheless, for this patch

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=4f2bc4acbb19

Quoted 2 lines

Konrad

Acked-by
#3 lore raw
Quoted 10 lines · Kathiravan Thirumoorthy
Quoted 7 lines · Konrad Dybcio
Quoted 6 lines · Gabor Juhos

Since the CONFIG_CTL register is only 32 bits wide in the Stromer and Stromer Plus PLLs , the 'config_ctl_hi_val' values from the IPQ5018 and IPQ5332 configurations are not used so remove those.

No functional changes.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

---

Hm, it sounds suspicious that we'd have these settings then.. Could somebody from QC please confirm that everything's alright here?

I checked the HW doc and yes in both IPQ5018 and IPQ5332 CONFIG_CTL_U register is not implemented. I see offset of CONFIG_CTL_U register is removed in the change[1] by Gabor.

Thanks

Konrad

#4 lore raw
In reply to Kathiravan Thirumoorthy

2024. 05. 10. 18:25 keltezéssel, Kathiravan Thirumoorthy írta:

Quoted 13 lines · Konrad Dybcio
Quoted 10 lines · Gabor Juhos
Quoted 8 lines

Since the CONFIG_CTL register is only 32 bits wide in the Stromer and Stromer Plus PLLs , the 'config_ctl_hi_val' values from the IPQ5018 and IPQ5332 configurations are not used so remove those.

No functional changes.

---

Quoted 7 lines
Quoted 2 lines

Hm, it sounds suspicious that we'd have these settings then.. Could somebody from QC please confirm that everything's alright here?

I checked the HW doc and yes in both IPQ5018 and IPQ5332 CONFIG_CTL_U register is not implemented. I see offset of CONFIG_CTL_U register is removed in the change[1] by Gabor.

Thanks for confirming!

Quoted 3 lines

Given that, should we also drop the pll_has_64bit_config() if block from clk_stromer_pll_configure function?

If we can be sure, that there will be no Stromer PLLs which implements that register we can drop the check. Also, since the SUPPORTS_FSM_MODE flag is not set for any of the Stromer (Plus) Plls supported currently, the related check can be dropped as well.

However I would keep that as is for now. I'm planning to remove the clk_stromer_pll_configure() function entirely but that needs a bunch of preparatory patches which I'm working on at the moment.

Quoted 4 lines

Nevertheless, for this patch

Thank you!

Regards,
Gabor

#5 lore raw
Quoted 28 lines · Gabor Juhos

2024. 05. 10. 18:25 keltezéssel, Kathiravan Thirumoorthy írta:

Quoted 13 lines · Konrad Dybcio
Quoted 10 lines · Gabor Juhos
Quoted 8 lines

Since the CONFIG_CTL register is only 32 bits wide in the Stromer and Stromer Plus PLLs , the 'config_ctl_hi_val' values from the IPQ5018 and IPQ5332 configurations are not used so remove those.

No functional changes.

---

Quoted 7 lines
Quoted 2 lines

Hm, it sounds suspicious that we'd have these settings then.. Could somebody from QC please confirm that everything's alright here?

I checked the HW doc and yes in both IPQ5018 and IPQ5332 CONFIG_CTL_U register is not implemented. I see offset of CONFIG_CTL_U register is removed in the change[1] by Gabor.

Thanks for confirming!

Quoted 3 lines

Given that, should we also drop the pll_has_64bit_config() if block from clk_stromer_pll_configure function?

Quoted 9 lines

If we can be sure, that there will be no Stromer PLLs which implements that register we can drop the check. Also, since the SUPPORTS_FSM_MODE flag is not set for any of the Stromer (Plus) Plls supported currently, the related check can be dropped as well.

However I would keep that as is for now. I'm planning to remove the clk_stromer_pll_configure() function entirely but that needs a bunch of preparatory patches which I'm working on at the moment.

It was Stephen's suggestion[1] to introduce the clk_stromer_pll_configure() to avoid touching the clk_alpha_pll_configure() which has been used by many PLLs. However if we have a valid points to remove this API, then yes.

[1] https://lore.kernel.org/linux-arm-msm/[email protected]/

Quoted 9 lines
Quoted 4 lines

Nevertheless, for this patch

Thank you!

Regards,
Gabor

maintainer Applied
#6 lore raw
In reply to Gabor Juhos
Quoted 8 lines · Gabor Juhos

Since the CONFIG_CTL register is only 32 bits wide in the Stromer and Stromer Plus PLLs , the 'config_ctl_hi_val' values from the IPQ5018 and IPQ5332 configurations are not used so remove those.

No functional changes.

[...]

Applied, thanks!

[1/1] clk: qcom: apss-ipq-pll: remove 'config_ctl_hi_val' from Stromer pll configs

      commit: 2ba8425678af422da37b6c9b50e9ce66f0f55cae

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>