Skip to contentSkip to conversation

ACPI: PCI: Remove unused struct 'acpi_handle_node'

PATCH In review [email protected] 3 participants 4 messages May 9, 2024 – Jun 6, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: PCI: Remove unused struct 'acpi_handle_node'

From: "Dr. David Alan Gilbert" <[email protected]>

'acpi_handle_node' is unused since
Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()") Remove it.

---
 drivers/acpi/pci_root.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/acpi/pci_root.c +0 -5
index 58b89b8d950ed..59e6955e24edb 100644
@@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
 }
 EXPORT_SYMBOL_GPL(acpi_pci_find_root);
 
-struct acpi_handle_node {
-	struct list_head node;
-	acpi_handle handle;
-};
-
 /**
  * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
  * @handle: the handle in question
Signature · 1 line
2.45.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · On Thu, 9 May 2024 01:08:58 +0100 [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

'acpi_handle_node' is unused since
Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()") Remove it.

FWIW, indeed unused.

Quoted 20 lines
---
 drivers/acpi/pci_root.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/acpi/pci_root.c +0 -5
index 58b89b8d950ed..59e6955e24edb 100644
@@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
 }
 EXPORT_SYMBOL_GPL(acpi_pci_find_root);
 
-struct acpi_handle_node {
-	struct list_head node;
-	acpi_handle handle;
-};
-
 /**
  * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
  * @handle: the handle in question
#2 lore raw
Quoted 9 lines · * Jonathan Cameron ([email protected]) wrote:
Quoted 6 lines · On Thu, 9 May 2024 01:08:58 +0100 [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

'acpi_handle_node' is unused since
Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()") Remove it.

Quoted 5 lines
Quoted 1 line

FWIW, indeed unused.

Thanks; any idea who would pick this up?

Dave

Quoted 22 lines
Quoted 20 lines
---
 drivers/acpi/pci_root.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/acpi/pci_root.c +0 -5
index 58b89b8d950ed..59e6955e24edb 100644
@@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
 }
 EXPORT_SYMBOL_GPL(acpi_pci_find_root);
 
-struct acpi_handle_node {
-	struct list_head node;
-	acpi_handle handle;
-};
-
 /**
  * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
  * @handle: the handle in question
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#3 lore raw
Quoted 10 lines · Dr. David Alan Gilbert
Quoted 9 lines · * Jonathan Cameron ([email protected]) wrote:
Quoted 6 lines · On Thu, 9 May 2024 01:08:58 +0100 [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

'acpi_handle_node' is unused since
Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()") Remove it.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

FWIW, indeed unused.

Thanks; any idea who would pick this up?

Applied with Jonathan's reviewed-by to pci/misc for v6.11, thanks!

Rafael, let me know if you want this instead. Easy for me to drop if you do.

Quoted 27 lines
Quoted 22 lines
Quoted 20 lines
---
 drivers/acpi/pci_root.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/acpi/pci_root.c +0 -5
index 58b89b8d950ed..59e6955e24edb 100644
@@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
 }
 EXPORT_SYMBOL_GPL(acpi_pci_find_root);
 
-struct acpi_handle_node {
-	struct list_head node;
-	acpi_handle handle;
-};
-
 /**
  * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
  * @handle: the handle in question
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/