dt-bindings: leds: mark label as depected to match description
Subsystems (2)
PATCH 1/1 dt-bindings: leds: mark label as depected to match description
From: Frank Wunderlich <[email protected]>
The description for property 'label' describes it as deprected, so add a option to mark it like that. Future devicetrees should use function and color properties.
--- Documentation/devicetree/bindings/leds/common.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/leds/common.yaml +1 -0
@@ -58,6 +58,7 @@ properties: no other LED class device can be assigned the same label. This property is deprecated - use 'function' and 'color' properties instead. function-enumerator has no effect when this property is present. + deprecated: true default-state: description:
Signature · 1 line
2.34.1
Quoted 3 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
The description for property 'label' describes it as deprected, so
Typos here and in subject.
Quoted 5 lines
add a option to mark it like that. Future devicetrees should use function and color properties.
Suggested-by AngeloGioacchino Del Regno <[email protected]>Fixes 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema")
Nooo, that's not a fix.
I don't think there was conclusion to make it deprecated on last attempt:
https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof
Il 09/05/24 13:46, Krzysztof Kozlowski ha scritto:
Quoted 11 lines · Frank Wunderlich
Quoted 3 lines
From: Frank Wunderlich <[email protected]>
The description for property 'label' describes it as deprected, so
Typos here and in subject.
Quoted 3 lines
add a option to mark it like that. Future devicetrees should use function and color properties.
Quoted 9 lines
Quoted 2 lines
Suggested-by AngeloGioacchino Del Regno <[email protected]>Fixes 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema")Nooo, that's not a fix.
I don't think there was conclusion to make it deprecated on last attempt:
It's not a fix, agreed.
But that property being deprecated deserves to be marked as deprecated, anyway. Otherwise the documentation shouldn't say in words that it is such.
Cheers,
Angelo
Quoted 19 lines · AngeloGioacchino Del Regno
Il 09/05/24 13:46, Krzysztof Kozlowski ha scritto:
Quoted 18 lines · Frank Wunderlich
Quoted 3 lines
From: Frank Wunderlich <[email protected]>
The description for property 'label' describes it as deprected, so
Typos here and in subject.
Quoted 5 lines
add a option to mark it like that. Future devicetrees should use function and color properties.
Suggested-by AngeloGioacchino Del Regno <[email protected]>Fixes 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema")Nooo, that's not a fix.
I don't think there was conclusion to make it deprecated on last attempt:
Quoted 7 lines
Quoted 2 lines
It's not a fix, agreed.
But that property being deprecated deserves to be marked as deprecated, anyway. Otherwise the documentation shouldn't say in words that it is such.
Fix the docs. We are not ready to deprecate that.
Best regards,
Pavel
Signature · 1 line
People of Russia, stop Putin before his war on Ukraine escalates.