perf tools: Ignore deleted cgroups
Namhyung Kim
maintainerPATCH 1/1 perf tools: Ignore deleted cgroups
On a large system, cgroups can be created and deleted often. That means there's a race between perf tools and cgroups when it gets the cgroup name and opens the cgroup. I got a report that perf stat with many cgroups failed a quite often due to the missing cgroups on such a large machine.
I think we can ignore such cgroups when expanding events and use id 0 if it fails to read the cgroup id. IIUC 0 is not a vaild cgroup id so it won't update event counts for the failed cgroups.
--- tools/perf/util/bpf_counter_cgroup.c | 5 ++--- tools/perf/util/cgroup.c | 4 +++- 2 files changed, 5 insertions(+), 4 deletions(-)
tools/perf/util/bpf_counter_cgroup.c +2 -3
@@ -136,9 +136,8 @@ static int bperf_load_program(struct evlist *evlist) cgrp = evsel->cgrp;if (read_cgroup_id (cgrp) <0 ) { -pr_err ("Failed to get cgroup id\n" ); - err =-1 ; - goto out; +pr_debug ("Failed to get cgroup id for %s\n" , cgrp->name); + cgrp->id =0 ; } map_fd =bpf_map__fd (skel->maps.cgrp_idx);
tools/perf/util/cgroup.c +3 -1
@@ -465,9 +465,11 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str, name = cn->name + prefix_len;if (name[0 ] =='/' && name[1 ]) name++; + +/* the cgroup can go away in the meantime */ cgrp =cgroup__new (name, open_cgroup);if (cgrp ==NULL ) - goto out_err; +continue ; leader =NULL ;evlist__for_each_entry (orig_list, pos) {
Signature · 1 line
2.45.0.118.g7fe29c98d7-goog
Quoted 9 lines · Namhyung Kim
On a large system, cgroups can be created and deleted often. That means there's a race between perf tools and cgroups when it gets the cgroup name and opens the cgroup. I got a report that perf stat with many cgroups failed a quite often due to the missing cgroups on such a large machine.
I think we can ignore such cgroups when expanding events and use id 0 if it fails to read the cgroup id. IIUC 0 is not a vaild cgroup id so it won't update event counts for the failed cgroups.
Thanks, applied to perf-tools-next,
- Arnaldo
Quoted 41 lines
Signed-off-by Namhyung Kim <[email protected]>--- tools/perf/util/bpf_counter_cgroup.c | 5 ++--- tools/perf/util/cgroup.c | 4 +++- 2 files changed, 5 insertions(+), 4 deletions(-)tools/perf/util/bpf_counter_cgroup.c +2
-3@@ -136,9 +136,8 @@ static int bperf_load_program(struct evlist *evlist) cgrp = evsel->cgrp;if (read_cgroup_id (cgrp) <0 ) { -pr_err ("Failed to get cgroup id\n" ); - err =-1 ; - goto out; +pr_debug ("Failed to get cgroup id for %s\n" , cgrp->name); + cgrp->id =0 ; } map_fd =bpf_map__fd (skel->maps.cgrp_idx);tools/perf/util/cgroup.c +3
-1@@ -465,9 +465,11 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str, name = cn->name + prefix_len;if (name[0 ] =='/' && name[1 ]) name++; + +/* the cgroup can go away in the meantime */ cgrp =cgroup__new (name, open_cgroup);if (cgrp ==NULL ) - goto out_err; +continue ; leader =NULL ;evlist__for_each_entry (orig_list, pos) {Signature · 1 line
2.45.0.118.g7fe29c98d7-goog