Skip to contentSkip to conversation

bcachefs: add no_invalid_checks flag

PATCH New Thomas Bertschinger 1 participant 1 message May 9, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcachefs: add no_invalid_checks flag

Setting this flag on a filesystem results in validity checks being skipped when writing bkeys. This flag will be used by tooling that deliberately injects corruption into a filesystem in order to exercise fsck. It shouldn't be set outside of testing/debugging code.

---
 fs/bcachefs/bcachefs.h     | 3 ++-
 fs/bcachefs/bkey_methods.c | 6 ++++++
 2 files changed, 8 insertions(+), 1 deletion(-)
fs/bcachefs/bcachefs.h +2 -1
index ab2dc2c70da2..bc0ea2c4efef 100644
@@ -637,7 +637,8 @@ struct bch_dev {
 	x(error)			\
 	x(topology_error)		\
 	x(errors_fixed)			\
-	x(errors_not_fixed)
+	x(errors_not_fixed)		\
+	x(no_invalid_checks)
 
 enum bch_fs_flags {
 #define x(n)		BCH_FS_##n,
fs/bcachefs/bkey_methods.c +6 -0
index f692f9d8f00d..c2c3dae52186 100644
@@ -126,6 +126,9 @@ int bch2_bkey_val_invalid(struct bch_fs *c, struct bkey_s_c k,
 			  enum bch_validate_flags flags,
 			  struct printbuf *err)
 {
+	if (test_bit(BCH_FS_no_invalid_checks, &c->flags))
+		return 0;
+
 	const struct bkey_ops *ops = bch2_bkey_type_ops(k.k->type);
 	int ret = 0;
 
@@ -162,6 +165,9 @@ int __bch2_bkey_invalid(struct bch_fs *c, struct bkey_s_c k,
 			enum bch_validate_flags flags,
 			struct printbuf *err)
 {
+	if (test_bit(BCH_FS_no_invalid_checks, &c->flags))
+		return 0;
+
 	int ret = 0;
 
 	bkey_fsck_err_on(k.k->u64s < BKEY_U64s, c, err,
Signature · 1 line
2.44.0