perf pmu: Count sys and cpuid json events separately
Ian Rogers
reviewerPATCH 1/1 perf pmu: Count sys and cpuid json events separately
Sys events are eagerly loaded as each event has a compat option that may mean the event is or isn't associated with the PMU. These shouldn't be counted as loaded_json_events as that is used for json events matching the CPUID that may or may not have been loaded. The mismatch causes issues on ARM64 that uses sys events.
--- tools/perf/util/pmu.c | 70 ++++++++++++++++++++++++++++++------------- tools/perf/util/pmu.h | 6 ++-- 2 files changed, 53 insertions(+), 23 deletions(-)
tools/perf/util/pmu.c +49 -21
@@ -36,6 +36,18 @@ struct perf_pmu perf_pmu__fake = {#define UNIT_MAX_LEN 31/* max length for event unit name */ +enum event_source { +/* An event loaded from /sys/devices/<pmu>/events. */ +EVENT_SRC_SYSFS , +/* An event loaded from a CPUID matched json file. */ +EVENT_SRC_CPU_JSON , +/* +* An event loaded from a /sys/devices/<pmu>/identifier matched json +* file. +*/ +EVENT_SRC_SYS_JSON , +}; +/** * struct perf_pmu_alias - An event either read from sysfs or builtin in * pmu-events.c, created by parsing the pmu-events json files.
@@ -521,7 +533,7 @@ static int update_alias(const struct pmu_event *pe,static int perf_pmu__new_alias (struct perf_pmu *pmu,const char *name,const char *desc,const char *val,FILE *val_fd, -const struct pmu_event *pe) +const struct pmu_event *pe,enum event_source src) {struct perf_pmu_alias *alias;int ret;
@@ -574,25 +586,30 @@ static int perf_pmu__new_alias(struct perf_pmu *pmu, const char *name, }snprintf (alias->unit,sizeof (alias->unit),"%s" , unit); } -if (!pe) { -/* Update an event from sysfs with json data. */ -struct update_alias_data data = { - .pmu = pmu, - .alias = alias, - }; - +switch (src) { +default : +case EVENT_SRC_SYSFS : alias->from_sysfs = true;if (pmu->events_table) { +/* Update an event from sysfs with json data. */ +struct update_alias_data data = { + .pmu = pmu, + .alias = alias, + };if (pmu_events_table__find_event (pmu->events_table, pmu, name, update_alias, &data) ==0 ) - pmu->loaded_json_aliases++; + pmu->cpu_json_aliases++; } - } - -if (!pe) pmu->sysfs_aliases++; -else - pmu->loaded_json_aliases++; +break ; +case EVENT_SRC_CPU_JSON : + pmu->cpu_json_aliases++; +break ; +case EVENT_SRC_SYS_JSON : + pmu->sys_json_aliases++; +break ; + + }list_add_tail (&alias->list, &pmu->aliases);return 0 ; }
@@ -653,7 +670,8 @@ static int __pmu_aliases_parse(struct perf_pmu *pmu, int events_dir_fd) }if (perf_pmu__new_alias (pmu, name,/*desc=*/ NULL , -/*val=*/ NULL , file,/*pe=*/ NULL ) <0 ) +/*val=*/ NULL , file,/*pe=*/ NULL , +EVENT_SRC_SYSFS ) <0 )pr_debug ("Cannot set up %s\n" , name);fclose (file); }
@@ -946,7 +964,8 @@ static int pmu_add_cpu_aliases_map_callback(const struct pmu_event *pe, {struct perf_pmu *pmu = vdata; -perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , pe); +perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , + pe,EVENT_SRC_CPU_JSON );return 0 ; }
@@ -981,13 +1000,14 @@ static int pmu_add_sys_aliases_iter_fn(const struct pmu_event *pe,return 0 ;if (pmu_uncore_alias_match (pe->pmu, pmu->name) && -pmu_uncore_identifier_match (pe->compat, pmu->id)) { +pmu_uncore_identifier_match (pe->compat, pmu->id)) {perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , - pe); + pe, +EVENT_SRC_SYS_JSON ); }return 0 ;
@@ -1082,6 +1102,12 @@ struct perf_pmu *perf_pmu__lookup(struct list_head *pmus, int dirfd, const char pmu->max_precise =pmu_max_precise (dirfd, pmu); pmu->alias_name =pmu_find_alias_name (pmu, dirfd); pmu->events_table =perf_pmu__find_events_table (pmu); +/* +* Load the sys json events/aliases when loading the PMU as each event +* may have a different compat regular expression. We therefore can't +* know the number of sys json events/aliases without computing the +* regular expressions for them all. +*/ pmu_add_sys_aliases (pmu);list_add_tail (&pmu->list, pmus);
@@ -1739,12 +1765,14 @@ size_t perf_pmu__num_events(struct perf_pmu *pmu)size_t nr;pmu_aliases_parse (pmu); - nr = pmu->sysfs_aliases; + nr = pmu->sysfs_aliases + pmu->sys_json_aliases;;if (pmu->cpu_aliases_added) - nr += pmu->loaded_json_aliases; + nr += pmu->cpu_json_aliases;else if (pmu->events_table) - nr +=pmu_events_table__num_events (pmu->events_table, pmu) - pmu->loaded_json_aliases; + nr +=pmu_events_table__num_events (pmu->events_table, pmu) - pmu->cpu_json_aliases; +else +assert (pmu->cpu_json_aliases ==0 );return pmu->selectable ? nr +1 : nr; }
tools/perf/util/pmu.h +4 -2
@@ -123,8 +123,10 @@ struct perf_pmu {const struct pmu_events_table *events_table;/** @sysfs_aliases: Number of sysfs aliases loaded. */ uint32_t sysfs_aliases; -/** @sysfs_aliases: Number of json event aliases loaded. */ -uint32_t loaded_json_aliases; +/** @cpu_json_aliases: Number of json event aliases loaded specific to the CPUID. */ +uint32_t cpu_json_aliases; +/** @sys_json_aliases: Number of json event aliases loaded matching the PMU's identifier. */ +uint32_t sys_json_aliases;/** @sysfs_aliases_loaded: Are sysfs aliases loaded from disk? */ bool sysfs_aliases_loaded;/**
Signature · 1 line
2.45.0.118.g7fe29c98d7-goog
Quoted 167 lines
-----Original Message-----
From: Ian Rogers <[email protected]>
Sent: Saturday, May 11, 2024 8:36 AM
To: Justin He <[email protected]>; Peter Zijlstra <[email protected]>; Ingo Molnar <[email protected]>; Arnaldo Carvalho de Melo <[email protected]>; Namhyung Kim <[email protected]>; Mark Rutland <[email protected]>; Alexander Shishkin <[email protected]>; Jiri Olsa <[email protected]>; Ian Rogers <[email protected]>; Adrian Hunter <[email protected]>; Kan Liang <[email protected]>; James Clark <[email protected]>; [email protected]; [email protected]; John Garry <[email protected]>
Subject: [PATCH v1] perf pmu: Count sys and cpuid json events separatelySys events are eagerly loaded as each event has a compat option that may mean the event is or isn't associated with the PMU. These shouldn't be counted as
loaded_json_eventsas that is used for json events matching the CPUID that may or may not have been loaded. The mismatch causes issues on ARM64 that uses sys events.Reported-by Jia He <[email protected]>Closes:
https://lore.kernel.org/lkml/[email protected]
/Fixes e6ff1eed3584 ("perf pmu: Lazily add JSON events")Signed-off-by Ian Rogers <[email protected]>--- tools/perf/util/pmu.c | 70 ++++++++++++++++++++++++++++++------------- tools/perf/util/pmu.h | 6 ++-- 2 files changed, 53 insertions(+), 23 deletions(-)tools/perf/util/pmu.c index renamed from tools/perf/util/pmu.c +0
-0
b3b072feef02..888ce9912275100644tools/perf/util/pmu.c +31
-14@@ -36,6 +36,18 @@ struct perf_pmu perf_pmu__fake = {#define UNIT_MAX_LEN 31/* max length for event unit name */ +enum event_source { +/* An event loaded from /sys/devices/<pmu>/events. */ +EVENT_SRC_SYSFS , +/* An event loaded from a CPUID matched json file. */ +EVENT_SRC_CPU_JSON , +/* +* An event loaded from a /sys/devices/<pmu>/identifier matched json +* file. +*/ +EVENT_SRC_SYS_JSON , +}; +/** * struct perf_pmu_alias - An event either read from sysfs or builtin in * pmu-events.c, created by parsing the pmu-events json files. @@ -521,7 +533,7 @@ static int update_alias(const struct pmu_event *pe,static int perf_pmu__new_alias (struct perf_pmu *pmu,const char *name,const char *desc,const char *val,FILE *val_fd, -const struct pmu_event *pe) +const struct pmu_event *pe,enum event_source src) {struct perf_pmu_alias *alias;int ret;@@ -574,25 +586,30 @@ static int perf_pmu__new_alias(struct perf_pmu *pmu, const char *name, }snprintf (alias->unit,sizeof (alias->unit),"%s" , unit); } -if (!pe) { -/* Update an event from sysfs with json data. */ -struct update_alias_data data = { - .pmu = pmu, - .alias = alias, - }; - +switch (src) { +default : +case EVENT_SRC_SYSFS : alias->from_sysfs = true;if (pmu->events_table) { +/* Update an event from sysfs with json data. */ +struct update_alias_data data = { + .pmu = pmu, + .alias = alias, + };if (pmu_events_table__find_event (pmu->events_table, pmu, name, update_alias, &data) ==0 ) - pmu->loaded_json_aliases++; + pmu->cpu_json_aliases++; } - } - -if (!pe) pmu->sysfs_aliases++; -else - pmu->loaded_json_aliases++; +break ; +case EVENT_SRC_CPU_JSON : + pmu->cpu_json_aliases++; +break ; +case EVENT_SRC_SYS_JSON : + pmu->sys_json_aliases++; +break ; + + }list_add_tail (&alias->list, &pmu->aliases);return 0;}
tools/perf/util/pmu.c +2
-1@@ -653,7 +670,8 @@ static int __pmu_aliases_parse(struct perf_pmu *pmu, int events_dir_fd) }if (perf_pmu__new_alias (pmu, name,/*desc=*/ NULL , -/*val=*/ NULL , file,/*pe=*/ NULL ) <0 ) +/*val=*/ NULL , file,/*pe=*/ NULL , +EVENT_SRC_SYSFS ) <0 )pr_debug ("Cannot set up %s\n" , name);fclose (file);}tools/perf/util/pmu.c +2
-1@@ -946,7 +964,8 @@ static int pmu_add_cpu_aliases_map_callback(const struct pmu_event *pe, {struct perf_pmu *pmu = vdata; -perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL, pe); +perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , + pe,EVENT_SRC_CPU_JSON );return 0 ;}
tools/perf/util/pmu.c +3
-2@@ -981,13 +1000,14 @@ static int pmu_add_sys_aliases_iter_fn(const structpmu_event *pe, return 0;if (pmu_uncore_alias_match (pe->pmu, pmu->name) && -pmu_uncore_identifier_match (pe->compat, pmu->id)) { +pmu_uncore_identifier_match (pe->compat, pmu->id)) {perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , - pe); + pe, +EVENT_SRC_SYS_JSON ); }return 0;tools/perf/util/pmu.c +0
-0@@ -1082,6 +1102,12 @@ struct perf_pmu *perf_pmu__lookup(struct
list_head*pmus, int dirfd, const charpmu->max_precise = pmu_max_precise(dirfd, pmu); pmu->alias_name = pmu_find_alias_name(pmu, dirfd); pmu->events_table = perf_pmu__find_events_table(pmu);tools/perf/util/pmu.c +6
-0+/* +* Load the sys json events/aliases when loading the PMU as each event +* may have a different compat regular expression. We therefore can't +* know the number of sys json events/aliases without computing the +* regular expressions for them all. +*/ pmu_add_sys_aliases (pmu);list_add_tail (&pmu->list, pmus);
tools/perf/util/pmu.c size_t perf_pmu__num_events(struct perf_pmu · line 1769
Quoted 6 lines
tools/perf/util/pmu.c +1
-1@@ -1739,12 +1765,14 @@ size_t perf_pmu__num_events(struct perf_pmu *pmu)size_t nr;pmu_aliases_parse (pmu); - nr = pmu->sysfs_aliases; + nr = pmu->sysfs_aliases + pmu->sys_json_aliases;;
Nits: double ";", others lgtm.
This fixes the error on the Arm N2 server:
Unexpected event smmuv3_pmcg_3f002/smmuv3_pmcg_3f002/transaction// Unexpected event smmuv3_pmcg_3f042/smmuv3_pmcg_3f042/transaction// Unexpected event smmuv3_pmcg_3f062/smmuv3_pmcg_3f062/transaction// Unexpected event smmuv3_pmcg_3f402/smmuv3_pmcg_3f402/transaction// Unexpected event smmuv3_pmcg_3f442/smmuv3_pmcg_3f442/transaction//
.....
Please feel free to add
--
Cheers,
Justin (Jia He)
Quoted 29 lines
tools/perf/util/pmu.c +4
-2if (pmu->cpu_aliases_added) - nr += pmu->loaded_json_aliases; + nr += pmu->cpu_json_aliases;else if (pmu->events_table) - nr +=pmu_events_table__num_events (pmu->events_table, pmu) - pmu->loaded_json_aliases; + nr +=pmu_events_table__num_events (pmu->events_table, pmu) - pmu->cpu_json_aliases; + else + assert(pmu->cpu_json_aliases == 0);return pmu->selectable ? nr + 1 : nr;}
tools/perf/util/pmu.h index renamed from tools/perf/util/pmu.h +0
-0
561716aa2b25..b2d3fd291f02100644tools/perf/util/pmu.h +1
-2@@ -123,8 +123,10 @@ struct perf_pmu {const struct pmu_events_table *events_table;/** @sysfs_aliases: Number of sysfs aliases loaded. */ uint32_t sysfs_aliases; -/** @sysfs_aliases: Number of json event aliases loaded. */ -uint32_t loaded_json_aliases; +/** @cpu_json_aliases: Number of json event aliases loaded specific to the CPUID. */
tools/perf/util/pmu.h +2
-0+uint32_t cpu_json_aliases; +/** @sys_json_aliases: Number of json event aliases loaded matching the PMU's identifier. */
Quoted 6 lines
+ uint32_t sys_json_aliases; /** @sysfs_aliases_loaded: Are sysfs aliases loaded from disk? */ bool sysfs_aliases_loaded; /**--
2.45.0.118.g7fe29c98d7-goog
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Ian Rogers
reviewerQuoted 185 lines · Justin He
Quoted 168 lines
-----Original Message-----
From: Ian Rogers <[email protected]>
Sent: Saturday, May 11, 2024 8:36 AM
To: Justin He <[email protected]>; Peter Zijlstra <[email protected]>; Ingo Molnar <[email protected]>; Arnaldo Carvalho de Melo <[email protected]>; Namhyung Kim <[email protected]>; Mark Rutland <[email protected]>; Alexander Shishkin <[email protected]>; Jiri Olsa <[email protected]>; Ian Rogers <[email protected]>; Adrian Hunter <[email protected]>; Kan Liang <[email protected]>; James Clark <[email protected]>; [email protected]; [email protected]; John Garry <[email protected]>
Subject: [PATCH v1] perf pmu: Count sys and cpuid json events separatelySys events are eagerly loaded as each event has a compat option that may mean the event is or isn't associated with the PMU. These shouldn't be counted as
loaded_json_eventsas that is used for json events matching the CPUID that may or may not have been loaded. The mismatch causes issues on ARM64 that uses sys events.Reported-by Jia He <[email protected]>Closes:
https://lore.kernel.org/lkml/[email protected]
/Fixes e6ff1eed3584 ("perf pmu: Lazily add JSON events")Signed-off-by Ian Rogers <[email protected]>--- tools/perf/util/pmu.c | 70 ++++++++++++++++++++++++++++++------------- tools/perf/util/pmu.h | 6 ++-- 2 files changed, 53 insertions(+), 23 deletions(-)tools/perf/util/pmu.c index renamed from tools/perf/util/pmu.c +0
-0
b3b072feef02..888ce9912275100644tools/perf/util/pmu.c +31
-14@@ -36,6 +36,18 @@ struct perf_pmu perf_pmu__fake = {#define UNIT_MAX_LEN 31/* max length for event unit name */ +enum event_source { +/* An event loaded from /sys/devices/<pmu>/events. */ +EVENT_SRC_SYSFS , +/* An event loaded from a CPUID matched json file. */ +EVENT_SRC_CPU_JSON , +/* +* An event loaded from a /sys/devices/<pmu>/identifier matched json +* file. +*/ +EVENT_SRC_SYS_JSON , +}; +/** * struct perf_pmu_alias - An event either read from sysfs or builtin in * pmu-events.c, created by parsing the pmu-events json files. @@ -521,7 +533,7 @@ static int update_alias(const struct pmu_event *pe,static int perf_pmu__new_alias (struct perf_pmu *pmu,const char *name,const char *desc,const char *val,FILE *val_fd, -const struct pmu_event *pe) +const struct pmu_event *pe,enum event_source src) {struct perf_pmu_alias *alias;int ret;@@ -574,25 +586,30 @@ static int perf_pmu__new_alias(struct perf_pmu *pmu, const char *name, }snprintf (alias->unit,sizeof (alias->unit),"%s" , unit); } -if (!pe) { -/* Update an event from sysfs with json data. */ -struct update_alias_data data = { - .pmu = pmu, - .alias = alias, - }; - +switch (src) { +default : +case EVENT_SRC_SYSFS : alias->from_sysfs = true;if (pmu->events_table) { +/* Update an event from sysfs with json data. */ +struct update_alias_data data = { + .pmu = pmu, + .alias = alias, + };if (pmu_events_table__find_event (pmu->events_table, pmu, name, update_alias, &data) ==0 ) - pmu->loaded_json_aliases++; + pmu->cpu_json_aliases++; } - } - -if (!pe) pmu->sysfs_aliases++; -else - pmu->loaded_json_aliases++; +break ; +case EVENT_SRC_CPU_JSON : + pmu->cpu_json_aliases++; +break ; +case EVENT_SRC_SYS_JSON : + pmu->sys_json_aliases++; +break ; + + }list_add_tail (&alias->list, &pmu->aliases);return 0;}
tools/perf/util/pmu.c +2
-1@@ -653,7 +670,8 @@ static int __pmu_aliases_parse(struct perf_pmu *pmu, int events_dir_fd) }if (perf_pmu__new_alias (pmu, name,/*desc=*/ NULL , -/*val=*/ NULL , file,/*pe=*/ NULL ) <0 ) +/*val=*/ NULL , file,/*pe=*/ NULL , +EVENT_SRC_SYSFS ) <0 )pr_debug ("Cannot set up %s\n" , name);fclose (file);}tools/perf/util/pmu.c +2
-1@@ -946,7 +964,8 @@ static int pmu_add_cpu_aliases_map_callback(const struct pmu_event *pe, {struct perf_pmu *pmu = vdata; -perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL, pe); +perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , + pe,EVENT_SRC_CPU_JSON );return 0 ;}
tools/perf/util/pmu.c +3
-2@@ -981,13 +1000,14 @@ static int pmu_add_sys_aliases_iter_fn(const structpmu_event *pe, return 0;if (pmu_uncore_alias_match (pe->pmu, pmu->name) && -pmu_uncore_identifier_match (pe->compat, pmu->id)) { +pmu_uncore_identifier_match (pe->compat, pmu->id)) {perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , - pe); + pe, +EVENT_SRC_SYS_JSON ); }return 0;tools/perf/util/pmu.c +0
-0@@ -1082,6 +1102,12 @@ struct perf_pmu *perf_pmu__lookup(struct
list_head*pmus, int dirfd, const charpmu->max_precise = pmu_max_precise(dirfd, pmu); pmu->alias_name = pmu_find_alias_name(pmu, dirfd); pmu->events_table = perf_pmu__find_events_table(pmu);tools/perf/util/pmu.c +6
-0+/* +* Load the sys json events/aliases when loading the PMU as each event +* may have a different compat regular expression. We therefore can't +* know the number of sys json events/aliases without computing the +* regular expressions for them all. +*/ pmu_add_sys_aliases (pmu);list_add_tail (&pmu->list, pmus);tools/perf/util/pmu.c size_t perf_pmu__num_events(struct perf_pmu · line 1769
Quoted 6 lines
tools/perf/util/pmu.c +1
-1@@ -1739,12 +1765,14 @@ size_t perf_pmu__num_events(struct perf_pmu *pmu)size_t nr;pmu_aliases_parse (pmu); - nr = pmu->sysfs_aliases; + nr = pmu->sysfs_aliases + pmu->sys_json_aliases;;Nits: double ";", others lgtm.
This fixes the error on the Arm N2 server:
Unexpected event smmuv3_pmcg_3f002/smmuv3_pmcg_3f002/transaction// Unexpected event smmuv3_pmcg_3f042/smmuv3_pmcg_3f042/transaction// Unexpected event smmuv3_pmcg_3f062/smmuv3_pmcg_3f062/transaction// Unexpected event smmuv3_pmcg_3f402/smmuv3_pmcg_3f402/transaction// Unexpected event smmuv3_pmcg_3f442/smmuv3_pmcg_3f442/transaction//
.....
Quoted 2 lines
Please feel free to add
Tested-by Jia He <[email protected]>
Thanks Justin! I noticed Arnaldo has picked this up in the next tree:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/commit/?h=perf-tools-next&id=d9c5f5f94c2d356fdf3503f7fcaf254512bc032d
Would be great to add the Tested-by and address the ;; issue, good catch :-)
Ian
Quoted 40 lines
--
Cheers,
Justin (Jia He)Quoted 29 lines
tools/perf/util/pmu.c +4
-2if (pmu->cpu_aliases_added) - nr += pmu->loaded_json_aliases; + nr += pmu->cpu_json_aliases;else if (pmu->events_table) - nr +=pmu_events_table__num_events (pmu->events_table, pmu) - pmu->loaded_json_aliases; + nr +=pmu_events_table__num_events (pmu->events_table, pmu) - pmu->cpu_json_aliases; + else + assert(pmu->cpu_json_aliases == 0);return pmu->selectable ? nr + 1 : nr;}
tools/perf/util/pmu.h index renamed from tools/perf/util/pmu.h +0
-0
561716aa2b25..b2d3fd291f02100644tools/perf/util/pmu.h +1
-2@@ -123,8 +123,10 @@ struct perf_pmu {const struct pmu_events_table *events_table;/** @sysfs_aliases: Number of sysfs aliases loaded. */ uint32_t sysfs_aliases; -/** @sysfs_aliases: Number of json event aliases loaded. */ -uint32_t loaded_json_aliases; +/** @cpu_json_aliases: Number of json event aliases loaded specific to the CPUID. */
tools/perf/util/pmu.h +2
-0+uint32_t cpu_json_aliases; +/** @sys_json_aliases: Number of json event aliases loaded matching the PMU's identifier. */
Quoted 6 lines
+ uint32_t sys_json_aliases; /** @sysfs_aliases_loaded: Are sysfs aliases loaded from disk? */ bool sysfs_aliases_loaded; /**--
2.45.0.118.g7fe29c98d7-googIMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Quoted 23 lines · Ian Rogers
Sys events are eagerly loaded as each event has a compat option that may mean the event is or isn't associated with the PMU. These shouldn't be counted as
loaded_json_eventsas that is used for json events matching the CPUID that may or may not have been loaded. The mismatch causes issues on ARM64 that uses sys events.Reported-by Jia He <[email protected]>Fixes e6ff1eed3584 ("perf pmu: Lazily add JSON events")Signed-off-by Ian Rogers <[email protected]>--- tools/perf/util/pmu.c | 70 ++++++++++++++++++++++++++++++------------- tools/perf/util/pmu.h | 6 ++-- 2 files changed, 53 insertions(+), 23 deletions(-)tools/perf/util/pmu.c +0
-0@@ -36,6 +36,18 @@ struct perf_pmu perf_pmu__fake = {#define UNIT_MAX_LEN 31/* max length for event unit name */
tools/perf/util/pmu.c struct perf_pmu perf_pmu__fake = { · line 48
Quoted 10 lines
tools/perf/util/pmu.c +10
-0+enum event_source { +/* An event loaded from /sys/devices/<pmu>/events. */ +EVENT_SRC_SYSFS , +/* An event loaded from a CPUID matched json file. */ +EVENT_SRC_CPU_JSON , +/* +* An event loaded from a /sys/devices/<pmu>/identifier matched json +* file. +*/ +EVENT_SRC_SYS_JSON ,
If a json sys event aliases to a EVENT_SRC_SYSFS event, this is considered a EVENT_SRC_SYS_JSON event source, right?
Quoted 29 lines
tools/perf/util/pmu.c +6
-8+}; +/** * struct perf_pmu_alias - An event either read from sysfs or builtin in * pmu-events.c, created by parsing the pmu-events json files. @@ -521,7 +533,7 @@ static int update_alias(const struct pmu_event *pe,static int perf_pmu__new_alias (struct perf_pmu *pmu,const char *name,const char *desc,const char *val,FILE *val_fd, -const struct pmu_event *pe) +const struct pmu_event *pe,enum event_source src) {struct perf_pmu_alias *alias;int ret;@@ -574,25 +586,30 @@ static int perf_pmu__new_alias(struct perf_pmu *pmu, const char *name, }snprintf (alias->unit,sizeof (alias->unit),"%s" , unit); } -if (!pe) { -/* Update an event from sysfs with json data. */ -struct update_alias_data data = { - .pmu = pmu, - .alias = alias, - }; - +switch (src) { +default : +case EVENT_SRC_SYSFS : alias->from_sysfs = true;
tools/perf/util/pmu.c static int perf_pmu__new_alias(struct perf_pmu *pmu, const char *name, · line 601
Quoted 10 lines
tools/perf/util/pmu.c +6
-1if (pmu->events_table) { +/* Update an event from sysfs with json data. */ +struct update_alias_data data = { + .pmu = pmu, + .alias = alias, + };if (pmu_events_table__find_event (pmu->events_table, pmu, name, update_alias, &data) ==0 ) - pmu->loaded_json_aliases++; + pmu->cpu_json_aliases++;
seems strange that matching for EVENT_SRC_SYSFS increases pmu->cpu_json_aliases
Quoted 92 lines
tools/perf/util/pmu.c +27
-12} - } - -if (!pe) pmu->sysfs_aliases++; -else - pmu->loaded_json_aliases++; +break ; +case EVENT_SRC_CPU_JSON : + pmu->cpu_json_aliases++; +break ; +case EVENT_SRC_SYS_JSON : + pmu->sys_json_aliases++; +break ; + + }list_add_tail (&alias->list, &pmu->aliases);return 0 ; }@@ -653,7 +670,8 @@ static int __pmu_aliases_parse(struct perf_pmu *pmu, int events_dir_fd) }if (perf_pmu__new_alias (pmu, name,/*desc=*/ NULL , -/*val=*/ NULL , file,/*pe=*/ NULL ) <0 ) +/*val=*/ NULL , file,/*pe=*/ NULL , +EVENT_SRC_SYSFS ) <0 )pr_debug ("Cannot set up %s\n" , name);fclose (file); }@@ -946,7 +964,8 @@ static int pmu_add_cpu_aliases_map_callback(const struct pmu_event *pe, {struct perf_pmu *pmu = vdata; -perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , pe); +perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , + pe,EVENT_SRC_CPU_JSON );return 0 ; }@@ -981,13 +1000,14 @@ static int pmu_add_sys_aliases_iter_fn(const struct pmu_event *pe,return 0 ;if (pmu_uncore_alias_match (pe->pmu, pmu->name) && -pmu_uncore_identifier_match (pe->compat, pmu->id)) { +pmu_uncore_identifier_match (pe->compat, pmu->id)) {perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , - pe); + pe, +EVENT_SRC_SYS_JSON ); }return 0 ;@@ -1082,6 +1102,12 @@ struct perf_pmu *perf_pmu__lookup(struct list_head *pmus, int dirfd, const char pmu->max_precise =pmu_max_precise (dirfd, pmu); pmu->alias_name =pmu_find_alias_name (pmu, dirfd); pmu->events_table =perf_pmu__find_events_table (pmu); +/* +* Load the sys json events/aliases when loading the PMU as each event +* may have a different compat regular expression. We therefore can't +* know the number of sys json events/aliases without computing the +* regular expressions for them all. +*/ pmu_add_sys_aliases (pmu);list_add_tail (&pmu->list, pmus);@@ -1739,12 +1765,14 @@ size_t perf_pmu__num_events(struct perf_pmu *pmu)size_t nr;pmu_aliases_parse (pmu); - nr = pmu->sysfs_aliases; + nr = pmu->sysfs_aliases + pmu->sys_json_aliases;;if (pmu->cpu_aliases_added) - nr += pmu->loaded_json_aliases; + nr += pmu->cpu_json_aliases;else if (pmu->events_table) - nr +=pmu_events_table__num_events (pmu->events_table, pmu) - pmu->loaded_json_aliases; + nr +=pmu_events_table__num_events (pmu->events_table, pmu) - pmu->cpu_json_aliases; +else +assert (pmu->cpu_json_aliases ==0 );return pmu->selectable ? nr +1 : nr; }tools/perf/util/pmu.h +0
-0
tools/perf/util/pmu.h struct perf_pmu { · line 127
Quoted 7 lines
tools/perf/util/pmu.h +2
-2@@ -123,8 +123,10 @@ struct perf_pmu {const struct pmu_events_table *events_table;/** @sysfs_aliases: Number of sysfs aliases loaded. */ uint32_t sysfs_aliases; -/** @sysfs_aliases: Number of json event aliases loaded. */ -uint32_t loaded_json_aliases; +/** @cpu_json_aliases: Number of json event aliases loaded specific to the CPUID. */ +uint32_t cpu_json_aliases;
it seems strange that we allow a pmu to have both cpu_json_aliases and sys_json_aliases count. A union could be used, but that would complicate things.
Quoted 5 lines
tools/perf/util/pmu.h +2
-0+/** @sys_json_aliases: Number of json event aliases loaded matching the PMU's identifier. */ +uint32_t sys_json_aliases;/** @sysfs_aliases_loaded: Are sysfs aliases loaded from disk? */ bool sysfs_aliases_loaded;/**
Ian Rogers
reviewerQuoted 25 lines · John Garry
Quoted 23 lines · Ian Rogers
Sys events are eagerly loaded as each event has a compat option that may mean the event is or isn't associated with the PMU. These shouldn't be counted as
loaded_json_eventsas that is used for json events matching the CPUID that may or may not have been loaded. The mismatch causes issues on ARM64 that uses sys events.Reported-by Jia He <[email protected]>Fixes e6ff1eed3584 ("perf pmu: Lazily add JSON events")Signed-off-by Ian Rogers <[email protected]>--- tools/perf/util/pmu.c | 70 ++++++++++++++++++++++++++++++------------- tools/perf/util/pmu.h | 6 ++-- 2 files changed, 53 insertions(+), 23 deletions(-)tools/perf/util/pmu.c +0
-0@@ -36,6 +36,18 @@ struct perf_pmu perf_pmu__fake = {#define UNIT_MAX_LEN 31/* max length for event unit name */
Quoted 13 lines
tools/perf/util/pmu.c struct perf_pmu perf_pmu__fake = { · line 48
Quoted 10 lines
tools/perf/util/pmu.c +10
-0+enum event_source { +/* An event loaded from /sys/devices/<pmu>/events. */ +EVENT_SRC_SYSFS , +/* An event loaded from a CPUID matched json file. */ +EVENT_SRC_CPU_JSON , +/* +* An event loaded from a /sys/devices/<pmu>/identifier matched json +* file. +*/ +EVENT_SRC_SYS_JSON ,If a json sys event aliases to a
EVENT_SRC_SYSFSevent, this is considered aEVENT_SRC_SYS_JSONevent source, right?
Thanks John. The current use for this enum is just in perf_pmu__new_alias to say which source is requesting the new alias/event for the lazy loading book keeping. It isn't held in the perf_pmu_alias as events may appear in both sysfs and json and we update in that case.
Quoted 34 lines
Quoted 34 lines
tools/perf/util/pmu.c +10
-8+}; +/** * struct perf_pmu_alias - An event either read from sysfs or builtin in * pmu-events.c, created by parsing the pmu-events json files. @@ -521,7 +533,7 @@ static int update_alias(const struct pmu_event *pe,static int perf_pmu__new_alias (struct perf_pmu *pmu,const char *name,const char *desc,const char *val,FILE *val_fd, -const struct pmu_event *pe) +const struct pmu_event *pe,enum event_source src) {struct perf_pmu_alias *alias;int ret;@@ -574,25 +586,30 @@ static int perf_pmu__new_alias(struct perf_pmu *pmu, const char *name, }snprintf (alias->unit,sizeof (alias->unit),"%s" , unit); } -if (!pe) { -/* Update an event from sysfs with json data. */ -struct update_alias_data data = { - .pmu = pmu, - .alias = alias, - }; - +switch (src) { +default : +case EVENT_SRC_SYSFS : alias->from_sysfs = true;if (pmu->events_table) { +/* Update an event from sysfs with json data. */ +struct update_alias_data data = { + .pmu = pmu, + .alias = alias,
Quoted 8 lines
tools/perf/util/pmu.c static int perf_pmu__new_alias(struct perf_pmu *pmu, const char *name, · line 601
Quoted 5 lines
tools/perf/util/pmu.c +2
-1+ };if (pmu_events_table__find_event (pmu->events_table, pmu, name, update_alias, &data) ==0 ) - pmu->loaded_json_aliases++; + pmu->cpu_json_aliases++;seems strange that matching for
EVENT_SRC_SYSFSincreasespmu->cpu_json_aliases
Yep. There's a comment at the start of the "if", we're trying to update a srcfs event with json data as the pmu->events_table contained the event. As the json event won't be used, it just updates the srcfs event, we need to account for that when giving the number of events/aliases.
Quoted 95 lines
Quoted 95 lines
tools/perf/util/pmu.c +27
-12} - } - -if (!pe) pmu->sysfs_aliases++; -else - pmu->loaded_json_aliases++; +break ; +case EVENT_SRC_CPU_JSON : + pmu->cpu_json_aliases++; +break ; +case EVENT_SRC_SYS_JSON : + pmu->sys_json_aliases++; +break ; + + }list_add_tail (&alias->list, &pmu->aliases);return 0 ; }@@ -653,7 +670,8 @@ static int __pmu_aliases_parse(struct perf_pmu *pmu, int events_dir_fd) }if (perf_pmu__new_alias (pmu, name,/*desc=*/ NULL , -/*val=*/ NULL , file,/*pe=*/ NULL ) <0 ) +/*val=*/ NULL , file,/*pe=*/ NULL , +EVENT_SRC_SYSFS ) <0 )pr_debug ("Cannot set up %s\n" , name);fclose (file); }@@ -946,7 +964,8 @@ static int pmu_add_cpu_aliases_map_callback(const struct pmu_event *pe, {struct perf_pmu *pmu = vdata; -perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , pe); +perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , + pe,EVENT_SRC_CPU_JSON );return 0 ; }@@ -981,13 +1000,14 @@ static int pmu_add_sys_aliases_iter_fn(const struct pmu_event *pe,return 0 ;if (pmu_uncore_alias_match (pe->pmu, pmu->name) && -pmu_uncore_identifier_match (pe->compat, pmu->id)) { +pmu_uncore_identifier_match (pe->compat, pmu->id)) {perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , - pe); + pe, +EVENT_SRC_SYS_JSON ); }return 0 ;@@ -1082,6 +1102,12 @@ struct perf_pmu *perf_pmu__lookup(struct list_head *pmus, int dirfd, const char pmu->max_precise =pmu_max_precise (dirfd, pmu); pmu->alias_name =pmu_find_alias_name (pmu, dirfd); pmu->events_table =perf_pmu__find_events_table (pmu); +/* +* Load the sys json events/aliases when loading the PMU as each event +* may have a different compat regular expression. We therefore can't +* know the number of sys json events/aliases without computing the +* regular expressions for them all. +*/ pmu_add_sys_aliases (pmu);list_add_tail (&pmu->list, pmus);@@ -1739,12 +1765,14 @@ size_t perf_pmu__num_events(struct perf_pmu *pmu)size_t nr;pmu_aliases_parse (pmu); - nr = pmu->sysfs_aliases; + nr = pmu->sysfs_aliases + pmu->sys_json_aliases;;if (pmu->cpu_aliases_added) - nr += pmu->loaded_json_aliases; + nr += pmu->cpu_json_aliases;else if (pmu->events_table) - nr +=pmu_events_table__num_events (pmu->events_table, pmu) - pmu->loaded_json_aliases; + nr +=pmu_events_table__num_events (pmu->events_table, pmu) - pmu->cpu_json_aliases; +else +assert (pmu->cpu_json_aliases ==0 );return pmu->selectable ? nr +1 : nr; }tools/perf/util/pmu.h +0
-0@@ -123,8 +123,10 @@ struct perf_pmu {const struct pmu_events_table *events_table;/** @sysfs_aliases: Number of sysfs aliases loaded. */ uint32_t sysfs_aliases;
Quoted 8 lines
tools/perf/util/pmu.h struct perf_pmu { · line 127
Quoted 4 lines
tools/perf/util/pmu.h +2
-2-/** @sysfs_aliases: Number of json event aliases loaded. */ -uint32_t loaded_json_aliases; +/** @cpu_json_aliases: Number of json event aliases loaded specific to the CPUID. */ +uint32_t cpu_json_aliases;it seems strange that we allow a pmu to have both
cpu_json_aliasesandsys_json_aliasescount. A union could be used, but that would complicate things.
Yeah. There are a bunch of things the currently sys json allows that we may want to change. Lazy loading has made "perf bench internals pmu-scan" about 10 times faster, this matters on large servers that may be getting on for 100s of particularly uncore PMUs. Sys json events don't allow lazy loading as each json event needs its Compat field checking against the PMU's identifier file. We're paying a cost for sys json events in cases where the events are never used. If we keep this behavior we could at least ahead of time compile the regular expressions in the sys event json using lex, we should do similar for CPUIDs. Anyway, I think there's lots of room for improvements. The focus in this change was on correctness and I'm not worried about the possible 4 byte per PMU saving here.
Thanks,
Ian
Quoted 7 lines
Quoted 6 lines
tools/perf/util/pmu.h +2
-0+/** @sys_json_aliases: Number of json event aliases loaded matching the PMU's identifier. */ +uint32_t sys_json_aliases;/** @sysfs_aliases_loaded: Are sysfs aliases loaded from disk? */ bool sysfs_aliases_loaded;/**
Quoted 10 lines · Ian Rogers
Sys events are eagerly loaded as each event has a compat option that may mean the event is or isn't associated with the PMU. These shouldn't be counted as
loaded_json_eventsas that is used for json events matching the CPUID that may or may not have been loaded. The mismatch causes issues on ARM64 that uses sys events.Reported-by Jia He <[email protected]>Fixes e6ff1eed3584 ("perf pmu: Lazily add JSON events")Signed-off-by Ian Rogers <[email protected]>
This patch also fixes my previous same issue:
https://lore.kernel.org/linux-perf-users/[email protected]/
Thanks,
Xu Yang
Quoted 169 lines
--- tools/perf/util/pmu.c | 70 ++++++++++++++++++++++++++++++------------- tools/perf/util/pmu.h | 6 ++-- 2 files changed, 53 insertions(+), 23 deletions(-)tools/perf/util/pmu.c +49
-21@@ -36,6 +36,18 @@ struct perf_pmu perf_pmu__fake = {#define UNIT_MAX_LEN 31/* max length for event unit name */ +enum event_source { +/* An event loaded from /sys/devices/<pmu>/events. */ +EVENT_SRC_SYSFS , +/* An event loaded from a CPUID matched json file. */ +EVENT_SRC_CPU_JSON , +/* +* An event loaded from a /sys/devices/<pmu>/identifier matched json +* file. +*/ +EVENT_SRC_SYS_JSON , +}; +/** * struct perf_pmu_alias - An event either read from sysfs or builtin in * pmu-events.c, created by parsing the pmu-events json files. @@ -521,7 +533,7 @@ static int update_alias(const struct pmu_event *pe,static int perf_pmu__new_alias (struct perf_pmu *pmu,const char *name,const char *desc,const char *val,FILE *val_fd, -const struct pmu_event *pe) +const struct pmu_event *pe,enum event_source src) {struct perf_pmu_alias *alias;int ret;@@ -574,25 +586,30 @@ static int perf_pmu__new_alias(struct perf_pmu *pmu, const char *name, }snprintf (alias->unit,sizeof (alias->unit),"%s" , unit); } -if (!pe) { -/* Update an event from sysfs with json data. */ -struct update_alias_data data = { - .pmu = pmu, - .alias = alias, - }; - +switch (src) { +default : +case EVENT_SRC_SYSFS : alias->from_sysfs = true;if (pmu->events_table) { +/* Update an event from sysfs with json data. */ +struct update_alias_data data = { + .pmu = pmu, + .alias = alias, + };if (pmu_events_table__find_event (pmu->events_table, pmu, name, update_alias, &data) ==0 ) - pmu->loaded_json_aliases++; + pmu->cpu_json_aliases++; } - } - -if (!pe) pmu->sysfs_aliases++; -else - pmu->loaded_json_aliases++; +break ; +case EVENT_SRC_CPU_JSON : + pmu->cpu_json_aliases++; +break ; +case EVENT_SRC_SYS_JSON : + pmu->sys_json_aliases++; +break ; + + }list_add_tail (&alias->list, &pmu->aliases);return 0 ; }@@ -653,7 +670,8 @@ static int __pmu_aliases_parse(struct perf_pmu *pmu, int events_dir_fd) }if (perf_pmu__new_alias (pmu, name,/*desc=*/ NULL , -/*val=*/ NULL , file,/*pe=*/ NULL ) <0 ) +/*val=*/ NULL , file,/*pe=*/ NULL , +EVENT_SRC_SYSFS ) <0 )pr_debug ("Cannot set up %s\n" , name);fclose (file); }@@ -946,7 +964,8 @@ static int pmu_add_cpu_aliases_map_callback(const struct pmu_event *pe, {struct perf_pmu *pmu = vdata; -perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , pe); +perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , + pe,EVENT_SRC_CPU_JSON );return 0 ; }@@ -981,13 +1000,14 @@ static int pmu_add_sys_aliases_iter_fn(const struct pmu_event *pe,return 0 ;if (pmu_uncore_alias_match (pe->pmu, pmu->name) && -pmu_uncore_identifier_match (pe->compat, pmu->id)) { +pmu_uncore_identifier_match (pe->compat, pmu->id)) {perf_pmu__new_alias (pmu, pe->name, pe->desc, pe->event,/*val_fd=*/ NULL , - pe); + pe, +EVENT_SRC_SYS_JSON ); }return 0 ;@@ -1082,6 +1102,12 @@ struct perf_pmu *perf_pmu__lookup(struct list_head *pmus, int dirfd, const char pmu->max_precise =pmu_max_precise (dirfd, pmu); pmu->alias_name =pmu_find_alias_name (pmu, dirfd); pmu->events_table =perf_pmu__find_events_table (pmu); +/* +* Load the sys json events/aliases when loading the PMU as each event +* may have a different compat regular expression. We therefore can't +* know the number of sys json events/aliases without computing the +* regular expressions for them all. +*/ pmu_add_sys_aliases (pmu);list_add_tail (&pmu->list, pmus);@@ -1739,12 +1765,14 @@ size_t perf_pmu__num_events(struct perf_pmu *pmu)size_t nr;pmu_aliases_parse (pmu); - nr = pmu->sysfs_aliases; + nr = pmu->sysfs_aliases + pmu->sys_json_aliases;;if (pmu->cpu_aliases_added) - nr += pmu->loaded_json_aliases; + nr += pmu->cpu_json_aliases;else if (pmu->events_table) - nr +=pmu_events_table__num_events (pmu->events_table, pmu) - pmu->loaded_json_aliases; + nr +=pmu_events_table__num_events (pmu->events_table, pmu) - pmu->cpu_json_aliases; +else +assert (pmu->cpu_json_aliases ==0 );return pmu->selectable ? nr +1 : nr; }tools/perf/util/pmu.h +4
-2@@ -123,8 +123,10 @@ struct perf_pmu {const struct pmu_events_table *events_table;/** @sysfs_aliases: Number of sysfs aliases loaded. */ uint32_t sysfs_aliases; -/** @sysfs_aliases: Number of json event aliases loaded. */ -uint32_t loaded_json_aliases; +/** @cpu_json_aliases: Number of json event aliases loaded specific to the CPUID. */ +uint32_t cpu_json_aliases; +/** @sys_json_aliases: Number of json event aliases loaded matching the PMU's identifier. */ +uint32_t sys_json_aliases;/** @sysfs_aliases_loaded: Are sysfs aliases loaded from disk? */ bool sysfs_aliases_loaded;/** Signature · 1 line
2.45.0.118.g7fe29c98d7-goog