Skip to contentSkip to conversation

mm-damon-core-initialize-esz_bp-from-damos_quota_init_priv.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message May 11, 2024

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled

     Subject: mm/damon/core: initialize ->esz_bp from damos_quota_init_priv()

has been removed from the -mm tree. Its filename was
mm-damon-core-initialize-esz_bp-from-damos_quota_init_priv.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: SeongJae Park <[email protected]>
Subject: mm/damon/core: initialize ->esz_bp from damos_quota_init_priv()
Date: Fri, 3 May 2024 11:03:09 -0700

Patch series "mm/damon: misc fixes and improvements".

Add miscelleneous and non-urgent fixes and improvements for DAMON code, selftests, and documents.

This patch (of 10):

damos_quota_init_priv() function should initialize all private fields of struct damos_quota. However, it is not initializing ->esz_bp field. This could result in use of uninitialized variable from damon_feed_loop_next_input() function. There is no such issue at the moment because every caller of the function is passing damos_quota object that already having the field zero value. But we cannot guarantee the future, and the function is not doing what it is promising. A bug is a bug. This fix is for preventing possible future issues.

Fixes 9294a037c015 ("mm/damon/core: implement goal-oriented feedback-driven quota auto-tuning")
Cc Jonathan Corbet <[email protected]>
Cc Shuah Khan <[email protected]>

---

 mm/damon/core.c |    1 +
 1 file changed, 1 insertion(+)
mm/damon/core.c renamed from mm/damon/core.c~mm-damon-core-initialize-esz_bp-from-damos_quota_init_priv +1 -0
@@ -346,6 +346,7 @@ static struct damos_quota *damos_quota_i
 	quota->charged_from = 0;
 	quota->charge_target_from = NULL;
 	quota->charge_addr_from = 0;
+	quota->esz_bp = 0;
 	return quota;
 }
 

_

Patches currently in -mm which might be from [email protected] are