Skip to contentSkip to conversation

selftests-kcmp-remove-unused-open-mode.patch removed from -mm tree

merged mm-nonmm-stable Andrew Morton 1 participant 1 message May 11, 2024

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: selftests/kcmp: remove unused open mode
has been removed from the -mm tree. Its filename was
selftests-kcmp-remove-unused-open-mode.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Edward Liaw <[email protected]>
Subject: selftests/kcmp: remove unused open mode
Date: Mon, 29 Apr 2024 23:46:09 +0000

Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE aren't specified. The permissions for the file are set above:

	fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644);
Fixes d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall")
Cc Eric Biederman <[email protected]>
Cc Shuah Khan <[email protected]>

---

 tools/testing/selftests/kcmp/kcmp_test.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/kcmp/kcmp_test.c renamed from tools/testing/selftests/kcmp/kcmp_test.c~selftests-kcmp-remove-unused-open-mode +1 -1
@@ -91,7 +91,7 @@ int main(int argc, char **argv)
 		ksft_print_header();
 		ksft_set_plan(3);
 
-		fd2 = open(kpath, O_RDWR, 0644);
+		fd2 = open(kpath, O_RDWR);
 		if (fd2 < 0) {
 			perror("Can't open file");
 			ksft_exit_fail();

_

Patches currently in -mm which might be from [email protected] are