Skip to contentSkip to conversation

actbl1: Update values to hex to follow ACPI specs

RFC PATCH Superseded Zaid Alali 1 participant 2 messages May 14, 2024 ACPI component architecture (acpica)

v1 of 10 Superseded Latest is v10 →

lore
Share & tools
lore

Zaid Alali

author
#0 lore raw

RFC PATCH 1/2 actbl1: Update values to hex to follow ACPI specs

ACPI specs(1) define Error Injection Actions in hex values. This commit intends to update values from decimal to hex to be consistent with ACPI specs.

(1) https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html

---
 source/include/actbl1.h | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
source/include/actbl1.h +11 -11
index 26097feb7..b6ad18940 100644
@@ -1369,17 +1369,17 @@ typedef struct acpi_einj_entry
 
 enum AcpiEinjActions
 {
-    ACPI_EINJ_BEGIN_OPERATION               = 0,
-    ACPI_EINJ_GET_TRIGGER_TABLE             = 1,
-    ACPI_EINJ_SET_ERROR_TYPE                = 2,
-    ACPI_EINJ_GET_ERROR_TYPE                = 3,
-    ACPI_EINJ_END_OPERATION                 = 4,
-    ACPI_EINJ_EXECUTE_OPERATION             = 5,
-    ACPI_EINJ_CHECK_BUSY_STATUS             = 6,
-    ACPI_EINJ_GET_COMMAND_STATUS            = 7,
-    ACPI_EINJ_SET_ERROR_TYPE_WITH_ADDRESS   = 8,
-    ACPI_EINJ_GET_EXECUTE_TIMINGS           = 9,
-    ACPI_EINJ_ACTION_RESERVED               = 10,    /* 10 and greater are reserved */
+    ACPI_EINJ_BEGIN_OPERATION               = 0x0,
+    ACPI_EINJ_GET_TRIGGER_TABLE             = 0x1,
+    ACPI_EINJ_SET_ERROR_TYPE                = 0x2,
+    ACPI_EINJ_GET_ERROR_TYPE                = 0x3,
+    ACPI_EINJ_END_OPERATION                 = 0x4,
+    ACPI_EINJ_EXECUTE_OPERATION             = 0x5,
+    ACPI_EINJ_CHECK_BUSY_STATUS             = 0x6,
+    ACPI_EINJ_GET_COMMAND_STATUS            = 0x7,
+    ACPI_EINJ_SET_ERROR_TYPE_WITH_ADDRESS   = 0x8,
+    ACPI_EINJ_GET_EXECUTE_TIMINGS           = 0x9,
+    ACPI_EINJ_ACTION_RESERVED               = 0xA,   /* 10 and greater are reserved */
     ACPI_EINJ_TRIGGER_ERROR                 = 0xFF   /* Except for this value */
 };
 
Signature · 1 line
2.34.1
author
#1 lore raw

RFC PATCH 2/2 actbl1: Add EINJv2 get error type action

This commit adds EINJV2_GET_ERROR_TYPE as defined in the proposed specs(1)(2).

Proposed ACPI spces for EINJv2:
(1) https://bugzilla.tianocore.org/show_bug.cgi?id=4615
(2) https://bugzilla.tianocore.org/attachment.cgi?id=1446

---
 source/include/actbl1.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
source/include/actbl1.h +2 -1
index b6ad18940..ebee9b0f1 100644
@@ -1379,7 +1379,8 @@ enum AcpiEinjActions
     ACPI_EINJ_GET_COMMAND_STATUS            = 0x7,
     ACPI_EINJ_SET_ERROR_TYPE_WITH_ADDRESS   = 0x8,
     ACPI_EINJ_GET_EXECUTE_TIMINGS           = 0x9,
-    ACPI_EINJ_ACTION_RESERVED               = 0xA,   /* 10 and greater are reserved */
+    ACPI_EINJV2_GET_ERROR_TYPE              = 0x11,
+    ACPI_EINJ_ACTION_RESERVED               = 0x12,   /* 0x12 and greater are reserved */
     ACPI_EINJ_TRIGGER_ERROR                 = 0xFF   /* Except for this value */
 };
 
Signature · 1 line
2.34.1