Skip to contentSkip to conversation

scsi: mpt3sas: Use a unified annotation style

PATCH In review Deming Wang 2 participants 2 messages May 20, 2024 – May 21, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: mpt3sas: Use a unified annotation style

Use a unified annotation style.

---
 drivers/scsi/mpt3sas/mpt3sas_scsih.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/mpt3sas/mpt3sas_scsih.c +2 -2
index 12d08d8ba538..97062b440e9d 100644
@@ -2681,8 +2681,8 @@ scsih_device_configure(struct scsi_device *sdev, struct queue_limits *lim)
 		spin_unlock_irqrestore(&ioc->pcie_device_lock, flags);
 		mpt3sas_scsih_change_queue_depth(sdev, qdepth);
 		/* Enable QUEUE_FLAG_NOMERGES flag, so that IOs won't be
-		 ** merged and can eliminate holes created during merging
-		 ** operation.
+		 * merged and can eliminate holes created during merging
+		 * operation.
 		 **/
 		blk_queue_flag_set(QUEUE_FLAG_NOMERGES,
 				sdev->request_queue);
Signature · 1 line
2.31.1
#1 lore raw
Quoted 12 lines · Deming Wang

Use a unified annotation style.

---
  drivers/scsi/mpt3sas/mpt3sas_scsih.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/mpt3sas/mpt3sas_scsih.c +0 -0
index 12d08d8ba538..97062b440e9d 100644

drivers/scsi/mpt3sas/mpt3sas_scsih.c scsih_device_configure(struct scsi_device *sdev, struct queue_limits *lim) · line 2688

Quoted 10 lines
drivers/scsi/mpt3sas/mpt3sas_scsih.c +2 -2
@@ -2681,8 +2681,8 @@ scsih_device_configure(struct scsi_device *sdev, struct queue_limits *lim)
  		spin_unlock_irqrestore(&ioc->pcie_device_lock, flags);
  		mpt3sas_scsih_change_queue_depth(sdev, qdepth);
  		/* Enable QUEUE_FLAG_NOMERGES flag, so that IOs won't be
-		 ** merged and can eliminate holes created during merging
-		 ** operation.
+		 * merged and can eliminate holes created during merging
+		 * operation.
  		 **/
  		blk_queue_flag_set(QUEUE_FLAG_NOMERGES,
  				sdev->request_queue);

This still isn't the recommended kernel comment style.

/*
* Enable QUEUE_FLAG_NOMERGES flag, so that IOs won't be
* merged and can eliminate holes created during merging
* operation.
*/