Skip to contentSkip to conversation

Log kernel version in check.log

PATCH In review [email protected] 3 participants 3 messages May 22, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Log kernel version in check.log

From: Carlos Maiolino <[email protected]>

After collecting several xfstests runs, it's useful to keep track on which kernel a specific run happened.

---
 check | 1 +
 1 file changed, 1 insertion(+)
check +1 -0
index c6dba89b..7703c128 100755
@@ -478,6 +478,7 @@ _wrapup()
 		fi
 
 		_global_log ""
+		_global_log "Kernel version: $(uname -r)"
 		_global_log "$(date)"
 
 		echo "SECTION       -- $section" >>$tmp.summary
Signature · 1 line
2.45.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · On Wed, May 22, 2024 at 01:33:38PM +0200, [email protected] wrote:

From: Carlos Maiolino <[email protected]>

After collecting several xfstests runs, it's useful to keep track on which kernel a specific run happened.

I wonder if you want to capture more of the system variables, like __generate_report_vars does?

(Should we be capturing ${FSTYP}progs version too?)

--D

Quoted 20 lines
---
 check | 1 +
 1 file changed, 1 insertion(+)
check +1 -0
index c6dba89b..7703c128 100755
@@ -478,6 +478,7 @@ _wrapup()
 		fi
 
 		_global_log ""
+		_global_log "Kernel version: $(uname -r)"
 		_global_log "$(date)"
 
 		echo "SECTION       -- $section" >>$tmp.summary
Signature · 1 line
2.45.1
#2 lore raw
Quoted 6 lines · Darrick J. Wong
Quoted 5 lines · On Wed, May 22, 2024 at 01:33:38PM +0200, [email protected] wrote:

From: Carlos Maiolino <[email protected]>

After collecting several xfstests runs, it's useful to keep track on which kernel a specific run happened.

Quoted 6 lines
Quoted 1 line

I wonder if you want to capture more of the system variables, like __generate_report_vars does?

(Should we be capturing ${FSTYP}progs version too?)

That's good to me, but my concern is: It's hard to have a common method to get the ${FSTYP}progs version. For most of localfs, "mkfs.$FSTYP -V" can get a version message, but not all can do that. Even if we can let each $FSTYP get its version through its own way, but the testers can install the ${FSTYP}progs by many different ways, e.g. make & make install, or a .rpm, or a .deb or something else.

If you have any good idea, please feel free to tell me:)

Thanks,
Zorro

Quoted 26 lines

--D

Quoted 20 lines
---
 check | 1 +
 1 file changed, 1 insertion(+)
check +1 -0
index c6dba89b..7703c128 100755
@@ -478,6 +478,7 @@ _wrapup()
 		fi
 
 		_global_log ""
+		_global_log "Kernel version: $(uname -r)"
 		_global_log "$(date)"
 
 		echo "SECTION       -- $section" >>$tmp.summary
Signature · 1 line
2.45.1