Skip to contentSkip to conversation

xfs_io: make MADV_SOFT_OFFLINE conditional

PATCH Superseded Bastian Germann 2 participants 2 messages May 22, 2024

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs_io: make MADV_SOFT_OFFLINE conditional

mips64el does not have the symbol MADV_SOFT_OFFLINE, so wrap it in an ifdef.

---
 io/madvise.c | 2 ++
 1 file changed, 2 insertions(+)
io/madvise.c +2 -0
index ede23395..1d664f8d 100644
@@ -101,9 +101,11 @@ madvise_f(
 		case 'M':	/* disable merging */
 			advise = MADV_UNMERGEABLE;
 			break;
+#ifdef MADV_SOFT_OFFLINE
 		case 'o':	/* offline */
 			advise = MADV_SOFT_OFFLINE;
 			break;
+#endif
 		case 'p':	/* punch hole */
 			advise = MADV_REMOVE;
 			break;
Signature · 1 line
2.45.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Bastian Germann

mips64el does not have the symbol MADV_SOFT_OFFLINE, so wrap it in an ifdef.

---
 io/madvise.c | 2 ++
 1 file changed, 2 insertions(+)
io/madvise.c +0 -0
index ede23395..1d664f8d 100644

io/madvise.c madvise_f( · line 108

Quoted 8 lines
io/madvise.c +2 -0
@@ -101,9 +101,11 @@ madvise_f(
 		case 'M':	/* disable merging */
 			advise = MADV_UNMERGEABLE;
 			break;
+#ifdef MADV_SOFT_OFFLINE
 		case 'o':	/* offline */
 			advise = MADV_SOFT_OFFLINE;
 			break;
+#endif

Please #ifdef guard the -o line in madvise_help so it doesn't show up in the help screen on mips64el.

With that added,

--D

Quoted 7 lines
io/madvise.c +0 -0
 		case 'p':	/* punch hole */
 			advise = MADV_REMOVE;
 			break;
Signature · 1 line
2.45.0