Skip to contentSkip to conversation

DISCUSSION Simon Horman 1 participant 1 message May 23, 2024

Subsystems (4)
lore
Share & tools
lore

Simon Horman

author reviewer
#0 lore raw

Bcc:
Subject: Re: [PATCH v9 3/8] x86/vmware: Introduce VMware hypercall API Reply-To:
In-Reply-To: <[email protected]>

+ Joe Perches

Quoted 7 lines · Alexey Makhalov

Hi Simon, apologize for long delay

Quoted 4 lines · Simon Horman
Quoted 1 line
arch/x86/include/asm/vmware.h +0 -0

...

Quoted 8 lines
Quoted 6 lines

arch/x86/include/asm/vmware.h

Quoted 3 lines
arch/x86/include/asm/vmware.h +3 -0
+static inline
+unsigned long vmware_hypercall3(unsigned long cmd, unsigned long in1,
+				uint32_t *out1, uint32_t *out2)

nit: u32 is preferred over uint32_t.
Likewise elsewhere in this patch-set.

Good to know. Can you please shed a light on the reason? I still see bunch of stdint style uint32_t in arch/x86.

Perhaps there is a document on this that I should know about. But AFAIK, u32 and so on are Linux kernel types, while uint32_t are C99-standard types.

Joe, are you able to shed any further light on this?

...