selftests: kvm: fix shift of 32 bit unsigned int more than 32 bits
Subsystems (3)
PATCH v2 1/1 selftests: kvm: fix shift of 32 bit unsigned int more than 32 bits
Currrentl a 32 bit 1u value is being shifted more than 32 bits causing overflow and incorrect checking of bits 32-63. Fix this by using the BIT_ULL macro for shifting bits.
Detected by cppcheck:
sev_init2_tests.c:108:34: error: Shifting 32-bit value by 63 bits is undefined behaviour [shiftTooManyBits]
---
V2: Fix incorrect variable in 2nd BIT_ULL(), kudos to Dan Carpenter for
catching this error.
--- tools/testing/selftests/kvm/x86_64/sev_init2_tests.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/kvm/x86_64/sev_init2_tests.c +2 -2
@@ -105,11 +105,11 @@ void test_features(uint32_t vm_type, uint64_t supported_features)int i;for (i =0 ; i <64 ; i++) { -if (!(supported_features & (1u << i))) +if (!(supported_features &BIT_ULL (i)))test_init2_invalid (vm_type, &(struct kvm_sev_init ){ .vmsa_features =BIT_ULL (i) },"unknown feature" ); -else if (KNOWN_FEATURES & (1u << i)) +else if (KNOWN_FEATURES &BIT_ULL (i))test_init2 (vm_type, &(struct kvm_sev_init ){ .vmsa_features =BIT_ULL (i) }); }
Signature · 1 line
2.39.2
Quoted 9 lines · Colin Ian King
Currrentl a 32 bit 1u value is being shifted more than 32 bits causing overflow and incorrect checking of bits 32-63. Fix this by using the
BIT_ULLmacro for shifting bits.Detected by cppcheck:
sev_init2_tests.c:108:34: error: Shifting 32-bit value by 63 bits is undefined behaviour [shiftTooManyBits][...]
Applied to kvm-x86 fixes, thanks!
[1/1] selftests: kvm: fix shift of 32 bit unsigned int more than 32 bits
https://github.com/kvm-x86/linux/commit/9a68cefe9f05