_test_mkfs: Include external log device (if any) when creating fs on TEST_DEV
PATCH 1/1 _test_mkfs: Include external log device (if any) when creating fs on TEST_DEV
Test execution fails when testing XFS with external log device and when RECREATE_TEST_DEV is set to true. This is because _test_mkfs() is invoked as part of recreating the filesystem on test device and this function does not include the external log device as part of the mkfs.xfs command line.
_test_mount() invoked later fails since it passes an external log device to the mount syscall which the kernel does not expect to find.
To fix this bug, this commit modifies _test_mkfs() to invoke _test_options() in order to compute the value of TEST_OPTIONS and includes the resulting value in the mkfs.xfs command line.
--- common/rc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
common/rc +2 -1
@@ -614,7 +614,8 @@ _test_mkfs() $MKFS_PROG -t $FSTYP -- -F $MKFS_OPTIONS $* $TEST_DEV ;; xfs) - $MKFS_PROG -t $FSTYP -- -f $MKFS_OPTIONS $* $TEST_DEV + _test_options mkfs + $MKFS_PROG -t $FSTYP -- -f $TEST_OPTIONS $MKFS_OPTIONS $* $TEST_DEV ;; bcachefs) $MKFS_BCACHEFS_PROG $MKFS_OPTIONS $* $TEST_DEV > /dev/null
Signature · 1 line
2.43.0
Looks good:
Quoted 5 lines · Chandan Babu R
Test execution fails when testing XFS with external log device and when
RECREATE_TEST_DEVis set to true. This is because_test_mkfs()is invoked as part of recreating the filesystem on test device and this function does not include the external log device as part of the mkfs.xfs command line.
Quoted 8 lines
_test_mount()invoked later fails since it passes an external log device to the mount syscall which the kernel does not expect to find.To fix this bug, this commit modifies
_test_mkfs()to invoke_test_options()in order to compute the value ofTEST_OPTIONSand includes the resulting value in the mkfs.xfs command line.Signed-off-by Chandan Babu R <[email protected]>
Doh
--D
Quoted 22 lines
--- common/rc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)common/rc +2
-1@@ -614,7 +614,8 @@ _test_mkfs() $MKFS_PROG -t $FSTYP -- -F $MKFS_OPTIONS $* $TEST_DEV ;; xfs) - $MKFS_PROG -t $FSTYP -- -f $MKFS_OPTIONS $* $TEST_DEV + _test_options mkfs + $MKFS_PROG -t $FSTYP -- -f $TEST_OPTIONS $MKFS_OPTIONS $* $TEST_DEV ;; bcachefs) $MKFS_BCACHEFS_PROG $MKFS_OPTIONS $* $TEST_DEV > /dev/nullSignature · 1 line
2.43.0