Dead structs in media/platform
Subsystems (4)
cover Dead structs in media/platform
From: "Dr. David Alan Gilbert" <[email protected]>
Clean out a bunch of dead structs in media/platform. Build tested only.
Dr. David Alan Gilbert (3):
meida: amphion: remove unused struct 'vpu_malone_frame_buffer'
media: m2m-deinterlace: remove unused struct 'vb2_dc_conf'
media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'
drivers/media/platform/amphion/vpu_malone.c | 5 ----- drivers/media/platform/m2m-deinterlace.c | 4 ---- drivers/media/platform/nvidia/tegra-vde/h264.c | 5 ----- 3 files changed, 14 deletions(-)
Signature · 1 line
2.45.1
PATCH 2/3 media: m2m-deinterlace: remove unused struct 'vb2_dc_conf'
From: "Dr. David Alan Gilbert" <[email protected]>
'vb2_dc_conf' has been unused since the original
commit 8f0755c06b90 ("[media] media: Add mem2mem deinterlacing driver").
Remove it.
--- drivers/media/platform/m2m-deinterlace.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/media/platform/m2m-deinterlace.c +0 -4
@@ -724,10 +724,6 @@ static const struct v4l2_ioctl_ops deinterlace_ioctl_ops = {/* * Queue operations */ -struct vb2_dc_conf { -struct device *dev; -}; -static int deinterlace_queue_setup (struct vb2_queue *vq,unsigned int *nbuffers,unsigned int *nplanes,unsigned int sizes[],struct device *alloc_devs[])
Signature · 1 line
2.45.1
PATCH 1/3 meida: amphion: remove unused struct 'vpu_malone_frame_buffer'
In reply to [email protected]From: "Dr. David Alan Gilbert" <[email protected]>
'vpu_malone_frame_buffer' has been unused since the original commit 145e936380ed ("media: amphion: implement malone decoder rpc interface").
Remove it.
--- drivers/media/platform/amphion/vpu_malone.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/media/platform/amphion/vpu_malone.c +0 -5
@@ -207,11 +207,6 @@ struct vpu_malone_dbglog_desc {u32 reserved; }; -struct vpu_malone_frame_buffer { -u32 addr; -u32 size; -}; -struct vpu_malone_udata {u32 base;u32 total_size;
Signature · 1 line
2.45.1
PATCH 3/3 media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'
In reply to [email protected]From: "Dr. David Alan Gilbert" <[email protected]>
'tegra_vde_h264_frame' has been unused since
commit 313db7d235a0 ("media: staging: tegra-vde: Remove legacy UAPI support").
Remove it.
--- drivers/media/platform/nvidia/tegra-vde/h264.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/media/platform/nvidia/tegra-vde/h264.c +0 -5
@@ -19,11 +19,6 @@#define FLAG_B_FRAME 0x1#define FLAG_REFERENCE 0x2 -struct tegra_vde_h264_frame { -unsigned int frame_num; -unsigned int flags; -}; -struct tegra_vde_h264_decoder_ctx {unsigned int dpb_frames_nb;unsigned int dpb_ref_frames_with_earlier_poc_nb;
Signature · 1 line
2.45.1
Re: [PATCH 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'
Quoted 19 lines · On 25/05/2024 02:01, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
'
tegra_vde_h264_frame' has been unused since
commit313db7d235a0("media: staging: tegra-vde: Remove legacy UAPI support").Remove it.
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- drivers/media/platform/nvidia/tegra-vde/h264.c | 5 ----- 1 file changed, 5 deletions(-)drivers/media/platform/nvidia/tegra-vde/h264.c +0
-0@@ -19,11 +19,6 @@#define FLAG_B_FRAME 0x1
drivers/media/platform/nvidia/tegra-vde/h264.c line 24
Quoted 10 lines
drivers/media/platform/nvidia/tegra-vde/h264.c +0
-5#define FLAG_REFERENCE 0x2 -struct tegra_vde_h264_frame { -unsigned int frame_num; -unsigned int flags; -}; -struct tegra_vde_h264_decoder_ctx {unsigned int dpb_frames_nb;unsigned int dpb_ref_frames_with_earlier_poc_nb;
There is one more reference to this, that also can be dropped:
$ git grep tegra_vde_h264_frame drivers/media/platform/nvidia/tegra-vde/vde.h:struct tegra_vde_h264_frame;
Regards,
Hans
Re: [PATCH 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'
Quoted 33 lines · * Hans Verkuil ([email protected]) wrote:
Quoted 19 lines · On 25/05/2024 02:01, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
'
tegra_vde_h264_frame' has been unused since
commit313db7d235a0("media: staging: tegra-vde: Remove legacy UAPI support").Remove it.
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- drivers/media/platform/nvidia/tegra-vde/h264.c | 5 ----- 1 file changed, 5 deletions(-)drivers/media/platform/nvidia/tegra-vde/h264.c +0
-0@@ -19,11 +19,6 @@#define FLAG_B_FRAME 0x1drivers/media/platform/nvidia/tegra-vde/h264.c line 24
Quoted 10 lines
drivers/media/platform/nvidia/tegra-vde/h264.c +0
-5#define FLAG_REFERENCE 0x2 -struct tegra_vde_h264_frame { -unsigned int frame_num; -unsigned int flags; -}; -struct tegra_vde_h264_decoder_ctx {unsigned int dpb_frames_nb;unsigned int dpb_ref_frames_with_earlier_poc_nb;There is one more reference to this, that also can be dropped:
Quoted 2 lines
$ git grep tegra_vde_h264_frame drivers/media/platform/nvidia/tegra-vde/vde.h:struct tegra_vde_h264_frame;
Thanks! v2 just sent (where I also fixed a typo in the first patch in the series's title).
Dave
Quoted 4 lines
Regards,
Hans
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/