tests/intel/kms_pm_dc: Add a new test to validate the deep sleep state during extended vblank
PATCH 1/1 tests/intel/kms_pm_dc: Add a new test to validate the deep sleep state during extended vblank
Add a new test to validate deep sleep states during extended vblank scenarios, where two frames are committed simultaneously for a give time with reduced refresh rate.
v2: dealy of one frame added to simulate extended vblank.
remove vrr related debug checks.
--- tests/intel/kms_pm_dc.c | 49 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+)
tests/intel/kms_pm_dc.c +49 -0
@@ -584,6 +584,46 @@ static unsigned int read_pkgc_counter(int debugfs_root_fd)return get_dc_counter (str); } +static void test_deep_pkgc_state (data_t *data) +{ +unsigned int pre_val =0 , cur_val =0 ; +time_t start =time (NULL ), duration =2 , delay; +enum pipe pipe; +bool pkgc_flag; +igt_display_t *display = &data->display; +igt_plane_t *primary; +igt_output_t *output; + +for_each_pipe_with_valid_output (display, pipe, output) { +igt_output_set_pipe (output, pipe); + data->output = output; + data->mode =igt_output_get_mode (output); +setup_videoplayback (data); +igt_require (igt_output_has_prop (output,IGT_CONNECTOR_VRR_CAPABLE )); +igt_require (igt_output_get_prop (output,IGT_CONNECTOR_VRR_CAPABLE )); + + primary =igt_output_get_plane_type (data->output, +DRM_PLANE_TYPE_PRIMARY ); + pre_val =read_pkgc_counter (data->debugfs_root_fd); + delay =1 * ((1000 *1000 ) / data->mode->vrefresh); +while (time (NULL ) - start < duration) { +igt_plane_set_fb (primary, &data->fb_rgb); +igt_display_commit (&data->display); +usleep (delay); + +igt_plane_set_fb (primary, &data->fb_rgr); +igt_display_commit (&data->display); + cur_val =read_pkgc_counter (data->debugfs_root_fd); +if (cur_val > pre_val) { + pkgc_flag = true; +continue ; + } + } + } +cleanup_dc3co_fbs (data); +igt_assert_f (pkgc_flag,"PKGC10 is not achieved.\n" ); +} +static void test_pkgc_state_dpms (data_t *data) {unsigned int timeout_sec =6 ;
@@ -687,6 +727,15 @@ igt_maintest_dc_state_psr (&data,CHECK_DC6 ); } +igt_describe ("This test validates display engine entry to DC8 state " +"while extended vblank" ); + igt_subtest("deep-pkgc") { +igt_require_f (igt_pm_pc8_plus_residencies_enabled (data.msr_fd), +"PC8+ residencies not supported\n" ); +igt_require (intel_display_ver (data.devid) >=20 ); +test_deep_pkgc_state (&data); + } +igt_describe ("This test validates display engine entry to DC5 state " "while all connectors's DPMS property set to OFF" ); igt_subtest("dc5-dpms") {
Signature · 1 line
2.25.1
Quoted 5 lines
Subject: [PATCH i-g-t] tests/intel/kms_pm_dc: Add a new test to validate the deep sleep state during extended vblank
Add a new test to validate deep sleep states during extended vblank scenarios, where two frames are committed simultaneously for a give time with reduced
Typo here *given
Quoted 27 lines
refresh rate.
v2: dealy of one frame added to simulate extended vblank.
remove vrr related debug checks.Signed-off-by Jeevan B <[email protected]>--- tests/intel/kms_pm_dc.c | 49 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+)tests/intel/kms_pm_dc.c index renamed from tests/intel/kms_pm_dc.c +0
-0
7766d34d7..9f89e537d100644tests/intel/kms_pm_dc.c +8
-0@@ -584,6 +584,46 @@ static unsigned int read_pkgc_counter(int debugfs_root_fd)return get_dc_counter (str); } +static void test_deep_pkgc_state (data_t *data) { +unsigned int pre_val =0 , cur_val =0 ; +time_t start =time (NULL ), duration =2 , delay; +enum pipe pipe; +bool pkgc_flag; +igt_display_t *display = &data->display; +igt_plane_t *primary; +igt_output_t *output;
tests/intel/kms_pm_dc.c static unsigned int read_pkgc_counter(int · line 605
Quoted 10 lines
tests/intel/kms_pm_dc.c +8
-0+ +for_each_pipe_with_valid_output (display, pipe, output) { +igt_output_set_pipe (output, pipe); + data->output = output; + data->mode =igt_output_get_mode (output); +setup_videoplayback (data); +igt_require (igt_output_has_prop (output,IGT_CONNECTOR_VRR_CAPABLE )); +igt_require (igt_output_get_prop (output,IGT_CONNECTOR_VRR_CAPABLE ));
Why are there two igt_require checking the same thing here?
tests/intel/kms_pm_dc.c static unsigned int read_pkgc_counter(int debugfs_root_fd) · line 608
Quoted 6 lines
tests/intel/kms_pm_dc.c +3
-0+ + primary = igt_output_get_plane_type(data->output, +
DRM_PLANE_TYPE_PRIMARY);tests/intel/kms_pm_dc.c +2
-0+ pre_val =read_pkgc_counter (data->debugfs_root_fd); + delay =1 * ((1000 *1000 ) / data->mode->vrefresh);
If 1000*1000 is constant why not use a #define would look cleaner
Quoted 20 lines
tests/intel/kms_pm_dc.c +17
-0+while (time (NULL ) - start < duration) { +igt_plane_set_fb (primary, &data->fb_rgb); +igt_display_commit (&data->display); +usleep (delay); + +igt_plane_set_fb (primary, &data->fb_rgr); +igt_display_commit (&data->display); + cur_val =read_pkgc_counter (data->debugfs_root_fd); +if (cur_val > pre_val) { + pkgc_flag = true; +continue ; + } + } + } +cleanup_dc3co_fbs (data); +igt_assert_f (pkgc_flag,"PKGC10 is not achieved.\n" ); } +static void test_pkgc_state_dpms (data_t *data) {unsigned int timeout_sec =6 ;
tests/intel/kms_pm_dc.c igt_main · line 731
Quoted 5 lines
tests/intel/kms_pm_dc.c +2
-0@@ -687,6 +727,15 @@ igt_maintest_dc_state_psr (&data,CHECK_DC6 ); } +igt_describe ("This test validates display engine entry to DC8 state " +"while extended vblank" );
*during extended vblank
Regards,
Suraj Kandpal
Quoted 13 lines
tests/intel/kms_pm_dc.c +7
-0+ igt_subtest("deep-pkgc") { +igt_require_f (igt_pm_pc8_plus_residencies_enabled (data.msr_fd), +"PC8+ residencies not supported\n" ); +igt_require (intel_display_ver (data.devid) >=20 ); +test_deep_pkgc_state (&data); + } +igt_describe ("This test validates display engine entry to DC5 state " "while all connectors's DPMS property set to OFF" );
igt_subtest("dc5-dpms"){
--
2.25.1
Patchwork
CI✗ Fi.CI.BUILD: failure for tests/intel/kms_pm_dc: Add a new test to validate the deep sleep state during extended vblank
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: tests/intel/kms_pm_dc: Add a new test to validate the deep sleep state during extended vblank
URL : https://patchwork.freedesktop.org/series/134058/
State : failure
== Summary ==
IGT patchset build failed on latest successful build 1d7b961235e345db20933c057f265898e2e96fd2 tests: Fix Sub-category in documentation
Tail of build.log:
[1632/1679] Linking target tools/intel_vbt_decode.
[1633/1679] Linking target tools/intel_pm_rpm.
[1634/1679] Linking target tools/lsgpu.
[1635/1679] Linking target runner/testdata/skippers.
[1636/1679] Linking target tools/intel_stepping.
[1637/1679] Linking target tools/intel_residency.
[1638/1679] Linking target runner/testdata/dynamic.
[1639/1679] Linking target tools/intel_gem_info.
[1640/1679] Linking target tools/intel_l3_parity.
[1641/1679] Linking target runner/testdata/abort-fixture.
[1642/1679] Linking target tools/intel_watermark.
[1643/1679] Generating gem_stress.testlist with a meson_exe.py custom command.
[1644/1679] Linking target runner/igt_comms_decoder.
[1645/1679] Linking target tools/amd_hdmi_compliance.
[1646/1679] Linking target runner/igt_runner.
[1647/1679] Linking target runner/testdata/abort-simple.
[1648/1679] Linking target runner/testdata/abort-dynamic.
[1649/1679] Linking target runner/testdata/no-subtests.
[1650/1679] Linking target tools/msm_dp_compliance.
[1651/1679] Linking target runner/testdata/successtest.
[1652/1679] Linking target runner/igt_resume.
[1653/1679] Linking target runner/testdata/abort.
[1654/1679] Linking target runner/runner_json_test.
[1655/1679] Linking target runner/igt_results.
[1656/1679] Compiling C object 'lib/76b5a35@@i915_perf@sha/meson-generated_.._i915_perf_metrics_acmgt1.c.o'.
[1657/1679] Compiling C object 'runner/527aa9f@@runner_test@exe/runner_tests.c.o'.
[1658/1679] Linking target runner/runner_test.
[1659/1679] Compiling C object 'lib/76b5a35@@i915_perf@sha/meson-generated_.._i915_perf_metrics_acmgt2.c.o'.
[1660/1679] Compiling C object 'lib/76b5a35@@i915_perf@sha/meson-generated_.._i915_perf_metrics_acmgt3.c.o'.
[1661/1679] Linking target lib/libi915_perf.so.1.5.
[1662/1679] Generating symbol file 'lib/76b5a35@@i915_perf@sha/libi915_perf.so.1.5.symbols'.
[1663/1679] Linking target tools/i915-perf/i915-perf-configs.
[1664/1679] Linking target tools/i915-perf/i915-perf-reader.
[1665/1679] Linking target tests/gem_barrier_race.
[1666/1679] Linking target tests/perf.
[1667/1679] Linking target tools/i915-perf/i915-perf-recorder.
[1668/1679] Linking target tests/core_hotunplug.
[1669/1679] Generating gem_barrier_race.testlist with a meson_exe.py custom command.
[1670/1679] Generating perf.testlist with a meson_exe.py custom command.
[1671/1679] Generating core_hotunplug.testlist with a meson_exe.py custom command.
[1672/1679] Generating xe_tests.rst with a custom command.
[1673/1679] Generating kms_tests.rst with a custom command.
FAILED: docs/testplan/kms_tests.rst/usr/src/igt-gpu-tools/scripts/igt_doc.py --config /usr/src/igt-gpu-tools/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /opt/igt/build
Warning: Missing documentation for igt@kms_pm_dc@deep-pkgc
Please refer: docs/test_documentation.md for more details
[1674/1679] Generating i915_tests.rst with a custom command.
[1675/1679] Generating intel-ci-tests with a custom command.
[1676/1679] Generating xe_tests.html with a custom command.
ninja: build stopped: subcommand failed.
Patchwork
CI✗ GitLab.Pipeline: warning for tests/intel/kms_pm_dc: Add a new test to validate the deep sleep state during extended vblank
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: tests/intel/kms_pm_dc: Add a new test to validate the deep sleep state during extended vblank
URL : https://patchwork.freedesktop.org/series/134058/
State : warning
== Summary ==
Pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/1186674 for the overview.
build:tests-debian-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59173459):
[1796/1801] Generating intel-ci-tests with a custom command.
[1797/1801] Generating xe_tests.html with a custom command.
[1798/1801] Compiling C object 'runner/527aa9f@@runner_test@exe/runner_tests.c.o'.
ninja: build stopped: subcommand failed.
ninja: Entering directory `build'
[1/824] Generating version.h with a custom command.
[2/6] Linking target runner/runner_test.
[3/6] Generating i915_tests.html with a custom command.
[4/6] Generating kms_tests.rst with a custom command.
FAILED: docs/testplan/kms_tests.rst
/builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
Warning: Missing documentation for igt@kms_pm_dc@deep-pkgc
Please refer: docs/test_documentation.md for more details
ninja: build stopped: subcommand failed.
section_end:1716791548:step_script
section_start:1716791548:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1716791549:cleanup_file_variables
ERROR: Job failed: exit code 1
build:tests-fedora has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59173454):
[1803/1807] Generating xe_tests.html with a custom command.
[1804/1807] Compiling C object 'runner/527aa9f@@runner_test@exe/runner_tests.c.o'.
ninja: build stopped: subcommand failed.
ninja: Entering directory `build'
[1/826] Generating version.h with a custom command.
[2/6] Linking target runner/runner_test.
[3/6] Generating intel-ci-tests with a custom command.
[4/6] Generating i915_tests.html with a custom command.
[5/6] Generating kms_tests.rst with a custom command.
FAILED: docs/testplan/kms_tests.rst
/builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
Warning: Missing documentation for igt@kms_pm_dc@deep-pkgc
Please refer: docs/test_documentation.md for more details
ninja: build stopped: subcommand failed.
section_end:1716791553:step_script
section_start:1716791553:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1716791554:cleanup_file_variables
ERROR: Job failed: exit code 1
build:tests-fedora-clang has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59173458):
[1803/1807] Generating i915_tests.rst with a custom command.
[1804/1807] Generating intel-ci-tests with a custom command.
[1805/1807] Generating xe_tests.html with a custom command.
ninja: build stopped: subcommand failed.
ninja: Entering directory `build'
[1/826] Generating version.h with a custom command.
[2/5] Generating i915_tests.html with a custom command.
[3/5] Generating intel-ci-tests with a custom command.
[4/5] Generating kms_tests.rst with a custom command.
FAILED: docs/testplan/kms_tests.rst
/builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
Warning: Missing documentation for igt@kms_pm_dc@deep-pkgc
Please refer: docs/test_documentation.md for more details
ninja: build stopped: subcommand failed.
section_end:1716791526:step_script
section_start:1716791526:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1716791526:cleanup_file_variables
ERROR: Job failed: exit code 1
build:tests-fedora-no-libdrm-nouveau has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59173457):
[1635/1639] Generating xe_tests.html with a custom command.
[1636/1639] Compiling C object 'runner/527aa9f@@runner_test@exe/runner_tests.c.o'.
ninja: build stopped: subcommand failed.
ninja: Entering directory `build'
[1/775] Generating version.h with a custom command.
[2/6] Linking target runner/runner_test.
[3/6] Generating intel-ci-tests with a custom command.
[4/6] Generating i915_tests.html with a custom command.
[5/6] Generating kms_tests.rst with a custom command.
FAILED: docs/testplan/kms_tests.rst
/builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
Warning: Missing documentation for igt@kms_pm_dc@deep-pkgc
Please refer: docs/test_documentation.md for more details
ninja: build stopped: subcommand failed.
section_end:1716791549:step_script
section_start:1716791549:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1716791550:cleanup_file_variables
ERROR: Job failed: exit code 1
build:tests-fedora-no-libunwind has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59173455):
[1803/1807] Generating xe_tests.html with a custom command.
[1804/1807] Compiling C object 'runner/527aa9f@@runner_test@exe/runner_tests.c.o'.
ninja: build stopped: subcommand failed.
ninja: Entering directory `build'
[1/826] Generating version.h with a custom command.
[2/6] Linking target runner/runner_test.
[3/6] Generating intel-ci-tests with a custom command.
[4/6] Generating i915_tests.html with a custom command.
[5/6] Generating kms_tests.rst with a custom command.
FAILED: docs/testplan/kms_tests.rst
/builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
Warning: Missing documentation for igt@kms_pm_dc@deep-pkgc
Please refer: docs/test_documentation.md for more details
ninja: build stopped: subcommand failed.
section_end:1716791551:step_script
section_start:1716791551:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1716791552:cleanup_file_variables
ERROR: Job failed: exit code 1
build:tests-fedora-oldest-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59173456):
[1803/1807] Generating xe_tests.html with a custom command.
[1804/1807] Compiling C object 'runner/runner@@runner_test@exe/runner_tests.c.o'.
ninja: build stopped: subcommand failed.
ninja: Entering directory `build'
[1/826] Generating version.h with a custom command.
[2/6] Linking target runner/runner_test.
[3/6] Generating intel-ci-tests with a custom command.
[4/6] Generating i915_tests.html with a custom command.
[5/6] Generating kms_tests.rst with a custom command.
FAILED: docs/testplan/kms_tests.rst
/builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
Warning: Missing documentation for igt@kms_pm_dc@deep-pkgc
Please refer: docs/test_documentation.md for more details
ninja: build stopped: subcommand failed.
section_end:1716791506:step_script
section_start:1716791506:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1716791507:cleanup_file_variables
ERROR: Job failed: exit code 1
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/1186674
Quoted 48 lines
-----Original Message-----
From: Kandpal, Suraj <[email protected]>
Sent: Monday, May 27, 2024 10:33 AM
To: B, Jeevan <[email protected]>; [email protected]
Cc: Modem, Bhanuprakash <[email protected]>
Subject: RE: [PATCH i-g-t] tests/intel/kms_pm_dc: Add a new test to validate the deep sleep state during extended vblankQuoted 6 lines
Subject: [PATCH i-g-t] tests/intel/kms_pm_dc: Add a new test to validate the deep sleep state during extended vblank
Add a new test to validate deep sleep states during extended vblank scenarios, where two frames are committed simultaneously for a give time with reduced
Typo here *given
Quoted 31 lines
refresh rate.
v2: dealy of one frame added to simulate extended vblank.
remove vrr related debug checks.Signed-off-by Jeevan B <[email protected]>--- tests/intel/kms_pm_dc.c | 49 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+)tests/intel/kms_pm_dc.c index renamed from tests/intel/kms_pm_dc.c +0
-0
7766d34d7..9f89e537d100644tests/intel/kms_pm_dc.c +12
-0@@ -584,6 +584,46 @@ static unsigned int read_pkgc_counter(int debugfs_root_fd)return get_dc_counter (str); } +static void test_deep_pkgc_state (data_t *data) { +unsigned int pre_val =0 , cur_val =0 ; +time_t start =time (NULL ), duration =2 , delay; +enum pipe pipe; +bool pkgc_flag; +igt_display_t *display = &data->display; +igt_plane_t *primary; +igt_output_t *output; + +for_each_pipe_with_valid_output (display, pipe, output) { +igt_output_set_pipe (output, pipe); + data->output = output;
Quoted 8 lines
tests/intel/kms_pm_dc.c static unsigned int read_pkgc_counter(int · line 605
Quoted 6 lines
tests/intel/kms_pm_dc.c +4
-0+ data->mode =igt_output_get_mode (output); +setup_videoplayback (data); +igt_require (igt_output_has_prop (output,IGT_CONNECTOR_VRR_CAPABLE )); +igt_require (igt_output_get_prop (output,IGT_CONNECTOR_VRR_CAPABLE ));Why are there two
igt_requirechecking the same thing here?
To check VRR is supported and available.
BR, Jeevan B
Quoted 53 lines
tests/intel/kms_pm_dc.c static unsigned int read_pkgc_counter(int debugfs_root_fd) · line 608
Quoted 7 lines
tests/intel/kms_pm_dc.c +3
-0+ + primary = igt_output_get_plane_type(data->output, +
DRM_PLANE_TYPE_PRIMARY);tests/intel/kms_pm_dc.c +2
-0+ pre_val =read_pkgc_counter (data->debugfs_root_fd); + delay =1 * ((1000 *1000 ) / data->mode->vrefresh);If 1000*1000 is constant why not use a #define would look cleaner
Quoted 20 lines
tests/intel/kms_pm_dc.c +17
-0+while (time (NULL ) - start < duration) { +igt_plane_set_fb (primary, &data->fb_rgb); +igt_display_commit (&data->display); +usleep (delay); + +igt_plane_set_fb (primary, &data->fb_rgr); +igt_display_commit (&data->display); + cur_val =read_pkgc_counter (data->debugfs_root_fd); +if (cur_val > pre_val) { + pkgc_flag = true; +continue ; + } + } + } +cleanup_dc3co_fbs (data); +igt_assert_f (pkgc_flag,"PKGC10 is not achieved.\n" ); } +static void test_pkgc_state_dpms (data_t *data) {unsigned int timeout_sec =6 ;tests/intel/kms_pm_dc.c igt_main · line 731
Quoted 5 lines
tests/intel/kms_pm_dc.c +2
-0@@ -687,6 +727,15 @@ igt_maintest_dc_state_psr (&data,CHECK_DC6 ); } +igt_describe ("This test validates display engine entry to DC8 state " +"while extended vblank" );*during extended vblank
Regards,
Suraj KandpalQuoted 13 lines
tests/intel/kms_pm_dc.c +7
-0+ igt_subtest("deep-pkgc") { +igt_require_f (igt_pm_pc8_plus_residencies_enabled (data.msr_fd), +"PC8+ residencies not supported\n" ); +igt_require (intel_display_ver (data.devid) >=20 ); +test_deep_pkgc_state (&data); + } +igt_describe ("This test validates display engine entry to DC5 state " "while all connectors's DPMS property set to OFF" );
igt_subtest("dc5-dpms"){
--
2.25.1